chore: Enforce HTTP 1.1

Author: CubitsDev

src/main/java/dev/tomr/hcloud/HetznerCloud.java

@@ -115,12 +115,4 @@ public boolean hasApiKey() {
     public Server getServer(Integer id) {
         return serviceManager.getServerService().getServer(id);
     }
-
-    /**
-     * Returns the HETZNER_CLOUD_HOST constant
-     * @return String with the hetzner cloud host
-     */
-    public static String getHetznerCloudHost() {
-        return HETZNER_CLOUD_HOST;
-    }
 }

src/main/java/dev/tomr/hcloud/http/HetznerCloudHttpClient.java

@@ -88,12 +88,7 @@ public <T extends HetznerJsonObject> T sendHttpRequest(Class<T> clazz, String en
     }
 
     private HttpRequest createHttpRequest(String uri, RequestVerb requestVerb, String apiKey, String body) {
-        // wiremock seems to have problems with using HTTP/2 sometimes (seems like a bug in the http client) - therefore if we know it's Hetzner,
-        // we'll enforce HTTP/2 - otherwise HTTP/1.1
         HttpClient.Version version = HttpClient.Version.HTTP_1_1;
-        if (HetznerCloud.getInstance().getHttpDetails().get(0).equals(HetznerCloud.getHetznerCloudHost())) {
-            version = HttpClient.Version.HTTP_2;
-        }
         HttpRequest.Builder builder = HttpRequest.newBuilder()
                 .uri(URI.create(uri))
                 .version(version)

src/test/java/dev/tomr/hcloud/component/http/HttpClientComponentTest.java

@@ -129,25 +129,4 @@ void httpClientHandles204NoContent() {
 
         assertDoesNotThrow(() -> client.sendHttpRequest(TestModel.class, HOST + "test", RequestVerb.GET, ""));
     }
-
-//    @Test
-//    @DisplayName("Request uses HTTP/2 when targeting Hetzner, instead of HTTP/1.1 by default")
-//    void requestUsesHttp2WhenTargetingHetznerHost() throws IOException, InterruptedException, IllegalAccessException {
-//        wireMockExtension.stubFor(get("/test").willReturn(ok(objectMapper.writeValueAsString(new TestModel(1, 1, "sunt aut facere repellat provident occaecati excepturi optio reprehenderit", "quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto")))));
-//        HetznerCloud hetznerCloud = mock(HetznerCloud.class);
-//        try (MockedStatic<HetznerCloud> hetznerCloudMockedStatic = mockStatic(HetznerCloud.class)) {
-//            hetznerCloudMockedStatic.when(HetznerCloud::getHetznerCloudHost).thenReturn(HOST);
-//            hetznerCloudMockedStatic.when(HetznerCloud::getInstance).thenReturn(hetznerCloud);
-//            when(hetznerCloud.getHttpDetails()).thenReturn(List.of(HOST, ""));
-//
-//            HetznerCloudHttpClient client = new HetznerCloudHttpClient();
-//
-//            TestModel testModel = client.sendHttpRequest(TestModel.class, HOST + "test", RequestVerb.GET, "");
-//
-//            assertEquals(1, testModel.getId());
-//            assertEquals(1, testModel.getUserId());
-//            assertEquals("sunt aut facere repellat provident occaecati excepturi optio reprehenderit", testModel.getTitle());
-//            assertEquals("quia et suscipit\nsuscipit recusandae consequuntur expedita et cum\nreprehenderit molestiae ut ut quas totam\nnostrum rerum est autem sunt rem eveniet architecto", testModel.getBody());
-//        }
-//    }
 }