workspace: Rust 1.88..=1.90 (#553)

* clippy --fix

* add lints

* remove expect

Author: hinto-janai

Cargo.toml

@@ -365,6 +365,8 @@ precedence_bits = "deny"
 as_pointer_underscore = "deny"
 literal_string_with_formatting_args = "deny"
 manual_midpoint = "deny"
+ip_constant = "deny"
+doc_broken_link = "deny"
 
 # Warm
 cast_possible_truncation = "deny"

consensus/rules/src/blocks.rs

@@ -53,7 +53,7 @@ pub trait RandomX {
 
 /// Returns if this height is a RandomX seed height.
 pub const fn is_randomx_seed_height(height: usize) -> bool {
-    height % RX_SEEDHASH_EPOCH_BLOCKS == 0
+    height.is_multiple_of(RX_SEEDHASH_EPOCH_BLOCKS)
 }
 
 /// Returns the RandomX seed height for this block.

storage/blockchain/src/ops/alt_block/block.rs

@@ -228,7 +228,6 @@ mod tests {
         types::AltBlockHeight,
     };
 
-    #[expect(clippy::range_plus_one)]
     #[test]
     fn all_alt_blocks() {
         let (env, _tmp) = tmp_concrete_env();

types/fixed-bytes/src/lib.rs

@@ -192,7 +192,7 @@ impl<const N: usize> TryFrom<Bytes> for ByteArrayVec<N> {
     type Error = FixedByteError;
 
     fn try_from(value: Bytes) -> Result<Self, Self::Error> {
-        if value.len() % N != 0 {
+        if !value.len().is_multiple_of(N) {
             return Err(FixedByteError::InvalidLength);
         }
 
@@ -222,7 +222,7 @@ impl<const N: usize> TryFrom<Vec<u8>> for ByteArrayVec<N> {
     type Error = FixedByteError;
 
     fn try_from(value: Vec<u8>) -> Result<Self, Self::Error> {
-        if value.len() % N != 0 {
+        if !value.len().is_multiple_of(N) {
             return Err(FixedByteError::InvalidLength);
         }