fix: update deprecated tools and improve shell script robustness

- Replace youtube-dl with yt-dlp (actively maintained fork)
- Replace python with ipconfig for localip alias (Python 2 removed from macOS)
- Rename 'now' export to 'kforce' to avoid shadowing date alias
- Remove deprecated PIP_DOWNLOAD_CACHE from .exports
- Replace systemsetup with pmset in osx_defaults.sh (deprecated in Monterey+)
- Replace launchctl unload with bootout syntax
- Comment out deprecated tmutil disablelocal commands
- Replace hub with gh (official GitHub CLI)
- Remove unmaintained legit package
- Update setup_fedora.sh: oh-my-zsh URL, powerlevel9k to powerlevel10k
- Add idempotent checks for git clone operations
- Fix $(whoami) in vscode settings.json (shell vars don't work in JSON)
- Quote variables in bootstrap.sh to handle paths with spaces
- Quote command substitution in .zshrc pack completion
- Use chmod +x instead of +rwx for binaries

Author: CuriousLearner

.aliases

@@ -1,5 +1,5 @@
-# Youtube downloader
-alias youtube-mp3='youtube-dl -x --audio-format mp3 --audio-quality 0'
+# Youtube downloader (yt-dlp is the maintained fork of youtube-dl)
+alias youtube-mp3='yt-dlp -x --audio-format mp3 --audio-quality 0'
 
 # eve - export vscode extensions
 alias eve="code --list-extensions |
@@ -53,7 +53,7 @@ alias whois="whois -h whois-servers.net"
 
 # IP addresses
 alias ip="curl ipinfo.io/ip"
-alias localip='python -c "import socket; print(socket.gethostbyname(socket.gethostname()));"'
+alias localip='ipconfig getifaddr en0 2>/dev/null || ipconfig getifaddr en1'
 
 # Copy my public key to my clipboard
 alias pubkey="more ~/.ssh/id_rsa.pub | pbcopy | echo '=> Public key copied to pasteboard.'"
@@ -134,7 +134,7 @@ alias kgpw='kubectl get pods -w'
 # CRITICAL: Export variables for exam speed
 # Usage: k run nginx --image=nginx $do > pod.yaml
 export do='--dry-run=client -o yaml'
-export now='--force --grace-period=0'
+export kforce='--force --grace-period=0'
 
 
 # ------------------------------------------------------------------------------

.exports

@@ -38,8 +38,6 @@ export LC_TIME="en_US.UTF-8"
 export LC_ALL=
 
 
-# Let pip install the dependencies from local cache
-export PIP_DOWNLOAD_CACHE=$HOME/Library/Caches/pip-downloads
 export PYTHONHASHSEED=random
 
 export PATH=~/bin:~/dotfiles/bin:$PATH

.zshrc

@@ -37,7 +37,7 @@ export PATH="/usr/local/opt/gettext/bin:$PATH"
 export PATH="$PATH:$HOME/.rvm/bin"
 
 # Enable buildpack `packs` completion for docker
-command -v pack >/dev/null && . $(pack completion --shell zsh)
+command -v pack >/dev/null && . "$(pack completion --shell zsh)"
 source ~/powerlevel10k/powerlevel10k.zsh-theme
 
 # To customize prompt, run `p10k configure` or edit ~/.p10k.zsh.

bootstrap.sh

@@ -44,15 +44,15 @@ function createSymlinks() {
     # shellcheck disable=SC2068
     for F in ${FILES[@]}; do
         # Delete files if --force was used
-        if [ $FORCE == true ]; then
+        if [ "$FORCE" == true ]; then
             TIME=$(date +%s)
             echoR "--> [BACKUP]: $HOME/${F}"
-            mv $HOME/$F $HOME/$F.$TIME.bak
+            mv "$HOME/$F" "$HOME/$F.$TIME.bak"
         fi
 
         # Make symlink
         echoY "--> [LINK]: ${HOME}/${F} -> ${CURRENTPATH}/${F}"
-        ln -s $CURRENTPATH/$F $HOME/$F
+        ln -s "$CURRENTPATH/$F" "$HOME/$F"
 
         if [ $? -eq 1 ]; then
             echo
@@ -72,11 +72,11 @@ createSymlinks
 ## Install custom binary utilities
 
 if [ ! -d "$HOME/.bin" ]; then
-  mkdir $HOME/.bin
+  mkdir "$HOME/.bin"
 fi
 
 # Symlink binaries
-ln -sf $PWD/bin/* $HOME/.bin/
+ln -sf "$PWD/bin/"* "$HOME/.bin/"
 
 declare -a BINARIES=(
     'batcharge.py'
@@ -99,7 +99,7 @@ declare -a BINARIES=(
 
 for i in "${BINARIES[@]}"; do
     echo "Changing access permissions for binary script :: ${i##*/}"
-    chmod +rwx $HOME/.bin/${i##*/}
+    chmod +x "$HOME/.bin/${i##*/}"
 done
 
 echo "Binaries installed"

setup/osx_defaults.sh

@@ -103,16 +103,18 @@ defaults write com.apple.helpviewer DevMode -bool true
 sudo defaults write /Library/Preferences/com.apple.loginwindow AdminHostInfo HostName
 
 # Restart automatically if the computer freezes
-sudo systemsetup -setrestartfreeze on
+# Note: systemsetup is deprecated in macOS Monterey+, using pmset instead
+sudo pmset -a autorestart 1
 
 # Never go into computer sleep mode
-sudo systemsetup -setcomputersleep Off > /dev/null
+sudo pmset -a sleep 0
 
 # Check for software updates daily, not just once per week
 defaults write com.apple.SoftwareUpdate ScheduleFrequency -int 1
 
 # Disable Notification Center and remove the menu bar icon
-launchctl unload -w /System/Library/LaunchAgents/com.apple.notificationcenterui.plist 2> /dev/null
+# Note: launchctl unload is deprecated, using bootout instead (may require SIP disabled)
+launchctl bootout gui/$(id -u) /System/Library/LaunchAgents/com.apple.notificationcenterui.plist 2> /dev/null || true
 
 # Disable smart quotes as they’re annoying when typing code
 defaults write NSGlobalDomain NSAutomaticQuoteSubstitutionEnabled -bool false
@@ -130,8 +132,8 @@ defaults write NSGlobalDomain NSAutomaticDashSubstitutionEnabled -bool false
 # SSD-specific tweaks                                                         #
 ###############################################################################
 
-# Disable local Time Machine snapshots
-sudo tmutil disablelocal
+# Disable local Time Machine snapshots (removed in macOS High Sierra+)
+# sudo tmutil disablelocal  # deprecated - local snapshots managed automatically now
 
 # Disable hibernation (speeds up entering sleep mode)
 sudo pmset -a hibernatemode 0
@@ -593,8 +595,8 @@ defaults write com.googlecode.iterm2 PromptOnQuit -bool false
 # Prevent Time Machine from prompting to use new hard drives as backup volume
 defaults write com.apple.TimeMachine DoNotOfferNewDisksForBackup -bool true
 
-# Disable local Time Machine backups
-hash tmutil &> /dev/null && sudo tmutil disablelocal
+# Disable local Time Machine backups (deprecated in High Sierra+)
+# hash tmutil &> /dev/null && sudo tmutil disablelocal
 
 ###############################################################################
 # Activity Monitor                                                            #
@@ -750,8 +752,8 @@ defaults write com.twitter.twitter-mac ShowFullNames -bool true
 # Hide the app in the background if it’s not the front-most window
 defaults write com.twitter.twitter-mac HideInBackground -bool true
 
-# disable local time machine backups http://classicyuppie.com/what-crap-is-this-os-xs-mobilebackups/
-tmutil disablelocal
+# disable local time machine backups (deprecated in High Sierra+)
+# tmutil disablelocal
 
 ###############################################################################
 # Kill affected applications                                                  #

setup/setup_fedora.sh

@@ -10,11 +10,9 @@ sudo dnf -y install zsh
 
 # Install everything else
 sudo dnf -y install ack
-sudo dnf -y install git git-extras hub
+sudo dnf -y install git git-extras gh
 sudo dnf -y install htop ngrep nmap
 sudo dnf -y install autojump # A smart command to change directory (https://github.com/wting/autojump)
-pip install legit            # http://www.git-legit.org/
-legit install		     # Enables the extra git commands
 sudo dnf -y install zopfli   # Data compression software (https://github.com/google/zopfli)
 sudo dnf -y install cowsay
 # pup not available for Linux (Fedora)
@@ -142,30 +140,29 @@ install_oh_my_zsh () {
     # Test to see if zshell is installed.  If it is:
     if [ -f /bin/zsh ] || [ -f /usr/bin/zsh ]; then
         # Install Oh My Zsh if it isn't already present
-        if [[ ! -d "$HOME/oh-my-zsh/" ]]; then
-            sh -c "$(curl -fsSL https://raw.githubusercontent.com/robbyrussell/oh-my-zsh/master/tools/install.sh)"
-        fi
-        # Set the default shell to zsh if it isn't currently set to zsh
-        if [[ ! $SHELL == $(command -v zsh) ]]; then
-            chsh -s "$(command -v zsh)"
+        if [[ ! -d "$HOME/.oh-my-zsh/" ]]; then
+            # Use RUNZSH=no to prevent oh-my-zsh from launching a new shell
+            # Use CHSH=no to skip changing shell (we'll do it at the end)
+            RUNZSH=no CHSH=no sh -c "$(curl -fsSL https://raw.githubusercontent.com/ohmyzsh/ohmyzsh/master/tools/install.sh)"
         fi
     else
         # If zsh isn't installed, get the platform of the current machine
         platform=$(uname);
         # If the platform is Linux, try an apt-get to install zsh and then recurse
         if [[ $platform == 'Linux' ]]; then
             if [[ -f /etc/redhat-release ]]; then
-                sudo yum install zsh
+                sudo yum install -y zsh
             fi
             if [[ -f /etc/debian_version ]]; then
-                sudo apt-get install zsh
+                sudo apt-get install -y zsh
             fi
-        # If the platform is OS X, tell the user to install zsh :)
+        # If the platform is OS X, install zsh via brew and continue
         elif [[ $platform == 'Darwin' ]]; then
-            echo "We'll install zsh, then re-run this script!"
+            echo "Installing zsh via Homebrew..."
             brew install zsh
-            exit
         fi
+        # Recurse to install oh-my-zsh now that zsh is installed
+        install_oh_my_zsh
     fi
 }
 
@@ -175,13 +172,28 @@ install_oh_my_zsh
 # Zsh                                                                         #
 ###############################################################################
 
-set -P
 # Install Zsh settings
 ln -sf "$PWD/zsh/themes/curiouslearner.zsh-theme" "$HOME/.oh-my-zsh/themes"
-# Zsh Syntax highlighting
-git clone https://github.com/zsh-users/zsh-syntax-highlighting.git "${ZSH_CUSTOM:-~/.oh-my-zsh/custom}/plugins/zsh-syntax-highlighting"
 
-# Install Powerlevel9k theme
-git clone https://github.com/bhilburn/powerlevel9k.git ~/.oh-my-zsh/custom/themes/powerlevel9k
+# Zsh Syntax highlighting
+ZSH_CUSTOM="${ZSH_CUSTOM:-$HOME/.oh-my-zsh/custom}"
+if [[ ! -d "$ZSH_CUSTOM/plugins/zsh-syntax-highlighting" ]]; then
+    git clone https://github.com/zsh-users/zsh-syntax-highlighting.git "$ZSH_CUSTOM/plugins/zsh-syntax-highlighting"
+fi
+
+# Install PowerLevel10k theme (powerlevel9k is unmaintained)
+if [[ ! -d "$HOME/powerlevel10k" ]]; then
+    git clone --depth=1 https://github.com/romkatv/powerlevel10k.git "$HOME/powerlevel10k"
+fi
+
+# Change default shell to zsh at the very end
+if [[ ! "$SHELL" == $(command -v zsh) ]]; then
+    echo "Changing default shell to zsh..."
+    chsh -s "$(command -v zsh)"
+fi
+
+echo ""
+echo "Setup complete! Restart your terminal to use zsh."
+echo ""
 
 exit 0

setup/setup_mac.sh

@@ -61,10 +61,9 @@ installcask sublime-text
 installcask visual-studio-code
 brew install openssl
 brew install ack
-brew install git git-extras hub git-ftp git-crypt
+brew install git git-extras gh git-ftp git-crypt
 brew install rename htop tree ngrep mtr nmap
 brew install autojump
-brew install legit      # http://www.git-legit.org/
 # brew install Zopfli     # https://code.google.com/p/zopfli/
 brew install fortune cowsay
 brew tap heroku/brew && brew install heroku

setup/vscode/settings.json

@@ -90,7 +90,8 @@
     "notebook.includeCellOutputs": true,
     "continue.enableTabAutocomplete": true,
     "continue.telemetryEnabled": false,
-    "dart.flutterSdkPath": "/Users/$(whoami)/Downloads/flutter",
+    // Note: Update this path to your actual flutter SDK location
+    "dart.flutterSdkPath": "~/Downloads/flutter",
     "workbench.sideBar.location": "right",
     "[json]": {
         "editor.defaultFormatter": "vscode.json-language-features"