Adds next_day_conversion_date to reference->conversionDates response (#112)

Author: jonathancouchman

src/EntryPoint/ReferenceEntryPoint.php

@@ -91,7 +91,8 @@ public function conversionDates($conversionPair, DateTime $startDate = null)
             new DateTime($response->first_conversion_date),
             new DateTime($response->default_conversion_date),
             new DateTime($response->first_conversion_cutoff_datetime),
-            new DateTime($response->optimize_liquidity_conversion_date)
+            new DateTime($response->optimize_liquidity_conversion_date),
+            new DateTime($response->next_day_conversion_date)
         );
     }
 

src/Model/ConversionDates.php

@@ -27,26 +27,33 @@ class ConversionDates
      * @var DateTime
      */
     private $optimizeLiquidityConversionDate;
+    /**
+     * @var DateTime
+     */
+    private $nextDayConversionDate;
 
     /**
      * @param InvalidConversionDate[] $invalidConversionDates
      * @param DateTime $firstConversionDay
      * @param DateTime $defaultConversionDay
      * @param DateTime $firstConversionCutoffDatetime
      * @param DateTime $optimizeLiquidityConversionDate
+     * @param DateTime $nextDayConversionDate
      */
     public function __construct(
         array $invalidConversionDates,
         DateTime $firstConversionDay,
         DateTime $defaultConversionDay,
         DateTime $firstConversionCutoffDatetime,
-        DateTime $optimizeLiquidityConversionDate
+        DateTime $optimizeLiquidityConversionDate,
+        DateTime $nextDayConversionDate
     ) {
         $this->invalidConversionDates = $invalidConversionDates;
         $this->firstConversionDay = $firstConversionDay;
         $this->defaultConversionDay = $defaultConversionDay;
         $this->firstConversionCutoffDatetime = $firstConversionCutoffDatetime;
         $this->optimizeLiquidityConversionDate = $optimizeLiquidityConversionDate;
+        $this->nextDayConversionDate = $nextDayConversionDate;
     }
 
     /**
@@ -89,5 +96,13 @@ public function getOptimizeLiquidityConversionDate()
         return $this->optimizeLiquidityConversionDate;
     }
 
+    /**
+     * @return DateTime
+     */
+    public function getNextDayConversionDate()
+    {
+        return $this->nextDayConversionDate;
+    }
+
 
 }

tests/VCR/Reference/Test.php

@@ -39,6 +39,7 @@ public function canRetrieveConversionDates()
             "{
                   \"first_conversion_cutoff_datetime\": \"2020-11-10T15:30:00+00:00\",
                   \"first_conversion_date\": \"2020-11-10\",
+                  \"next_day_conversion_date\": \"2020-11-11\",
                   \"default_conversion_date\": \"2020-11-12\",
                   \"optimize_liquidity_conversion_date\": \"2020-11-12\",
                   \"invalid_conversion_dates\": {
@@ -292,6 +293,7 @@ public function canRetrieveConversionDates()
         $this->assertEquals($dummy['default_conversion_date'], $conversionDates->getDefaultConversionDate()->format('Y-m-d'));
         $this->assertEquals($dummy['first_conversion_cutoff_datetime'], $conversionDates->getFirstConversionCutoffDatetime()->format(DateTime::RFC3339));
         $this->assertEquals($dummy['optimize_liquidity_conversion_date'], $conversionDates->getOptimizeLiquidityConversionDate()->format('Y-m-d'));
+        $this->assertEquals($dummy['next_day_conversion_date'], $conversionDates->getNextDayConversionDate()->format('Y-m-d'));
         $invalidConversionDates = $conversionDates->getInvalidConversionDates();
         $this->assertEquals(count($dummy['invalid_conversion_dates']), count($invalidConversionDates));
         $i = 0;

tests/fixtures/Reference/can_retrieve_conversion_dates.yaml

@@ -15,6 +15,7 @@
                   "first_conversion_cutoff_datetime": "2020-11-10T15:30:00+00:00",
                   "first_conversion_date": "2020-11-10",
                   "default_conversion_date": "2020-11-12",
+                  "next_day_conversion_date": "2020-11-11",
                   "optimize_liquidity_conversion_date": "2020-11-12",
                   "invalid_conversion_dates": {
                     "2020-11-11": "Veterans'' Day",