Merge pull request #22 from calvernaz/fix-set-include-external-ids

Fix set include external ids

Author: sriprasanna

src/main/java/com/currencyfair/onesignal/OneSignal.java

@@ -50,6 +50,13 @@
  */
 public final class OneSignal {
 
+    private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
+    static {
+        OBJECT_MAPPER.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+        OBJECT_MAPPER.configure(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY, true);
+        OBJECT_MAPPER.setSerializationInclusion(Include.NON_EMPTY);
+    }
+
     private OneSignal() {
     }
 
@@ -313,13 +320,9 @@ public static void csvExportFileDownload(URL url, File location) throws IOExcept
     }
 
     private static OneSignalComms oneSignal() {
-        ObjectMapper objectMapper = new ObjectMapper();
-        objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
-        objectMapper.configure(DeserializationFeature.ACCEPT_SINGLE_VALUE_AS_ARRAY, true);
-        objectMapper.setSerializationInclusion(Include.NON_EMPTY);
-        JacksonDecoder decoder = new JacksonDecoder(objectMapper);
+        JacksonDecoder decoder = new JacksonDecoder(OBJECT_MAPPER);
         return Feign.builder()
-                .encoder(new JacksonEncoder(objectMapper))
+                .encoder(new JacksonEncoder(OBJECT_MAPPER))
                 .decoder(decoder)
                 .decode404()
                 .errorDecoder(new OneSignalErrorDecoder(decoder))

src/main/java/com/currencyfair/onesignal/model/notification/Notification.java

@@ -738,7 +738,7 @@ public List<String> getIncludeExternalUserIds() {
     }
 
     public void setIncludeExternalUserIds(List<String> externalUserIds) {
-        this.includeExternalUserIds = includeExternalUserIds;
+        this.includeExternalUserIds = externalUserIds;
     }
 
     public String getAppId() {