fix: Add error message check for CF API errors

itssimple · web-flow · commit 9591b159a76e · 2025-12-10T10:35:33.000+01:00
If there isn't an error message, then they don't want to say what's wrong, so we better not report about it either.
diff --git a/CFLookup/Jobs/StoreCFApiProjects.cs b/CFLookup/Jobs/StoreCFApiProjects.cs
@@ -51,7 +51,7 @@ public async static Task RunAsync(PerformContext context, IJobCancellationToken
                         
                         token.ThrowIfCancellationRequested();
 
-                        if (modList.Error != null && modList.Error.ErrorCode != 404)
+                        if (modList.Error != null && modList.Error.ErrorCode != 404 && !string.IsNullOrWhiteSpace(modList.Error.ErrorMessage))
                         {
                             // No-op for now, maybe Discord logs later
                             await SendDiscordErrorNotification(scope, $"The CF API threw an error at me: **{modList.Error.ErrorCode}**: {modList.Error.ErrorMessage}");
@@ -330,4 +330,4 @@ private async static Task<bool> ExecuteBatchWithRetries(NpgsqlBatch batch, int r
             return false;
         }
     }
-}
+}

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ public async static Task RunAsync(PerformContext context, IJobCancellationToken`
`51`	`51`
`52`	`52`	`token.ThrowIfCancellationRequested();`
`53`	`53`
`54`		`- if (modList.Error != null && modList.Error.ErrorCode != 404)`
	`54`	`+ if (modList.Error != null && modList.Error.ErrorCode != 404 && !string.IsNullOrWhiteSpace(modList.Error.ErrorMessage))`
`55`	`55`	`{`
`56`	`56`	`// No-op for now, maybe Discord logs later`
`57`	`57`	`await SendDiscordErrorNotification(scope, $"The CF API threw an error at me: {modList.Error.ErrorCode}: {modList.Error.ErrorMessage}");`
`@@ -330,4 +330,4 @@ private async static Task<bool> ExecuteBatchWithRetries(NpgsqlBatch batch, int r`
`330`	`330`	`return false;`
`331`	`331`	`}`
`332`	`332`	`}`
`333`		`-}`
	`333`	`+}`