fix: properly handle large string integer casting

Author: romm

src/Type/Types/IntegerRangeType.php

@@ -19,7 +19,6 @@
 use function is_int;
 use function is_string;
 use function ltrim;
-use function preg_match;
 use function sprintf;
 
 /** @internal */
@@ -97,10 +96,8 @@ public function inferGenericsFrom(Type $other, Generics $generics): Generics
 
     public function canCast(mixed $value): bool
     {
-        if (is_string($value)) {
-            $value = preg_match('/^0+$/', $value)
-                ? '0'
-                : ltrim($value, '0');
+        if (is_string($value) && $value !== '') {
+            $value = ltrim($value, '0') ?: '0';
         }
 
         return ! is_bool($value)

src/Type/Types/IntegerValueType.php

@@ -17,7 +17,6 @@
 use function is_bool;
 use function is_string;
 use function ltrim;
-use function preg_match;
 
 /** @internal */
 final class IntegerValueType implements IntegerType, FixedType
@@ -46,10 +45,8 @@ public function inferGenericsFrom(Type $other, Generics $generics): Generics
 
     public function canCast(mixed $value): bool
     {
-        if (is_string($value)) {
-            $value = preg_match('/^0+$/', $value)
-                ? '0'
-                : ltrim($value, '0');
+        if (is_string($value) && $value !== '') {
+            $value = ltrim($value, '0') ?: '0';
         }
 
         return ! is_bool($value)

src/Type/Types/NativeIntegerType.php

@@ -56,8 +56,8 @@ public function inferGenericsFrom(Type $other, Generics $generics): Generics
 
     public function canCast(mixed $value): bool
     {
-        if (is_string($value)) {
-            $value = ltrim($value, '0') . '0';
+        if (is_string($value) && $value !== '') {
+            $value = ltrim($value, '0') ?: '0';
         }
 
         return ! is_bool($value) && filter_var($value, FILTER_VALIDATE_INT) !== false;

src/Type/Types/NonNegativeIntegerType.php

@@ -57,8 +57,8 @@ public function inferGenericsFrom(Type $other, Generics $generics): Generics
 
     public function canCast(mixed $value): bool
     {
-        if (is_string($value)) {
-            $value = ltrim($value, '0') . '0';
+        if (is_string($value) && $value !== '') {
+            $value = ltrim($value, '0') ?: '0';
         }
 
         return ! is_bool($value)

src/Type/Types/PositiveIntegerType.php

@@ -57,8 +57,8 @@ public function inferGenericsFrom(Type $other, Generics $generics): Generics
 
     public function canCast(mixed $value): bool
     {
-        if (is_string($value)) {
-            $value = ltrim($value, '0');
+        if (is_string($value) && $value !== '') {
+            $value = ltrim($value, '0') ?: '0';
         }
 
         return ! is_bool($value)

tests/Integration/Mapping/Other/ScalarValueCastingMappingTest.php

@@ -9,6 +9,7 @@
 use CuyZ\Valinor\Tests\Fixture\Enum\BackedStringEnum;
 use CuyZ\Valinor\Tests\Fixture\Object\StringableObject;
 use CuyZ\Valinor\Tests\Integration\IntegrationTestCase;
+use PHPUnit\Framework\Attributes\DataProvider;
 use PHPUnit\Framework\Attributes\TestWith;
 
 final class ScalarValueCastingMappingTest extends IntegrationTestCase
@@ -50,4 +51,53 @@ public function test_scalar_values_are_casted_properly(string $type, mixed $valu
             $this->mappingFail($error);
         }
     }
+
+    #[DataProvider('integer_values_are_casted_properly_data_provider')]
+    public function test_integer_values_are_casted_properly(string $type, mixed $value, mixed $expected): void
+    {
+        try {
+            $result = $this
+                ->mapperBuilder()
+                ->allowScalarValueCasting()
+                ->mapper()
+                ->map($type, $value);
+
+            self::assertSame($expected, $result);
+        } catch (MappingError $error) {
+            $this->mappingFail($error);
+        }
+    }
+
+    public static function integer_values_are_casted_properly_data_provider(): iterable
+    {
+        yield 'int with very large integer from string' => [
+            'type' => 'int',
+            'value' => (string)(PHP_INT_MAX - 1),
+            'expected' => PHP_INT_MAX - 1,
+        ];
+
+        yield 'non negative int with very large integer from string' => [
+            'type' => 'non-negative-int',
+            'value' => (string)(PHP_INT_MAX - 1),
+            'expected' => PHP_INT_MAX - 1,
+        ];
+
+        yield 'positive int with very large integer from string' => [
+            'type' => 'positive-int',
+            'value' => (string)(PHP_INT_MAX - 1),
+            'expected' => PHP_INT_MAX - 1,
+        ];
+
+        yield 'integer range with very large integer from string' => [
+            'type' => 'int<0, max>',
+            'value' => (string)(PHP_INT_MAX - 1),
+            'expected' => PHP_INT_MAX - 1,
+        ];
+
+        yield 'integer value with very large integer from string' => [
+            'type' => (string)(PHP_INT_MAX - 1),
+            'value' => (string)(PHP_INT_MAX - 1),
+            'expected' => PHP_INT_MAX - 1,
+        ];
+    }
 }