Valinor 1.15 has 2x worse perf than 1.14

[simPod]

I'm using Valinor with sf bundle. The file cache is used and warmed up before the application run.

With 1.15 the warmup is much slower than in 1.14 which is kinda understandable considering the cache changes in 1.15.

However, the mapper performance seems to be x2 in the latest version (the cache is used).

I looked at the changes done and would say that it should be actually faster though it seems to not be true.

Does anyone see the same perf degradation? Did anyone measure?

I'm now in the process of profiling the thing

---

1.14	1.15

https://blackfire.io/profiles/compare/b020db94-674f-4dee-a2df-c59b93425422/graph

[romm]

Hi @simPod, that's definitely not wanted. Thanks for the trace this will help a lot. I'll take a look in the upcoming days when I get some free time 😊

[romm]

Also, would you mind sharing (parts of?) the type on which the mapping is done?

[simPod]

#[WarmupForMapper]
abstract class Dto
{
    public function __construct(
        public int|null $rank = null,
    ) {
    }
}


final class Foo extends Dto implements Iii
{
    public OperatingSystem|null $os = null;

    /** @throws DecodeException */
    public function __construct(
        public bool|null $featureAEnabled = null,
        public int|null $identifierA = null,
        public bool|null $featureBEnabled = null,
        public string|null $note = null,
        public string|null $vendor = null,
        public UniqueId|null $entityId = null,
        public string|null $url = null,
        public IpAddress|null $ipPrimary = null,
        public string|null $label = null,
        public string|null $code = null,
        public int|null $port = null,
        public Status|null $status = null,
        public string|null $typeName = null,
        public string|null $metricInOid = null,
        public string|null $metricOutOid = null,
        string|null $os = null,
        public UniqueId|null $ownerKey = null,
        public bool|null $monitoringEnabled = null,
        public UniqueId|null $locationId = null,
        public int|null $unitSize = null,
        public string|null $configurations = null,
        public IpAddress|null $ipSecondary = null,
        public string|null $accessKey = null,
        public float|null $duration = null,
        public DateTimeImmutable|null $endDate = null,
        public Type|null $entityType = null,
        public UniqueId|null $relatedId = null,
        int|null $priority = null,
    ) {
        $this->os = self::parseOs($os);

        parent::__construct($priority);
    }
}

final class Bar extends Dto implements Iii
{
    public StatusLevel|null $statusLevel = null;

    public TopologyShape|null $topologyShape = null;

    /** @var list<int>|null */
    public array|null $allowedGroupIds = null;
    public string|null $allowedGroupRange = null;

    public function __construct(
        public int|null $primaryGroup = null,
        public string|null $controlMode = null,
        public int|null $controlState = null,
        public bool|null $autoLinkDetection = null,
        public UniqueId|null $linkRefId = null,
        public UniqueId|null $agreementRefId = null,
        public DataRate|null $throughput = null,
        public string|null $metadata = null,
        public UniqueId|null $parentEntityId = null,
        public UniqueId|null $compositeId = null,
        public UniqueId|null $interfaceId = null,
        public int|null $positionIndex = null,
        public bool|null $isComposite = null,
        public UniqueId|null $adjacentInterfaceId = null,
        public AdjacencyState|null $adjacencyState = null,
        public UniqueId|null $scheduledMaintenanceId = null,
        public string|null $label = null,
        public int|null $fallbackGroup = null,
        int|null $statusLevel = null,
        public UniqueId|null $clientRefId = null,
        public UniqueId|null $deploymentId = null,
        public int|null $bandwidthHint = null,
        public InterfaceMode|null $modeProfile = null,
        int|null $topologyShape = null,
        string|null $groupIds = null,
        public InterfaceKind|null $interfaceKind = null,
        public UniqueId|null $externalNoticeRefId = null,
        int|null $priorityScore = null,
    ) {
        $this->statusLevel = StatusLevel::tryFrom($statusLevel ?? -1);
        $this->allowedGroupIds = ArrayIntType::convertToPhpArray($groupIds);
        $this->allowedGroupRange = VlanNumberRangeManipulator::toString(new Set($this->allowedGroupIds ?? []));
        $this->topologyShape = TopologyShape::tryFrom($topologyShape ?? -1);

        parent::__construct($priorityScore);
    }
}

I'd say it mapped like 500-600 Foos and ~1000 Bars