- increase code coverage. more tests

- fix parser bug

Author: CyberLine

src/SystemdState/Parser.php

@@ -130,7 +130,7 @@ private static function parseExecLine(string $line): ExecCommand
 
         $explode = array_map('trim', explode(';', $matches['command']));
         array_walk($explode, function (string $value, int $key, ExecCommand $execCommand) {
-            $split = explode(' ', $value);
+            $split = explode('=', $value);
             $array = self::parseExecDetail($split);
             if (count($array)) {
                 $execCommand->{$array[0]} = $array[1];
@@ -153,10 +153,10 @@ private static function parseExecDetail(array $values): array
         }
 
         if ($index === 'argv[]') {
-            array_shift($values);
-            array_shift($values);
+            $explode = explode(' ', $values[1]);
+            array_shift($explode);
 
-            return ['argv', implode(' ', $values),];
+            return ['argv', implode(' ', $explode),];
         }
 
         if ($index === 'start_time') {

src/SystemdState/SystemdState.php

@@ -138,7 +138,7 @@ private function handleServiceResponse(string $service): void
      */
     private function handleLine(string $line, int $key, TypesInterface $type): void
     {
-        $explode = explode('=', $line);
+        $explode = explode('=', $line, 2);
         $propertyName = $explode[0];
 
         if (empty($propertyName)) {

tests/ParserTest.php

@@ -14,6 +14,16 @@ public function dpParseValueByContent()
         $dateTime = \date_create_immutable_from_format('* Y-m-d H:i:s e', time());
         $execCommand = new ExecCommand;
 
+        $execCommand2 = new ExecCommand;
+        $execCommand2->path = '/usr/sbin/nginx';
+        $execCommand2->argv = '-c /etc/nginx/nginx.conf';
+        $execCommand2->ignoreErrors = false;
+        $execCommand2->startTime = '[n/a]';
+        $execCommand2->stopTime = '[n/a]';
+        $execCommand2->pid = 0;
+        $execCommand2->code = '(null)';
+        $execCommand2->status = '0/0';
+
         $testCases = [
             [['test'], null],
             [['test', 'yes'], true],
@@ -25,7 +35,8 @@ public function dpParseValueByContent()
             [['test', '18446744073709551615'], '18446744073709551615'],
             [['Timestamp', (string)$dateTime], $dateTime],
             [['Environment', 'FOO=bar BAZ=foo'], ['FOO' => 'bar', 'BAZ' => 'foo']],
-            [['ExecStart', ''], $execCommand]
+            [['ExecStart', ''], $execCommand],
+            [['ExecStart', '{ path=/usr/sbin/nginx ; argv[]=/usr/sbin/nginx -c /etc/nginx/nginx.conf ; ignore_errors=no ; start_time=[n/a] ; stop_time=[n/a] ; pid=0 ; code=(null) ; status=0/0 }'], $execCommand2],
         ];
 
         // To cover codecoverage