Fixes for security findings

Author: gnongsie

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/core/Authorize.cs

@@ -112,17 +112,24 @@ public JwtToken GetToken()
 
         private void LogMerchantDetails()
         {
-            // Using Request Target provided in the sample code/merchantconfig
-            _logger.Trace("Using Request Target:'{0}'", _merchantConfig.RequestTarget);
+            try
+            {
+                // Using Request Target provided in the sample code/merchantconfig
+                _logger.Trace("Using Request Target:'{0}'", _merchantConfig.RequestTarget);
 
-            // logging Authentication type
-            _logger.Trace("Authentication Type -> {0}", _merchantConfig.AuthenticationType);
+                // logging Authentication type
+                _logger.Trace("Authentication Type -> {0}", _merchantConfig.AuthenticationType);
 
-            // logging Request Type
-            _logger.Trace("Request Type -> {0}", _merchantConfig.RequestType);
+                // logging Request Type
+                _logger.Trace("Request Type -> {0}", _merchantConfig.RequestType);
 
-            // Logging all the Properties of MerchantConfig and their respective Values
-            _logger.Trace("MERCHCFG > {0}", MerchantConfig.LogAllproperties(_merchantConfig));
+                // Logging all the Properties of MerchantConfig and their respective Values
+                _logger.Trace("MERCHCFG > {0}", MerchantConfig.LogAllproperties(_merchantConfig));
+            }
+            catch (Exception e)
+            {
+                ExceptionUtility.Exception(e.Message, e.StackTrace);
+            }
         }
     }
 }

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/core/MerchantConfig.cs

@@ -48,12 +48,19 @@ If a dictionary object has been passed use that object
 
             LogUtility.InitLogConfig(EnableLog, LogDirectory, LogFileName, LogfileMaxSize);
 
-            // Logger object is ready to Log
-            Logger.Trace("\n");
-            Logger.Trace("START> =======================================");
+            try
+            {
+                // Logger object is ready to Log
+                Logger.Trace("\n");
+                Logger.Trace("START> =======================================");
 
-            // Logging the source of properties' values
-            Logger.Trace("Reading Merchant Configuration from " + _propertiesSetUsing);
+                // Logging the source of properties' values
+                Logger.Trace("Reading Merchant Configuration from " + _propertiesSetUsing);
+            }
+            catch (Exception e)
+            {
+                ExceptionUtility.Exception(e.Message, e.StackTrace);
+            }
 
             // Validations
             ValidateProperties();
@@ -366,31 +373,31 @@ private void ValidateProperties()
                 if (string.IsNullOrEmpty(KeyAlias))
                 {
                     KeyAlias = MerchantId;
-                    Logger.Warn($"{Constants.WarningPrefix} KeyAlias not provided. Assigning the value of: [MerchantID]");
+                    throw new Exception($"{Constants.WarningPrefix} KeyAlias not provided. Assigning the value of: [MerchantID]");
                 }
 
                 if (!string.Equals(KeyAlias, MerchantId))
                 {
                     KeyAlias = MerchantId;
-                    Logger.Warn($"{Constants.WarningPrefix} Incorrect value of KeyAlias provided. Assigning the value of: [MerchantID]");
+                    throw new Exception($"{Constants.WarningPrefix} Incorrect value of KeyAlias provided. Assigning the value of: [MerchantID]");
                 }
 
                 if (string.IsNullOrEmpty(KeyPass))
                 {
                     KeyPass = MerchantId;
-                    Logger.Warn($"{Constants.WarningPrefix} KeyPassword not provided. Assigning the value of: [MerchantID]");
+                    throw new Exception($"{Constants.WarningPrefix} KeyPassword not provided. Assigning the value of: [MerchantID]");
                 }
 
                 if (string.IsNullOrEmpty(KeyDirectory))
                 {
                     KeyDirectory = Constants.P12FileDirectory;
-                    Logger.Warn($"{Constants.WarningPrefix} KeysDirectory not provided. Using Default Path: {KeyDirectory}");
+                    throw new Exception($"{Constants.WarningPrefix} KeysDirectory not provided. Using Default Path: {KeyDirectory}");
                 }
 
                 if (string.IsNullOrEmpty(KeyfileName))
                 {
                     KeyfileName = MerchantId;
-                    Logger.Warn($"{Constants.WarningPrefix} KeyfileName not provided. Assigning the value of: [MerchantId]");
+                    throw new Exception($"{Constants.WarningPrefix} KeyfileName not provided. Assigning the value of: [MerchantId]");
                 }
 
                 P12Keyfilepath = KeyDirectory + "\\" + KeyfileName + ".p12";