Modified functionality of RestClient to make optimal use of connection pooling

Author: gnongsie

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/core/Authorize.cs

@@ -16,13 +16,13 @@ public class Authorize
         private readonly MerchantConfig _merchantConfig;
         LogUtility logUtility;
 
-
         public Authorize(MerchantConfig merchantConfig)
         {
             _merchantConfig = merchantConfig;
             Enumerations.ValidateRequestType(_merchantConfig.RequestType);
             Enumerations.SetRequestType(_merchantConfig);
             logUtility = new LogUtility();
+
             if (_logger == null)
             {
                 _logger = LogManager.GetCurrentClassLogger();
@@ -65,10 +65,10 @@ public HttpToken GetSignature()
 
                     if (_merchantConfig.IsPostRequest || _merchantConfig.IsPutRequest || _merchantConfig.IsPatchRequest)
                     {
-                        logUtility.LogDebugMessage( _logger, $"digest: {signatureObj.Digest}");
+                        logUtility.LogDebugMessage(_logger, $"digest: {signatureObj.Digest}");
                     }
 
-                    logUtility.LogDebugMessage( _logger, $"Signature : {signatureObj.SignatureParam}");
+                    logUtility.LogDebugMessage(_logger, $"Signature : {signatureObj.SignatureParam}");
 
                     return signatureObj;
                 }

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/core/MerchantConfig.cs

@@ -18,7 +18,7 @@ namespace AuthenticationSdk.core
     *============================================================================================*/
     public class MerchantConfig
     {
-        public MerchantConfig(IReadOnlyDictionary<string, string> merchantConfigDictionary = null, Dictionary<string, bool> mapToControlMLEonAPI = null)
+        public MerchantConfig(IReadOnlyDictionary<string, string> merchantConfigDictionary = null, Dictionary<string,bool> mapToControlMLEonAPI=null)
         {
             var _propertiesSetUsing = string.Empty;
 
@@ -170,6 +170,10 @@ public MerchantConfig(IReadOnlyDictionary<string, string> merchantConfigDictiona
 
         public string MleKeyAlias { get; set; }
 
+        public string MaxConnectionPoolSize { get; set; }
+
+        public string KeepAliveTime { get; set; }
+
         #endregion
 
         public void LogMerchantConfigurationProperties()
@@ -252,9 +256,27 @@ private void SetValuesFromAppConfig(NameValueCollection merchantConfigSection, D
             {
                 MleKeyAlias = Constants.DefaultMleAliasForCert;
             }
+
+            if (merchantConfigSection["maxConnectionPoolSize"] != null)
+            {
+                MaxConnectionPoolSize = merchantConfigSection["maxConnectionPoolSize"];
+            }
+            else
+            {
+                MaxConnectionPoolSize = Constants.DefaultMaxConnectionPoolSize;
+            }
+
+            if (merchantConfigSection["keepAliveTime"] != null)
+            {
+                KeepAliveTime = merchantConfigSection["keepAliveTime"];
+            }
+            else
+            {
+                KeepAliveTime = Constants.DefaultKeepAliveTime;
+            }
         }
 
-        private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantConfigDictionary, Dictionary<string, bool> mapToControlMLEonAPI)
+        private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantConfigDictionary, Dictionary<string,bool> mapToControlMLEonAPI)
         {
             var key = string.Empty;
 
@@ -278,6 +300,7 @@ private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantC
                             UseMetaKey = "false";
                         }
                     }
+
                     key = "intermediateHost";
                     if (merchantConfigDictionary.ContainsKey(key))
                     {
@@ -464,7 +487,7 @@ private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantC
                         PemFileDirectory = merchantConfigDictionary["pemFileDirectory"];
                     }
 
-                    if (merchantConfigDictionary.ContainsKey("useMLEGlobally") && "true".Equals(merchantConfigDictionary["useMLEGlobally"], StringComparison.OrdinalIgnoreCase))
+                    if (merchantConfigDictionary.ContainsKey("useMLEGlobally") && "true".Equals(merchantConfigDictionary["useMLEGlobally"],StringComparison.OrdinalIgnoreCase))
                     {
                         UseMLEGlobally = bool.Parse(merchantConfigDictionary["useMLEGlobally"]);
                     }
@@ -488,6 +511,24 @@ private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantC
                     {
                         MleKeyAlias = Constants.DefaultMleAliasForCert;
                     }
+
+                    if (merchantConfigDictionary.ContainsKey("maxConnectionPoolSize"))
+                    {
+                        MaxConnectionPoolSize = merchantConfigDictionary["maxConnectionPoolSize"];
+                    }
+                    else
+                    {
+                        MaxConnectionPoolSize = Constants.DefaultMaxConnectionPoolSize;
+                    }
+
+                    if (merchantConfigDictionary.ContainsKey("keepAliveTime"))
+                    {
+                        KeepAliveTime = merchantConfigDictionary["keepAliveTime"];
+                    }
+                    else
+                    {
+                        KeepAliveTime = Constants.DefaultKeepAliveTime;
+                    }
                 }
             }
             catch (KeyNotFoundException err)

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/util/Cache.cs

@@ -47,6 +47,7 @@ public static X509Certificate2Collection FetchCachedCertificate(string p12FilePa
                         var cachedFilePath = Path.GetFullPath(p12FilePath);
                         filePaths.Add(cachedFilePath);
                         policy.ChangeMonitors.Add(new HostFileChangeMonitor(filePaths));
+
                         var certificates = new X509Certificate2Collection();
                         certificates.Import(p12FilePath, keyPassword, X509KeyStorageFlags.PersistKeySet);
 

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/util/Constants.cs

@@ -41,5 +41,10 @@ public static class Constants
         public static readonly string LOG_REQUEST_BEFORE_MLE = "LOG_REQUEST_BEFORE_MLE: ";
 
         public static readonly string LOG_REQUEST_AFTER_MLE = "LOG_REQUEST_AFTER_MLE: ";
+
+        public static readonly string DefaultMaxConnectionPoolSize = $"{int.MaxValue}";
+
+        // https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient.timeout?view=net-9.0
+        public static readonly string DefaultKeepAliveTime = "300000"; // Time in milliseconds
     }
 }

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/util/LogUtility.cs

@@ -85,7 +85,7 @@ public string MaskSensitiveData(string str)
                 catch (Exception e)
                 {
                     throw e;
-                } 
+                }
             }
 
             return str;