Merge pull request #123 from CyberSource/restclient-rewrite

Rewrite of RestClient usage

Author: gaubansa

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/core/MerchantConfig.cs

@@ -179,6 +179,10 @@ public bool UseMLEGlobally
 
         public string MleKeyAlias { get; set; }
 
+        public string MaxConnectionPoolSize { get; set; }
+
+        public string KeepAliveTime { get; set; }
+
         public string MleForRequestPublicCertPath { get; set; }
 
         #endregion
@@ -294,6 +298,24 @@ private void SetValuesFromAppConfig(NameValueCollection merchantConfigSection, D
             {
                 MleKeyAlias = Constants.DefaultMleAliasForCert;
             }
+
+            if (merchantConfigSection["maxConnectionPoolSize"] != null)
+            {
+                MaxConnectionPoolSize = merchantConfigSection["maxConnectionPoolSize"];
+            }
+            else
+            {
+                MaxConnectionPoolSize = Constants.DefaultMaxConnectionPoolSize;
+            }
+
+            if (merchantConfigSection["keepAliveTime"] != null)
+            {
+                KeepAliveTime = merchantConfigSection["keepAliveTime"];
+            }
+            else
+            {
+                KeepAliveTime = Constants.DefaultKeepAliveTime;
+            }
         }
 
         private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantConfigDictionary, Dictionary<string,bool> mapToControlMLEonAPI)
@@ -558,6 +580,24 @@ private void SetValuesUsingDictObj(IReadOnlyDictionary<string, string> merchantC
                         MleKeyAlias = Constants.DefaultMleAliasForCert;
                     }
 
+                    if (merchantConfigDictionary.ContainsKey("maxConnectionPoolSize"))
+                    {
+                        MaxConnectionPoolSize = merchantConfigDictionary["maxConnectionPoolSize"];
+                    }
+                    else
+                    {
+                        MaxConnectionPoolSize = Constants.DefaultMaxConnectionPoolSize;
+                    }
+
+                    if (merchantConfigDictionary.ContainsKey("keepAliveTime"))
+                    {
+                        KeepAliveTime = merchantConfigDictionary["keepAliveTime"];
+                    }
+                    else
+                    {
+                        KeepAliveTime = Constants.DefaultKeepAliveTime;
+                    }
+
                     if (merchantConfigDictionary.ContainsKey("mleForRequestPublicCertPath") && !string.IsNullOrEmpty(merchantConfigDictionary["mleForRequestPublicCertPath"].Trim()))
                     {
                         MleForRequestPublicCertPath = merchantConfigDictionary["mleForRequestPublicCertPath"].Trim();
@@ -587,7 +627,7 @@ private void ValidateProperties()
 
             if (string.IsNullOrEmpty(TimeOut))
             {
-                TimeOut = string.Empty;   // In Millisec
+                TimeOut = Constants.DEFAULT_TIME_OUT;   // In Millisec
             }
 
             // setting up hostname based on the run environment value

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/util/Constants.cs

@@ -42,6 +42,12 @@ public static class Constants
 
         public static readonly string LOG_REQUEST_AFTER_MLE = "LOG_REQUEST_AFTER_MLE: ";
 
+        public static readonly string DEFAULT_TIME_OUT = "100000"; // Time in milliseconds
+
+        public static readonly string DefaultMaxConnectionPoolSize = $"{int.MaxValue}";
+
+        // https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclient.timeout?view=net-9.0
+        public static readonly string DefaultKeepAliveTime = "300000"; // Time in milliseconds
         public static readonly string MLE_CACHE_IDENTIFIER_FOR_CONFIG_CERT = "mleCertFromMerchantConfig";
 
         public static readonly string MLE_CACHE_IDENTIFIER_FOR_P12_CERT = "mleCertFromP12";

cybersource-rest-auth-netstandard/AuthenticationSdk/AuthenticationSdk/util/LogUtility.cs

@@ -85,7 +85,7 @@ public string MaskSensitiveData(string str)
                 catch (Exception e)
                 {
                     throw e;
-                } 
+                }
             }
 
             return str;