addressing PR comments

Author: monu-kumar-visa

MLE.md

@@ -129,13 +129,13 @@ Configure global settings for request MLE using these properties in your `mercha
 ### Object Configuration
 
 - **Variable**: `mapToControlMLEonAPI`
-- **Type**: `Object` or `Map` with string keys and string/boolean values
+- **Type**: `Object` or `Map` with string keys and string values
 - **Description**: Overrides global MLE settings for specific APIs. The key is the API function name, and the value controls both request and response MLE.
-- **Example**: `{ "apiFunctionName": "true::true" }` or `{ "apiFunctionName": true }`
+- **Example**: `{ "apiFunctionName": "true::true" }`
 
 #### Structure of Values in Object:
 
-(i) **String format: "requestMLE::responseMLE"** - Control both request and response MLE
+(i) **"requestMLE::responseMLE"** - Control both request and response MLE
    - `"true::true"` - Enable both request and response MLE
    - `"false::false"` - Disable both request and response MLE
    - `"true::false"` - Enable request MLE, disable response MLE
@@ -145,9 +145,10 @@ Configure global settings for request MLE using these properties in your `mercha
    - `"::false"` - Use global setting for request, disable response MLE
    - `"false::"` - Disable request MLE, use global setting for response
 
-(ii) **Boolean format** - Control request MLE only (response uses global setting)
-   - `true` - Enable request MLE
-   - `false` - Disable request MLE
+(ii) **"requestMLE"** - Control request MLE only (response uses global setting)
+   - `"true"` - Enable request MLE
+   - `"false"` - Disable request MLE
+
 
 <br/>
 
@@ -194,10 +195,10 @@ var merchantConfig = {
   mleForRequestPublicCertPath: "/path/to/public/cert.pem",
   requestMleKeyAlias: "Custom_Key_Alias",
 
-  // API-specific control with boolean values
+  // API-specific control with string values
   mapToControlMLEonAPI: {
-    "createPayment": true,     // Enable request MLE for this API
-    "capturePayment": false    // Disable request MLE for this API
+    "createPayment": "true",       // Enable request MLE for this API (simple format)
+    "capturePayment": "false::"    // Disable request MLE for this API (full format)
   }
 };
 ```
@@ -386,16 +387,17 @@ For Response MLE private key files, the following formats are supported:
 - When both new and deprecated parameters are provided, the **new parameter takes precedence**
 
 ### (iv) API-level Control Validation
-- The `mapToControlMLEonAPI` values are validated for proper format
-- Invalid formats (empty values, multiple separators, non-boolean values) will cause configuration errors
+- The `mapToControlMLEonAPI` values are validated for proper format using string format
+- Invalid formats (empty values, multiple separators) will cause configuration errors
 - Empty string after `::` separator will use global defaults
-- The object also supports backward compatibility with boolean values, which will be automatically converted to control request MLE only
+- **Note**: Boolean values are supported for backward compatibility but are deprecated. Use string format for new implementations
 
 ### (v) Configuration Validation
 - The SDK performs comprehensive validation of MLE configuration parameters
 - Conflicting values between new and deprecated parameters will result in `ConfigException`
 - File path validation is performed for certificate and private key files
-- Invalid boolean values in `mapToControlMLEonAPI` will cause parsing errors
+- Invalid string format values in `mapToControlMLEonAPI` will cause parsing errors
+- **Note**: Boolean values in `mapToControlMLEonAPI` are deprecated but still supported for backward compatibility
 
 <br/>
 

src/authentication/core/MerchantConfig.js

@@ -572,7 +572,8 @@ MerchantConfig.prototype.setResponseMlePrivateKey = function setResponseMlePriva
             const pemKey = Utility.parseAndReturnPem(
                 responseMlePrivateKey, 
                 logger, 
-                this.responseMlePrivateKeyFilePassword
+                this.responseMlePrivateKeyFilePassword,
+                'responseMlePrivateKeyFilePassword'
             );
             logger.debug('Successfully parsed response MLE private key');
             this.responseMlePrivateKey = pemKey;

src/authentication/util/MLEUtility.js

@@ -76,6 +76,7 @@ exports.checkAndDecryptEncryptedResponse = function (responseBody, merchantConfi
   logger.debug('LOG_NETWORK_RESPONSE_BEFORE_MLE_DECRYPTION: ' + JSON.stringify(responseBody));
 
   try {
+    // Private key from config will take precedence over file path.
     const privateKey = merchantConfig.getResponseMlePrivateKey() || 
                        Cache.getMleResponsePrivateKeyFromFilePath(merchantConfig);
 

src/authentication/util/Utility.js

@@ -284,7 +284,7 @@ exports.readPrivateKeyFromPemFile = function(filePath, password, logger) {
     }
 };
 
-exports.parseAndReturnPem = function(key, logger, password) {
+exports.parseAndReturnPem = function(key, logger, password, passwordPropertyName) {
   logger.debug(`Parsing private key to PEM format synchronously, key type: ${typeof key}`);
 
   if (typeof key === 'string') {
@@ -298,8 +298,10 @@ exports.parseAndReturnPem = function(key, logger, password) {
 
       // Check if password is provided for encrypted key
       if (!password || password.trim() === '') {
-        logger.error('Password is required for encrypted private key');
-        throw new Error('Password is required for encrypted private key');
+        const propertyHint = passwordPropertyName ? ` Please set the '${passwordPropertyName}' property in your configuration.` : '';
+        const errorMessage = `Password is required for encrypted private key.${propertyHint}`;
+        logger.error(errorMessage);
+        throw new Error(errorMessage);
       }
 
       try {