Skip to content

Commit 5180abc

Browse files
authored
Merge pull request #98 from CyberSource/fix-external-logger-issues
Fixes issues in external logger configuration
2 parents 2bea814 + 27bce24 commit 5180abc

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

src/authentication/logging/ExternalLoggerWrapper.js

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ class ExternalLoggerWrapper{
1313
}
1414

1515
isLoggerEmpty(){
16-
if(this.extLogger === undefined)
17-
return false;
18-
return true;
16+
return typeof this.extLogger === 'undefined'
1917
}
2018
}
2119

src/authentication/logging/LogConfiguration.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,8 +128,8 @@ class LogConfiguration {
128128
this.hasExternalLogger = false;
129129
}
130130

131-
if((typeof (this.externalLogger) === "object" && !(this.externalLogger instanceof ExternalLoggerWrapper))
132-
|| this.externalLogger === undefined || !(this.externalLogger.isLoggerEmpty())){
131+
if(this.hasExternalLogger == true && ((typeof (this.externalLogger) === "object" && !(this.externalLogger instanceof ExternalLoggerWrapper))
132+
|| this.externalLogger === undefined || (this.externalLogger.isLoggerEmpty()))){
133133
ApiException.LoggerException("No valid external logger object found. Turning off external logger flag.")
134134
this.hasExternalLogger = false;
135135
}

0 commit comments

Comments
 (0)