Skip to content

Commit d7aa35e

Browse files
author
Shiva Shankaran, Akshaya
committed
Addressed Comments
1 parent 8b7e151 commit d7aa35e

13 files changed

+6
-105
lines changed

‎AuthenticationSDK/resource/cybs.yml‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
#Logging to be enabled or not [true/false].
2222
enableLog : true
2323
#Log directory Path
24-
logDirectory : ../log
24+
logDirectory : "../log"
2525
#Enter only file name, do not enter the extension type like .log, .txt etc.
2626
logFilename : "Cybs"
2727
#Log file size in KB "5K" or MB as "5M".
2828
logSize : 10485760
2929
#Proxy Setup
30-
proxyAddress : "userproxy.visa.com"
31-
proxyPort :
30+
# proxyAddress : "userproxy.com"
31+
# proxyPort :

‎AuthenticationSDK/spec/MerchantConfigData.rb‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@ def merchantConfigProp()
1010
jsonFilePath='./PostRequestData.json'
1111
logSize=10485760
1212
enableLog=true
13-
proxyAddress='userproxy.visa.com'
14-
proxyPort=443
13+
# proxyAddress='userproxy.com'
14+
# proxyPort=''
1515
# HTTP Parameters
1616
merchantSecretKey='yBJxy6LjM2TmcPGu+GaJrHtkke25fPpUX+UY6/L/1tE='
1717
merchantKeyId='08c94330-f618-42a3-b09d-e1e43be5efda'
@@ -31,7 +31,7 @@ def merchantConfigProp()
3131
configurationDictionary['jsonFilePath']=jsonFilePath
3232
configurationDictionary['logSize']=logSize
3333
configurationDictionary['enableLog']=enableLog
34-
configurationDictionary['proxyPort']=proxyPort
34+
# configurationDictionary['proxyPort']=proxyPort
3535
configurationDictionary['merchantsecretKey']=merchantSecretKey
3636
configurationDictionary['merchantKeyId']=merchantKeyId
3737
configurationDictionary['keysDirectory']=keysDirectory

‎AuthenticationSDK/spec/MerchantConfig_spec.rb‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -53,11 +53,6 @@
5353
cybsPropertyobj['authenticationType']=123
5454
expect { Merchantconfig.new cybsPropertyobj }.to raise_error(StandardError)
5555
end
56-
# it 'Validating RunEnvironment as empty MerchantConfig File' do
57-
# cybsPropertyobj=MerchantConfigData.new.merchantConfigProp
58-
# cybsPropertyobj['runEnvironment']=''
59-
# expect { Merchantconfig.new cybsPropertyobj }.to raise_error(StandardError)
60-
# end
6156
it 'Validating keyAlias as Fixnum MerchantConfig File' do
6257
cybsPropertyobj=MerchantConfigData.new.merchantConfigProp
6358
cybsPropertyobj['keyAlias']=123

‎lib/cybersource_rest_client/api/purchase_and_refund_details_api.rb‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,6 @@ def get_purchase_and_refund_details_with_http_info(start_time, end_time, opts =
6868
if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'].to_s.length < 1
6969
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling PurchaseAndRefundDetailsApi.get_purchase_and_refund_details, the character length must be great than or equal to 1.'
7070
end
71-
72-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
73-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling PurchaseAndRefundDetailsApi.get_purchase_and_refund_details, must conform to the pattern /[a-zA-Z0-9-_]+/."
74-
# end
75-
7671
if @api_client.config.client_side_validation && opts[:'payment_subtype'] && !['ALL', 'VI', 'MC', 'AX', 'DI', 'DP'].include?(opts[:'payment_subtype'])
7772
fail ArgumentError, 'invalid value for "payment_subtype", must be one of ALL, VI, MC, AX, DI, DP'
7873
end

‎lib/cybersource_rest_client/api/report_definitions_api.rb‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,6 @@ def get_resource_info_by_report_definition_with_http_info(report_definition_name
5252
if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'].to_s.length < 1
5353
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling ReportDefinitionsApi.get_resource_info_by_report_definition, the character length must be great than or equal to 1.'
5454
end
55-
56-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
57-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling ReportDefinitionsApi.get_resource_info_by_report_definition, must conform to the pattern /[a-zA-Z0-9-_]+/."
58-
# end
59-
6055
# resource path
6156
local_var_path = 'reporting/v3/report-definitions/{reportDefinitionName}'.sub('{' + 'reportDefinitionName' + '}', report_definition_name.to_s)
6257

@@ -116,10 +111,6 @@ def get_resource_v2_info_with_http_info(opts = {})
116111
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling ReportDefinitionsApi.get_resource_v2_info, the character length must be great than or equal to 1.'
117112
end
118113

119-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
120-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling ReportDefinitionsApi.get_resource_v2_info, must conform to the pattern /[a-zA-Z0-9-_]+/."
121-
# end
122-
123114
# resource path
124115
local_var_path = 'reporting/v3/report-definitions'
125116

‎lib/cybersource_rest_client/api/report_downloads_api.rb‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,10 +59,6 @@ def download_report_with_http_info(report_date, report_name, opts = {})
5959
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling ReportDownloadsApi.download_report, the character length must be great than or equal to 1.'
6060
end
6161

62-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
63-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling ReportDownloadsApi.download_report, must conform to the pattern /[a-zA-Z0-9-_]+/."
64-
# end
65-
6662
# resource path
6763
local_var_path = 'reporting/v3/report-downloads'
6864

‎lib/cybersource_rest_client/api/report_subscriptions_api.rb‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -110,10 +110,6 @@ def delete_subscription_with_http_info(report_name, opts = {})
110110
fail ArgumentError, 'invalid value for "report_name" when calling ReportSubscriptionsApi.delete_subscription, the character length must be great than or equal to 1.'
111111
end
112112

113-
# if @api_client.config.client_side_validation && report_name !~ Regexp.new(/[a-zA-Z0-9-_+]+/)
114-
# fail ArgumentError, "invalid value for 'report_name' when calling ReportSubscriptionsApi.delete_subscription, must conform to the pattern /[a-zA-Z0-9-_+]+/."
115-
# end
116-
117113
# resource path
118114
local_var_path = 'reporting/v3/report-subscriptions/{reportName}'.sub('{' + 'reportName' + '}', report_name.to_s)
119115

@@ -223,10 +219,6 @@ def get_subscription_with_http_info(report_name, opts = {})
223219
fail ArgumentError, 'invalid value for "report_name" when calling ReportSubscriptionsApi.get_subscription, the character length must be great than or equal to 1.'
224220
end
225221

226-
# if @api_client.config.client_side_validation && report_name !~ Regexp.new(/[a-zA-Z0-9-_+]+/)
227-
# fail ArgumentError, "invalid value for 'report_name' when calling ReportSubscriptionsApi.get_subscription, must conform to the pattern /[a-zA-Z0-9-_+]+/."
228-
# end
229-
230222
# resource path
231223
local_var_path = 'reporting/v3/report-subscriptions/{reportName}'.sub('{' + 'reportName' + '}', report_name.to_s)
232224

‎lib/cybersource_rest_client/api/reports_api.rb‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -106,10 +106,6 @@ def get_report_by_report_id_with_http_info(report_id, opts = {})
106106
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling ReportsApi.get_report_by_report_id, the character length must be great than or equal to 1.'
107107
end
108108

109-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
110-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling ReportsApi.get_report_by_report_id, must conform to the pattern /[a-zA-Z0-9-_]+/."
111-
# end
112-
113109
# resource path
114110
local_var_path = 'reporting/v3/reports/{reportId}'.sub('{' + 'reportId' + '}', report_id.to_s)
115111

@@ -201,10 +197,6 @@ def search_reports_with_http_info(start_time, end_time, time_query_type, opts =
201197
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling ReportsApi.search_reports, the character length must be great than or equal to 1.'
202198
end
203199

204-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
205-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling ReportsApi.search_reports, must conform to the pattern /[a-zA-Z0-9-_]+/."
206-
# end
207-
208200
if @api_client.config.client_side_validation && opts[:'report_mime_type'] && !['application/xml', 'text/csv'].include?(opts[:'report_mime_type'])
209201
fail ArgumentError, 'invalid value for "report_mime_type", must be one of application/xml, text/csv'
210202
end

‎lib/cybersource_rest_client/api/secure_file_share_api.rb‎

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -53,10 +53,6 @@ def get_file_with_http_info(file_id, opts = {})
5353
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling SecureFileShareApi.get_file, the character length must be great than or equal to 1.'
5454
end
5555

56-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
57-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling SecureFileShareApi.get_file, must conform to the pattern /[a-zA-Z0-9-_]+/."
58-
# end
59-
6056
# resource path
6157
local_var_path = 'sfs/v1/files/{fileId}'.sub('{' + 'fileId' + '}', file_id.to_s)
6258

@@ -127,10 +123,6 @@ def get_file_details_with_http_info(start_date, end_date, opts = {})
127123
fail ArgumentError, 'invalid value for "opts[:"organization_id"]" when calling SecureFileShareApi.get_file_details, the character length must be great than or equal to 1.'
128124
end
129125

130-
# if @api_client.config.client_side_validation && !opts[:'organization_id'].nil? && opts[:'organization_id'] !~ Regexp.new(/[a-zA-Z0-9-_]+/)
131-
# fail ArgumentError, "invalid value for 'opts[:\"organization_id\"]' when calling SecureFileShareApi.get_file_details, must conform to the pattern /[a-zA-Z0-9-_]+/."
132-
# end
133-
134126
# resource path
135127
local_var_path = 'sfs/v1/file-details'
136128

‎lib/cybersource_rest_client/models/ptsv2payments_merchant_information_merchant_descriptor.rb‎

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,6 @@ def initialize(attributes = {})
111111
# @return Array for valid properties with the reasons
112112
def list_invalid_properties
113113
invalid_properties = Array.new
114-
# if [email protected]? && @name.to_s.length > 23
115-
# invalid_properties.push('invalid value for "name", the character length must be smaller than or equal to 23.')
116-
# end
117-
118114
if !@alternate_name.nil? && @alternate_name.to_s.length > 13
119115
invalid_properties.push('invalid value for "alternate_name", the character length must be smaller than or equal to 13.')
120116
end
@@ -149,7 +145,6 @@ def list_invalid_properties
149145
# Check to see if the all the properties in the model are valid
150146
# @return true if the model is valid
151147
def valid?
152-
# return false if [email protected]? && @name.to_s.length > 23
153148
return false if !@alternate_name.nil? && @alternate_name.to_s.length > 13
154149
return false if !@contact.nil? && @contact.to_s.length > 14
155150
return false if !@address1.nil? && @address1.to_s.length > 60
@@ -163,10 +158,6 @@ def valid?
163158
# Custom attribute writer method with validation
164159
# @param [Object] name Value to be assigned
165160
def name=(name)
166-
# if !name.nil? && name.to_s.length > 23
167-
# fail ArgumentError, 'invalid value for "name", the character length must be smaller than or equal to 23.'
168-
# end
169-
170161
@name = name
171162
end
172163

0 commit comments

Comments
 (0)