Skip to content

The samples are all completely independent and self-contained. #58

@BackcountryBug

Description

@BackcountryBug

Under Readme section "Using the Sample Code" - https://github.com/CyberSource/cybersource-rest-samples-php#using-the-sample-code - it states "The samples are all completely independent and self-contained.", but after reviewing the code, this doesn't appear to be true.

Example:
https://github.com/CyberSource/cybersource-rest-samples-php/blob/master/Samples/Payments/Payments/AuthorizationWithCaptureSale.php

This file has code:

require_once __DIR__ . DIRECTORY_SEPARATOR . '../../../Resources/ExternalConfiguration.php';

which is another file in the repo. Maybe I'm reading the blurb wrong, but that file to me is a sample, and if it's self-contained it shouldn't require other files.

Anyway, even if I consider "self-contained" samples to mean "the repo is self-contained as a run app", then that's not exactly true either. The above line of code requires vendor through composer that's compatible with PHP 5.6:

require_once __DIR__ . DIRECTORY_SEPARATOR . '../../../vendor/autoload.php';

This is required for at least one line in that AuthorizationWithCaptureSale.php sample file's code, like:

$api_instance = new CyberSource\Api\PaymentsApi($api_client);

I'm working on a Mac (Ventura) that doesn't have PHP 5.6 or a compatible version of composer installed, so I will have to do a deep-dive to figure that out for a "self-contained" sample file.

Anyway, I can try to get the whole repo with vendor code running, but to me the blurb is not accurate, as the sample files are not self-contained. I'm curious exactly what's meant by "self-contained" or "independent".

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions