Skip to content

Conversation

@jm-riley
Copy link

Description

Currently, the getValue method in HttpResponse performs a case-sensitive lookup of header keys after lowercasing the input key. This causes issues when response headers like "Digest" need to be retrieved as part of verification.

While creating the transient token, response from /flex/v2/tokens request contains a response header of Digest. Calling DigestHelper.verifyResponseDigest() will always throw a missingDigestHeader error when attempting to assign digestHeader value:

guard let digestHeader = response.getValue(for: "Digest") else {
    throw FlexInternalErrors.missingDigestHeader.errorResponse
}

This change modifies the HttpResponse.getValue() function to:

  1. First attempt an exact key match
  2. Only apply case-insensitive comparison if exact match fails

vthomas-cs
vthomas-cs approved these changes Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants