Skip to content

fix: case-sensitive header lookup in HttpResponse getValue method #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: case-sensitive header lookup in HttpResponse getValue method #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions flex-api-ios-sdk/FlexTokens Feature/HttpResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ struct HttpResponse: Equatable {
static func == (lhs: HttpResponse, rhs: HttpResponse) -> Bool {
return lhs.status == rhs.status && lhs.body == rhs.body
}

let status: Int
let body: String?
let headers: [AnyHashable: Any]?
Expand All @@ -21,16 +20,18 @@ struct HttpResponse: Equatable {
self.body = body
self.headers = headers
}

func isValidResponse() -> Bool {
(200...299).contains(self.status)
}

func getValue(for key: String) -> String? {
if let field = self.headers?[key.lowercased()] as? String {
return field
}

return nil
// attempt to get header value using exact key
if let field = self.headers?[key] as? String {
return field
}

// Then try case-insensitive match if needed
return self.headers?.first(where: {
($0.key as? String)?.lowercased() == key.lowercased()
})?.value as? String
}
}