Skip to content

Commit 52c03ca

Browse files
committed
[TASK] Address review feedback on template overrides
- Remove mkdir -p /templates from Dockerfile: Docker creates mount targets automatically when bind mounts are used, so the directory only exists when someone intentionally mounts templates. This avoids unnecessary filesystem lookups on every template resolution. - Add is_readable() checks alongside is_dir() for defensive robustness against permission issues. Signed-off-by: Sebastian Mendel <info@sebastianmendel.de>
1 parent 8c56472 commit 52c03ca

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

Dockerfile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,6 @@ ARG TYPO3AZUREEDGEURIVERSION
3131
ENV TYPO3AZUREEDGEURIVERSION=$TYPO3AZUREEDGEURIVERSION
3232

3333
WORKDIR /project
34-
RUN mkdir -p /templates
35-
3634
ENTRYPOINT [ "/opt/guides/entrypoint.sh" ]
3735
CMD ["-h"]
3836

packages/typo3-docs-theme/src/DependencyInjection/Typo3DocsThemeExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -100,12 +100,12 @@ public function prepend(ContainerBuilder $container): void
100100
$templates = [];
101101

102102
// Docker volume mount: highest custom priority
103-
if (is_dir('/templates')) {
103+
if (is_dir('/templates') && is_readable('/templates')) {
104104
$templates[] = '/templates';
105105
}
106106

107107
// Project-bundled templates: second custom priority
108-
if (is_dir('/project/resources/custom-templates')) {
108+
if (is_dir('/project/resources/custom-templates') && is_readable('/project/resources/custom-templates')) {
109109
$templates[] = '/project/resources/custom-templates';
110110
}
111111

0 commit comments

Comments
 (0)