Replies: 2 comments
-
+1 from me. Will see what others think. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Hi again, any news on this? |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
When using the --fail-on-error flag, should it really fail the job when the gem lock file is missing? I think it should be enough with just a warning, since there is no problem creating the bom, just that it is imprecise. A bom is correctly generated with the deps from the gemspec file when the failOnError flag is not used, so it should probably not completely fail with the flag on.
My suggestion would be to remove line 6178 here:
cdxgen/lib/cli/index.js
Lines 6172 to 6179 in 91db7fc
Beta Was this translation helpful? Give feedback.
All reactions