Merge pull request #408 from andreas-hilti/fix/optional_email

Make email optional when converting from SPDX

Author: coderpatros

src/CycloneDX.Spdx.Interop/Converters/v2_3/Helpers/Bom/Creators.cs

@@ -84,10 +84,12 @@ public static void AddSpdxCreators(this Bom bom, List<string> creators)
                         if (nonToolMatch.Success)
                         {
                             if (bom.Metadata.Authors == null) { bom.Metadata.Authors = new List<OrganizationalContact>(); }
+                            var email = nonToolMatch.Groups["email"].ToString();
                             bom.Metadata.Authors.Add(new OrganizationalContact
                             {
                                 Name = nonToolMatch.Groups["name"].ToString(),
-                                Email = nonToolMatch.Groups["email"].ToString(),
+                                // email is optional
+                                Email = email != "" ? email: null,
                             });
                             if (creator.StartsWith("Organization:"))
                             {

tests/CycloneDX.Spdx.Interop.Tests/__snapshots__/ConverterTests.FromSpdxToCDXTest_v2.2document.snap

@@ -11,12 +11,10 @@
     ],
     "authors": [
       {
-        "name": "ExampleCodeInspect",
-        "email": ""
+        "name": "ExampleCodeInspect"
       },
       {
-        "name": "Jane Doe",
-        "email": ""
+        "name": "Jane Doe"
       }
     ],
     "properties": [

tests/CycloneDX.Spdx.Interop.Tests/__snapshots__/ConverterTests.FromSpdxToCDXTest_v2.3document.snap

@@ -11,12 +11,10 @@
     ],
     "authors": [
       {
-        "name": "ExampleCodeInspect",
-        "email": ""
+        "name": "ExampleCodeInspect"
       },
       {
-        "name": "Jane Doe",
-        "email": ""
+        "name": "Jane Doe"
       }
     ],
     "properties": [