Skip to content

Commit 1ac41f2

Browse files
committed
added developer comments to internals
Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 6602e3a commit 1ac41f2

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

src/builders/fromNodePackageJson.node.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,8 @@ export class ToolBuilder {
3737
return this.#extRefFactory
3838
}
3939

40+
// Current implementation does not return `undefined` yet, but it is an option for future implementation.
41+
// To prevent breaking changes, it is declared to return `undefined`.
4042
makeTool (data: PackageJson): Models.Tool | undefined {
4143
const [name, vendor] = typeof data.name === 'string'
4244
? splitNameGroup(data.name)

src/factories/packageUrl.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -35,10 +35,6 @@ export class PackageUrlFactory {
3535
}
3636

3737
makeFromComponent (component: Component, sort: boolean = false): PackageURL | undefined {
38-
/**
39-
* For the list/spec of the well-known keys, see
40-
* {@link https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst#known-qualifiers-keyvalue-pairs}
41-
*/
4238
const qualifiers: PackageURL['qualifiers'] = {}
4339
let subpath: PackageURL['subpath']
4440

src/helpers/packageUrl.ts

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,11 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
1919

2020
/**
2121
* Known PURL qualifier names.
22-
* To be used until {@link https://github.com/package-url/packageurl-js/pull/34} gets merged
22+
* To be used until {@link https://github.com/package-url/packageurl-js/pull/34} gets merged and released,
2323
* and {@link https://github.com/package-url/packageurl-js/issues/35} gets sorted out.
24+
*
25+
* For the list/spec of the well-known keys,
26+
* see {@link https://github.com/package-url/purl-spec/blob/master/PURL-SPECIFICATION.rst#known-qualifiers-keyvalue-pairs}
2427
*/
2528
export const enum PackageUrlQualifierNames {
2629
DownloadURL = 'download_url',

0 commit comments

Comments
 (0)