Skip to content

Commit 29dc1c0

Browse files
authored
fix: Component.description & Component.scope (#74)
* fix: xml normalize scope correctly * fix: Component.description get picked up from optioanl properties in constructor Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 0c0abb7 commit 29dc1c0

File tree

11 files changed

+9
-8
lines changed

11 files changed

+9
-8
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"prebuild:node": "node -r fs -e 'fs.rmSync(\"dist.node\",{recursive:true,force:true})'",
7878
"build:node": "tsc -b ./tsconfig.node.json",
7979
"prebuild:web": "node -r fs -e 'fs.rmSync(\"dist.web\",{recursive:true,force:true})'",
80-
"build:web": "webpack",
80+
"build:web": "webpack build",
8181
"cs-fix": "eslint --fix .",
8282
"test": "run-p --aggregate-output -lc test:*",
8383
"test:node": "mocha -p",

src/models/component.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,7 @@ export class Component implements Comparable {
9090
this.scope = op.scope
9191
this.swid = op.swid
9292
this.version = op.version
93+
this.description = op.description
9394
this.dependencies = op.dependencies ?? new BomRefRepository()
9495
this.cpe = op.cpe
9596
}

src/serialize/xml/normalize.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -345,7 +345,7 @@ export class ComponentNormalizer extends Base {
345345
'version'
346346
),
347347
makeOptionalTextElement(data.description, 'description'),
348-
makeOptionalTextElement(data.scope, 'description'),
348+
makeOptionalTextElement(data.scope, 'scope'),
349349
hashes,
350350
licenses,
351351
makeOptionalTextElement(data.copyright, 'copyright'),
File renamed without changes.

tests/_data/normalizeResults/xml_sortedLists_spec1.2.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/_data/normalizeResults/xml_sortedLists_spec1.3.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/_data/normalizeResults/xml_sortedLists_spec1.4.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
File renamed without changes.

tests/_data/serializeResults/xml_complex_spec1.2.xml.bin

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/_data/serializeResults/xml_complex_spec1.3.xml.bin

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)