chore(deps-dev): bump the eslint group with 1 update (#1000)

* chore(deps-dev): bump the eslint group with 1 update

Bumps the eslint group with 1 update: [eslint-config-standard-with-typescript](https://github.com/standard/eslint-config-standard-with-typescript).

- [Release notes](https://github.com/standard/eslint-config-standard-with-typescript/releases)
- [Changelog](https://github.com/standard/eslint-config-standard-with-typescript/blob/master/CHANGELOG.md)
- [Commits](mightyiam/eslint-config-love@v40.0.0...v42.0.0)

---
updated-dependencies:
- dependency-name: eslint-config-standard-with-typescript
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>

* fix: Possible bug in XML serialization of undefined children

Signed-off-by: Jan Kowalleck <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jan Kowalleck <[email protected]>

Author: dependabot[bot]

HISTORY.md

@@ -4,10 +4,13 @@ All notable changes to this project will be documented in this file.
 
 ## unreleased
 
+* Fixed
+  * Possible bug in XML serialization of undefined children (via [#1000]) 
 * Build
   * Use _TypeScript_ `v5.3.3` now, was `v5.3.2` (via [#999])
 
 [#999]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/999
+[#1000]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1000
 
 ## 6.1.2 -- 2023-12-02
 

libs/universal-node-xml/stringifiers/xmlbuilder2.js

@@ -38,14 +38,14 @@ module.exports = typeof create === 'function'
 /* eslint-enable jsdoc/valid-types */
 
 /**
- * @param {Element} element
+ * @param {Element} rootElement
  * @param {string|number|undefined} [space]
  * @return {string}
  */
-function stringify (element, { space } = {}) {
+function stringify (rootElement, { space } = {}) {
   const indent = makeIndent(space)
   const doc = create({ encoding: 'UTF-8' })
-  addEle(doc, element)
+  addEle(doc, rootElement)
   return doc.end({
     format: 'xml',
     newline: '\n',
@@ -63,9 +63,11 @@ function addEle (parent, element, parentNS = null) {
   if (element.type !== 'element') { return }
   const ns = getNS(element) ?? parentNS
   const ele = parent.ele(ns, element.name, element.attributes)
-  if (typeof element.children === 'string' || typeof element.children === 'number') {
+  if (element.children === undefined) {
+    /* pass */
+  } else if (typeof element.children === 'string' || typeof element.children === 'number') {
     ele.txt(element.children.toString())
-  } else if (Array.isArray(element.children)) {
+  } else {
     for (const child of element.children) {
       addEle(ele, child, ns)
     }

package.json

@@ -84,7 +84,7 @@
     "deepmerge": "^4.2.2",
     "eslint": "8.55.0",
     "eslint-config-standard": "17.1.0",
-    "eslint-config-standard-with-typescript": "40.0.0",
+    "eslint-config-standard-with-typescript": "42.0.0",
     "eslint-plugin-header": "3.1.1",
     "eslint-plugin-jsdoc": "46.9.0",
     "eslint-plugin-simple-import-sort": "10.0.0",

src/serialize/xmlSerializer.web.ts

@@ -36,11 +36,11 @@ export class XmlSerializer extends XmlBaseSerializer {
   }
 
   #buildXmlDocument (
-    normalizedBom: SimpleXml.Element
+    rootElement: SimpleXml.Element
   ): XMLDocument {
     const namespace = null
     const doc = document.implementation.createDocument(namespace, null)
-    doc.appendChild(this.#buildElement(normalizedBom, doc, namespace))
+    doc.appendChild(this.#buildElement(rootElement, doc, namespace))
     return doc
   }
 
@@ -58,7 +58,7 @@ export class XmlSerializer extends XmlBaseSerializer {
       this.#setAttributes(node, element.attributes)
     }
     if (isNotUndefined(element.children)) {
-      this.#setChildren(node, element.children, ns)
+      this.#addChildren(node, element.children, ns)
     }
     return node
   }
@@ -72,14 +72,18 @@ export class XmlSerializer extends XmlBaseSerializer {
     }
   }
 
-  #setChildren (node: Element, children: SimpleXml.ElementChildren, parentNS: string | null = null): void {
+  #addChildren (node: Element, children: SimpleXml.ElementChildren, parentNS: string | null = null): void {
+    if (children === undefined) {
+      return
+    }
+
     if (typeof children === 'string' || typeof children === 'number') {
       node.textContent = children.toString()
       return
     }
 
     const doc = node.ownerDocument
-    for (const child of (children as Iterable<SimpleXml.Comment | SimpleXml.Element>)) {
+    for (const child of children) {
       if (child.type === 'element') {
         node.appendChild(this.#buildElement(child, doc, parentNS))
       }

src/spdx.ts

@@ -38,6 +38,7 @@ const spdxLowerToActual: Readonly<Record<string, SpdxId>> = Object.freeze(Object
 ))
 
 export function isSupportedSpdxId (value: SpdxId | any): value is SpdxId {
+  /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
   return spdxIds.has(value)
 }
 

src/spec/_protocol.ts

@@ -109,14 +109,17 @@ export class _Spec implements _SpecProtocol {
   }
 
   supportsFormat (f: Format | any): boolean {
+    /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
     return this.#formats.has(f)
   }
 
   supportsComponentType (ct: ComponentType | any): boolean {
+    /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
     return this.#componentTypes.has(ct)
   }
 
   supportsHashAlgorithm (ha: HashAlgorithm | any): boolean {
+    /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
     return this.#hashAlgorithms.has(ha)
   }
 
@@ -126,6 +129,7 @@ export class _Spec implements _SpecProtocol {
   }
 
   supportsExternalReferenceType (ert: ExternalReferenceType | any): boolean {
+    /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
     return this.#externalReferenceTypes.has(ert)
   }
 
@@ -151,6 +155,7 @@ export class _Spec implements _SpecProtocol {
   }
 
   supportsVulnerabilityRatingMethod (rm: Vulnerability.RatingMethod | any): boolean {
+    /* eslint-disable-next-line @typescript-eslint/no-unsafe-argument */
     return this.#vulnerabilityRatingMethods.has(rm)
   }