wip

Signed-off-by: Jan Kowalleck <[email protected]>

Author: jkowalleck

src/_helpers/mime.node.ts

@@ -25,14 +25,14 @@ const MIMETYPE_TEXT_PLAIN: MimeType = 'text/plain'
 
 const MAP_TEXT_EXTENSION_MIMETYPE: Readonly<Record<string, MimeType>> = {
   '': MIMETYPE_TEXT_PLAIN,
-  // https://www.iana.org/assignments/media-types/media-types.xhtml#text
+  // https://www.iana.org/assignments/media-types/media-types.xhtml
   '.csv': 'text/csv',
   '.htm': 'text/html',
   '.html': 'text/html',
   '.md': 'text/markdown',
   '.txt': MIMETYPE_TEXT_PLAIN,
   '.rst': 'text/prs.fallenstein.rst',
-  '.rtf': 'text/rtf', // not `application/xml` -- our scope is text!
+  '.rtf': 'application/rtf',  // our scope is text, yes, but RTF is binary - so we should base64 encode it ...
   '.xml': 'text/xml', // not `application/xml` -- our scope is text!
   // add more mime types above this line. pull-requests welcome!
   // license-specific files

src/utils/licenseUtility.node.ts

@@ -85,7 +85,10 @@ export class LicenseEvidenceGatherer<P extends string = string> {
       }
       try {
         yield { filePath, file, text: new Attachment(
-            this.#fs.readFileSync(filePath).toString('base64'), // may throw
+            // since we cannot be sure weather the file content is text-only, or maybe binary,
+              // we tend to base64 everything, regardless of the detected encoding.
+            this.#fs.readFileSync(filePath) // may throw
+                .toString('base64'),
             { contentType, encoding: AttachmentEncoding.Base64 }
           ) }
       } catch (cause) {