style: simplify internal lib universal-node-xml (#621)

Signed-off-by: Jan Kowalleck <[email protected]>

Author: jkowalleck

libs/universal-node-xml/index.d.ts

@@ -20,14 +20,13 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
 import type { SerializerOptions } from '../../src/serialize/types'
 import type { SimpleXml } from '../../src/serialize/xml/types'
 
+/** @throws {@link Error} */
 declare type ThrowError = (..._: any[]) => never
 
 declare type Stringify = (element: SimpleXml.Element, options?: SerializerOptions) => string
-export declare const stringify: Stringify | undefined
-export declare const stringifyFallback: Stringify | ThrowError
+export declare const stringify: Stringify | ThrowError
 
 /*
 declare type Parse = (xml: string) => SimpleXml.Element
-export declare const parse: Parse | undefined
-export declare const parseFallback: Parse | ThrowError
+export declare const parse: Parse | ThrowError
 */

libs/universal-node-xml/index.js

@@ -17,12 +17,20 @@ SPDX-License-Identifier: Apache-2.0
 Copyright (c) OWASP Foundation. All Rights Reserved.
 */
 
+module.exports.stringify = function () {
+  /* c8 ignore start */
+  throw new Error(
+    'No stringifier available. Please install any of the optional xml libraries: ' +
+    possibleStringifiers.join(', ')
+  )
+  /* c8 ignore end */
+}
+
 const possibleStringifiers = [
   // prioritized list of possible implementations
   'xmlbuilder2'
 ]
 
-module.exports.stringify = undefined
 for (const file of possibleStringifiers) {
   try {
     const possibleStringifier = require(`./stringifiers/${file}`)
@@ -36,10 +44,3 @@ for (const file of possibleStringifiers) {
   }
   /* c8 ignore end */
 }
-
-module.exports.stringifyFallback = module.exports.stringify ??
-  /* c8 ignore start */
-  function () {
-    throw new Error('No stringifier available. Please install one of the optional xml libraries.')
-  }
-/* c8 ignore end */

src/serialize/xmlSerializer.node.ts

@@ -17,7 +17,7 @@ SPDX-License-Identifier: Apache-2.0
 Copyright (c) OWASP Foundation. All Rights Reserved.
 */
 
-import { stringifyFallback } from '../../libs/universal-node-xml'
+import { stringify } from '../../libs/universal-node-xml'
 import type { SerializerOptions } from './types'
 import type { SimpleXml } from './xml/types'
 import { XmlBaseSerializer } from './xmlBaseSerializer'
@@ -30,6 +30,6 @@ export class XmlSerializer extends XmlBaseSerializer {
     normalizedBom: SimpleXml.Element,
     options: SerializerOptions = {}
   ): string {
-    return stringifyFallback(normalizedBom, options)
+    return stringify(normalizedBom, options)
   }
 }