tests

Signed-off-by: Jan Kowalleck <[email protected]>

Author: jkowalleck

src/factories/fromNodePackageJson.node.ts

@@ -148,9 +148,13 @@ export class PackageUrlFactory extends PlainPackageUrlFactory<'npm'> {
       // nothing to base a checksum on
       qualifiers.delete(PurlQualifierNames.Checksum)
     }
-    purl.qualifiers = qualifiers.size > 0
-      ? Object.fromEntries(qualifiers.entries())
-      : undefined
+    if (qualifiers.size > 0) {
+      purl.qualifiers = Object.fromEntries(qualifiers.entries())
+      /* @ts-ignore TS2322 */
+      purl.qualifiers.__proto__ = null
+    } else {
+      purl.qualifiers = undefined
+    }
 
     return purl
   }

src/factories/packageUrl.ts

@@ -36,6 +36,8 @@ export class PackageUrlFactory<PurlType extends PackageURL['type'] = PackageURL[
   /* eslint-disable-next-line @typescript-eslint/no-inferrable-types -- docs */
   makeFromComponent (component: Component, sort: boolean = false): PackageURL | undefined {
     const qualifiers: PackageURL['qualifiers'] = {}
+    /* @ts-ignore TS2322 */
+    qualifiers.__proto__ = null
     let subpath: PackageURL['subpath'] = undefined
 
     // sorting to allow reproducibility: use the last instance for a `extRef.type`, if multiples exist

tests/integration/Factories.FromNodePackageJson.PackageUrlFactory.test.js

@@ -251,7 +251,7 @@ suite('integration: Factories.FromNodePackageJson.PackageUrlFactory', () => {
           vcs_url: 'git+https://foo.bar/repo.git'
         }, undefined)
       // expect objet's keys in alphabetical oder, expect sorted hash list
-      const expectedString = 'pkg:testing/name?checksum=blake3%3Aaa51dcd43d5c6c5203ee16906fd6b35db298b9b2e1de3fce81811d4806b76b7d%2Csha-256%3Ac3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2&vcs_url=git%2Bhttps%3A//foo.bar/repo.git'
+      const expectedString = 'pkg:testing/name?checksum=blake3%3Aaa51dcd43d5c6c5203ee16906fd6b35db298b9b2e1de3fce81811d4806b76b7d%2Csha-256%3Ac3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2&vcs_url=git%2Bhttps%3A%2F%2Ffoo.bar%2Frepo.git'
 
       const actual = sut.makeFromComponent(component, true)
 
@@ -287,7 +287,7 @@ suite('integration: Factories.FromNodePackageJson.PackageUrlFactory', () => {
           download_url: 'https://foo.bar/download-2'
         }, undefined)
       // expect objet's keys in alphabetical oder, expect sorted hash list
-      const expectedString = 'pkg:testing/name?download_url=https%3A//foo.bar/download-2'
+      const expectedString = 'pkg:testing/name?download_url=https%3A%2F%2Ffoo.bar%2Fdownload-2'
 
       const actual1 = sut.makeFromComponent(component1, true)
       const actual2 = sut.makeFromComponent(component2, true)

tests/integration/Factories.PackageUrlFactory.test.js

@@ -174,7 +174,7 @@ suite('integration: Factories.PackageUrlFactory', () => {
           vcs_url: 'git+https://foo.bar/repo.git'
         }, undefined)
       // expect objet's keys in alphabetical oder, expect sorted hash list
-      const expectedString = 'pkg:testing/name?checksum=blake3%3Aaa51dcd43d5c6c5203ee16906fd6b35db298b9b2e1de3fce81811d4806b76b7d%2Csha-256%3Ac3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2&download_url=https%3A//foo.bar/download&vcs_url=git%2Bhttps%3A//foo.bar/repo.git'
+      const expectedString = 'pkg:testing/name?checksum=blake3%3Aaa51dcd43d5c6c5203ee16906fd6b35db298b9b2e1de3fce81811d4806b76b7d%2Csha-256%3Ac3ab8ff13720e8ad9047dd39466b3c8974e592c2fa383d4a3960714caef0c4f2&download_url=https%3A%2F%2Ffoo.bar%2Fdownload&vcs_url=git%2Bhttps%3A%2F%2Ffoo.bar%2Frepo.git'
 
       const actual = sut.makeFromComponent(component, true)
 
@@ -213,7 +213,7 @@ suite('integration: Factories.PackageUrlFactory', () => {
           vcs_url: 'git+https://foo.bar/repo.git'
         }, undefined)
       // expect objet's keys in alphabetical oder, expect sorted hash list
-      const expectedString = 'pkg:testing/name?download_url=https%3A//foo.bar/download-2&vcs_url=git%2Bhttps%3A//foo.bar/repo.git'
+      const expectedString = 'pkg:testing/name?download_url=https%3A%2F%2Ffoo.bar%2Fdownload-2&vcs_url=git%2Bhttps%3A%2F%2Ffoo.bar%2Frepo.git'
 
       const actual1 = sut.makeFromComponent(component1, true)
       const actual2 = sut.makeFromComponent(component2, true)