Skip to content

Commit 8acf5e7

Browse files
authored
rename sub-namespace FromPackageJson -> FromNodePackageJson (#148)
* Deprecated * The sub-namespace `FromPackageJson` will be known as `FromNodePackageJson`. * `Factories.FromPackageJson` -> `Factories.FromNodePackageJson` * `Builders.FromPackageJson` -> `Builders.FromNodePackageJson` Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 160644b commit 8acf5e7

11 files changed

+32
-23
lines changed

HISTORY.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,14 @@ All notable changes to this project will be documented in this file.
2020
* Method `Factories.PackageUrlFactory.makeFromComponent()` got a new optional parameter `sort`,
2121
to indicate whether to go the extra mile and bring hashes and qualifiers in alphabetical order.
2222
This feature switch is related to reproducible builds.
23+
* Deprecated
24+
* The sub-namespace `FromPackageJson` will be known as `FromNodePackageJson`. (via [#148])
25+
* `Factories.FromPackageJson` -> `Factories.FromNodePackageJson`
26+
* `Builders.FromPackageJson` -> `Builders.FromNodePackageJson`
2327

2428
[#145]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/145
2529
[#146]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/146
30+
[#148]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/148
2631

2732
## 1.1.0 - 2022-07-29
2833

src/builders/fromPackageJson.node.ts renamed to src/builders/fromNodePackageJson.node.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,13 +27,13 @@ import { PackageJson, splitNameGroup } from '../helpers/packageJson'
2727
*/
2828

2929
export class ToolBuilder {
30-
readonly #extRefFactory: Factories.FromPackageJson.ExternalReferenceFactory
30+
readonly #extRefFactory: Factories.FromNodePackageJson.ExternalReferenceFactory
3131

32-
constructor (extRefFactory: Factories.FromPackageJson.ExternalReferenceFactory) {
32+
constructor (extRefFactory: Factories.FromNodePackageJson.ExternalReferenceFactory) {
3333
this.#extRefFactory = extRefFactory
3434
}
3535

36-
get extRefFactory (): Factories.FromPackageJson.ExternalReferenceFactory {
36+
get extRefFactory (): Factories.FromNodePackageJson.ExternalReferenceFactory {
3737
return this.#extRefFactory
3838
}
3939

@@ -54,18 +54,18 @@ export class ToolBuilder {
5454
}
5555

5656
export class ComponentBuilder {
57-
readonly #extRefFactory: Factories.FromPackageJson.ExternalReferenceFactory
57+
readonly #extRefFactory: Factories.FromNodePackageJson.ExternalReferenceFactory
5858
readonly #licenseFactory: Factories.LicenseFactory
5959

6060
constructor (
61-
extRefFactory: Factories.FromPackageJson.ExternalReferenceFactory,
61+
extRefFactory: Factories.FromNodePackageJson.ExternalReferenceFactory,
6262
licenseFactory: Factories.LicenseFactory
6363
) {
6464
this.#extRefFactory = extRefFactory
6565
this.#licenseFactory = licenseFactory
6666
}
6767

68-
get extRefFactory (): Factories.FromPackageJson.ExternalReferenceFactory {
68+
get extRefFactory (): Factories.FromNodePackageJson.ExternalReferenceFactory {
6969
return this.#extRefFactory
7070
}
7171

src/builders/index.node.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,6 @@ SPDX-License-Identifier: Apache-2.0
1717
Copyright (c) OWASP Foundation. All Rights Reserved.
1818
*/
1919

20-
export * as FromPackageJson from './fromPackageJson.node'
20+
export * as FromNodePackageJson from './fromNodePackageJson.node'
21+
/** @deprecated use {@see FromNodePackageJson} instead of {@see FromPackageJson} */
22+
export * as FromPackageJson from './fromNodePackageJson.node'
File renamed without changes.

src/factories/index.node.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,6 @@ Copyright (c) OWASP Foundation. All Rights Reserved.
1919

2020
export * from './index.common'
2121

22-
export * as FromPackageJson from './fromPackageJson.node'
22+
export * as FromNodePackageJson from './fromNodePackageJson.node'
23+
/** @deprecated use {@see FromNodePackageJson} instead of {@see FromPackageJson} */
24+
export * as FromPackageJson from './fromNodePackageJson.node'

tests/integration/Builders.FromPackageJson.ComponentBuilder.test.js renamed to tests/integration/Builders.FromNodePackageJson.ComponentBuilder.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,13 +25,13 @@ const {
2525
Enums,
2626
Models,
2727
Factories,
28-
Builders: { FromPackageJson: { ComponentBuilder } }
28+
Builders: { FromNodePackageJson: { ComponentBuilder } }
2929
} = require('../../')
3030

31-
suite('Builders.FromPackageJson.ComponentBuilder', () => {
31+
suite('Builders.FromNodePackageJson.ComponentBuilder', () => {
3232
const salt = Math.random()
3333

34-
const extRefFactory = new Factories.FromPackageJson.ExternalReferenceFactory()
34+
const extRefFactory = new Factories.FromNodePackageJson.ExternalReferenceFactory()
3535
extRefFactory.makeExternalReferences = () => [`FAKE REFERENCES ${salt}`]
3636
const licenseFactory = new Factories.LicenseFactory()
3737
licenseFactory.makeFromString = () => `FAKE LICENSE ${salt}`

tests/integration/Builders.FromPackageJson.ToolBuilders.test.js renamed to tests/integration/Builders.FromNodePackageJson.ToolBuilders.test.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ const { suite, test } = require('mocha')
2424
const {
2525
Models,
2626
Factories,
27-
Builders: { FromPackageJson: { ToolBuilder } }
27+
Builders: { FromNodePackageJson: { ToolBuilder } }
2828
} = require('../../')
2929

30-
suite('Builders.FromPackageJson.ToolBuilder', () => {
30+
suite('Builders.FromNodePackageJson.ToolBuilder', () => {
3131
const salt = Math.random()
3232

33-
const extRefFactory = new Factories.FromPackageJson.ExternalReferenceFactory()
33+
const extRefFactory = new Factories.FromNodePackageJson.ExternalReferenceFactory()
3434
extRefFactory.makeExternalReferences = () => [`FAKE REFERENCES ${salt}`]
3535

3636
const sut = new ToolBuilder(extRefFactory)

tests/integration/Factories.FromPackageJson.ExternalReferenceFactory.test.js renamed to tests/integration/Factories.FromNodePackageJson.ExternalReferenceFactory.test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,10 @@ const { suite, test } = require('mocha')
2424
const {
2525
Enums: { ExternalReferenceType },
2626
Models: { ExternalReference },
27-
Factories: { FromPackageJson: { ExternalReferenceFactory } }
27+
Factories: { FromNodePackageJson: { ExternalReferenceFactory } }
2828
} = require('../../')
2929

30-
suite('Factories.FromPackageJson.ExternalReferenceFactory', () => {
30+
suite('Factories.FromNodePackageJson.ExternalReferenceFactory', () => {
3131
const sut = new ExternalReferenceFactory()
3232

3333
suite('from "homepage"', () => {

tests/unit/Builders.FromPackageJson.ComponentBuilder.spec.js renamed to tests/unit/Builders.FromNodePackageJson.ComponentBuilder.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,14 @@ const assert = require('assert')
2222
const { suite, test } = require('mocha')
2323

2424
const {
25-
Builders: { FromPackageJson: { ComponentBuilder } },
25+
Builders: { FromNodePackageJson: { ComponentBuilder } },
2626
Factories: {
27-
FromPackageJson: { ExternalReferenceFactory },
27+
FromNodePackageJson: { ExternalReferenceFactory },
2828
LicenseFactory
2929
}
3030
} = require('../../')
3131

32-
suite('Builders.FromPackageJson.ToolBuilder', () => {
32+
suite('Builders.FromNodePackageJson.ToolBuilder', () => {
3333
test('construct', () => {
3434
const extRefFactory = new ExternalReferenceFactory()
3535
const licenseFactory = new LicenseFactory()

tests/unit/Builders.FromPackageJson.ToolBuilder.spec.js renamed to tests/unit/Builders.FromNodePackageJson.ToolBuilder.spec.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,11 @@ const assert = require('assert')
2222
const { suite, test } = require('mocha')
2323

2424
const {
25-
Builders: { FromPackageJson: { ToolBuilder } },
26-
Factories: { FromPackageJson: { ExternalReferenceFactory } }
25+
Builders: { FromNodePackageJson: { ToolBuilder } },
26+
Factories: { FromNodePackageJson: { ExternalReferenceFactory } }
2727
} = require('../../')
2828

29-
suite('Builders.FromPackageJson.ToolBuilder', () => {
29+
suite('Builders.FromNodePackageJson.ToolBuilder', () => {
3030
test('construct', () => {
3131
const extRefFactory = new ExternalReferenceFactory()
3232

0 commit comments

Comments
 (0)