Processed review comments

Signed-off-by: Leon Grave <[email protected]>

Author: SierraNL

HISTORY.md

@@ -18,6 +18,7 @@ All notable changes to this project will be documented in this file.
   * Serializers and `Bom`-Normalizers will take changed `Models.Bom.tools` into account ([#1152] via [#1163])
 * Dependencies
   * Support `libxmljs2@^0.35` (via [#1173])
+  * Support `libxml2-wasm@^0.41` as an alternative for `libxmljs2` (via [#1184])
   * Use `packageurl-js@^2.0.1`, was `@>=0.0.6 <0.0.8 || ^1` (via [#1142])
 
 [#1142]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1142

package.json

@@ -87,6 +87,7 @@
     "ajv": "^8.12.0",
     "ajv-formats": "^3.0.1",
     "ajv-formats-draft2019": "^1.6.1",
+    "libxmljs2": "^0.31 || ^0.32 || ^0.33 || ^0.35",
     "libxml2-wasm": "^0.4.1",
     "xmlbuilder2": "^3.0.2"
   },

src/_optPlug.node/xmlValidator.ts

@@ -27,6 +27,7 @@ export default opWrapper<Functionality>('XmlValidator', [
   /* eslint-disable @typescript-eslint/no-unsafe-member-access, @typescript-eslint/no-unsafe-return, @typescript-eslint/no-require-imports
      -- needed */
 
+  ['libxmljs2', () => require('./__xmlValidators/libxmljs2').default],
   ['libxml2-wasm', () => require('./__xmlValidators/libxml2-wasm').default]
   // ... add others here, pull-requests welcome!
 

tests/functional/internals/OpPlug.node.xmlValidator.implementation.spec.js

@@ -29,7 +29,7 @@ const { realpathSync } = require('fs')
 const { join } = require('path')
 
 suite('functional: internals: OpPlug.node.xmlValidator implementation', () => {
-  for (const impl of ['libxmljs2']) {
+  for (const impl of ['libxmljs2','libxml2-wasm']) {
     suite(impl, () => {
       let makeValidator
       try {