Skip to content

Commit ab27577

Browse files
authored
chore: package-manager-cache: false (#1315)
caused by complete fuckup of the https://github.com/actions/setup-node authors. we dont want unexpected caching. we dont have a lockfile for a reason -- we want the latest versions, always. Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 505eb92 commit ab27577

File tree

2 files changed

+24
-22
lines changed

2 files changed

+24
-22
lines changed

.github/workflows/nodejs.yml

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -44,11 +44,10 @@ jobs:
4444
uses: actions/checkout@v5
4545
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
4646
# see https://github.com/actions/setup-node
47-
uses: actions/setup-node@v5
47+
uses: actions/setup-node@v6
4848
with:
4949
node-version: ${{ env.NODE_ACTIVE_LTS }}
50-
# cache: "npm"
51-
# cache-dependency-path: "**/package-lock.json"
50+
package-manager-cache: false
5251
- name: setup project
5352
run: npm i --ignore-scripts --include=optional --loglevel=silly
5453
- name: build ${{ matrix.target }}
@@ -71,11 +70,10 @@ jobs:
7170
uses: actions/checkout@v5
7271
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
7372
# see https://github.com/actions/setup-node
74-
uses: actions/setup-node@v5
73+
uses: actions/setup-node@v6
7574
with:
7675
node-version: ${{ env.NODE_ACTIVE_LTS }}
77-
# cache: "npm"
78-
# cache-dependency-path: "**/package-lock.json"
76+
package-manager-cache: false
7977
- name: setup project
8078
run: npm i --ignore-scripts --include=optional --loglevel=silly
8179
- name: test
@@ -98,11 +96,10 @@ jobs:
9896
path: dist.d
9997
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
10098
# see https://github.com/actions/setup-node
101-
uses: actions/setup-node@v5
99+
uses: actions/setup-node@v6
102100
with:
103101
node-version: ${{ env.NODE_ACTIVE_LTS }}
104-
# cache: "npm"
105-
# cache-dependency-path: "**/package-lock.json"
102+
package-manager-cache: false
106103
- name: setup project
107104
run: |
108105
npm install --ignore-scripts --loglevel=silly
@@ -146,11 +143,10 @@ jobs:
146143
uses: actions/checkout@v5
147144
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
148145
# see https://github.com/actions/setup-node
149-
uses: actions/setup-node@v5
146+
uses: actions/setup-node@v6
150147
with:
151148
node-version: ${{ env.NODE_ACTIVE_LTS }}
152-
# cache: "npm"
153-
# cache-dependency-path: "**/package-lock.json"
149+
package-manager-cache: false
154150
- name: setup project
155151
run: npm install --ignore-scripts --loglevel=silly
156152
- name: setup tool
@@ -183,9 +179,10 @@ jobs:
183179
uses: actions/checkout@v5
184180
- name: Setup Node.js ${{ matrix.node-version }}
185181
# see https://github.com/actions/setup-node
186-
uses: actions/setup-node@v5
182+
uses: actions/setup-node@v6
187183
with:
188184
node-version: ${{ matrix.node-version }}
185+
package-manager-cache: false
189186
# do not use caching, use fresh version always, since some deps are not pinned -- since this is a library.
190187
- name: bump npm
191188
shell: bash
@@ -259,9 +256,10 @@ jobs:
259256
uses: actions/checkout@v5
260257
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
261258
# see https://github.com/actions/setup-node
262-
uses: actions/setup-node@v5
259+
uses: actions/setup-node@v6
263260
with:
264261
node-version: ${{ env.NODE_ACTIVE_LTS }}
262+
package-manager-cache: false
265263
- name: setup library
266264
run: |
267265
set -ex
@@ -337,9 +335,10 @@ jobs:
337335
uses: actions/checkout@v5
338336
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
339337
# see https://github.com/actions/setup-node
340-
uses: actions/setup-node@v5
338+
uses: actions/setup-node@v6
341339
with:
342340
node-version: ${{ env.NODE_ACTIVE_LTS }}
341+
package-manager-cache: false
343342
- name: fetch build artifact 'node'
344343
# see https://github.com/actions/download-artifact
345344
uses: actions/download-artifact@v5
@@ -388,9 +387,10 @@ jobs:
388387
uses: actions/checkout@v5
389388
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
390389
# see https://github.com/actions/setup-node
391-
uses: actions/setup-node@v5
390+
uses: actions/setup-node@v6
392391
with:
393392
node-version: ${{ env.NODE_ACTIVE_LTS }}
393+
package-manager-cache: false
394394
- name: fetch build artifact 'd'
395395
# see https://github.com/actions/download-artifact
396396
uses: actions/download-artifact@v5
@@ -448,9 +448,10 @@ jobs:
448448
uses: actions/checkout@v5
449449
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
450450
# see https://github.com/actions/setup-node
451-
uses: actions/setup-node@v5
451+
uses: actions/setup-node@v6
452452
with:
453453
node-version: ${{ env.NODE_ACTIVE_LTS }}
454+
package-manager-cache: false
454455
- name: fetch build artifact 'node'
455456
# see https://github.com/actions/download-artifact
456457
uses: actions/download-artifact@v5
@@ -482,11 +483,10 @@ jobs:
482483
uses: actions/checkout@v5
483484
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
484485
# see https://github.com/actions/setup-node
485-
uses: actions/setup-node@v5
486+
uses: actions/setup-node@v6
486487
with:
487488
node-version: ${{ env.NODE_ACTIVE_LTS }}
488-
# cache: "npm"
489-
# cache-dependency-path: "**/package-lock.json"
489+
package-manager-cache: false
490490
- name: setup project
491491
run: |
492492
set -ex

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,9 +59,10 @@ jobs:
5959
git config --local user.name "${GITHUB_ACTOR}"
6060
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
6161
# see https://github.com/actions/setup-node
62-
uses: actions/setup-node@v5
62+
uses: actions/setup-node@v6
6363
with:
6464
node-version: ${{ env.NODE_ACTIVE_LTS }}
65+
package-manager-cache: false
6566
## ! no npm build at the moment
6667
- name: bump VERSION
6768
id: bump
@@ -100,9 +101,10 @@ jobs:
100101
ref: ${{ needs.bump.outputs.version }}
101102
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
102103
# see https://github.com/actions/setup-node
103-
uses: actions/setup-node@v5
104+
uses: actions/setup-node@v6
104105
with:
105106
node-version: ${{ env.NODE_ACTIVE_LTS }}
107+
package-manager-cache: false
106108
- name: setup project
107109
run: |
108110
npm install --ignore-scripts --include=optional --loglevel=silly

0 commit comments

Comments
 (0)