refactor: Removed dynamic imports in NodeJS-specific XML serializer lookup (#1018)

This should improve compatibility with linkers and bundlers.

---------

Signed-off-by: Augustus Kling <[email protected]>
Signed-off-by: Jan Kowalleck <[email protected]>
Co-authored-by: Jan Kowalleck <[email protected]>

Author: AugustusKling

HISTORY.md

@@ -4,12 +4,18 @@ All notable changes to this project will be documented in this file.
 
 ## unreleased
 
+* Refactor
+  * Removed dynamic imports in _Node.js_-specific XML serializer lookup ([#1017] via [#1018])  
+    This should improve compatibility with linkers and bundlers.
 * Build
   * Use _webpack_ `v5.90.3` now, was `v5.89.0` (via [#1008], [#1013], [#1015])
 
 [#1008]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1008
 [#1013]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1013
 [#1015]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1015
+[#1017]: https://github.com/CycloneDX/cyclonedx-javascript-library/issues/1017
+[#1018]: https://github.com/CycloneDX/cyclonedx-javascript-library/pull/1018
+
 
 ## 6.3.1 -- 2023-12-11
 

libs/universal-node-xml/index.js

@@ -17,23 +17,30 @@ SPDX-License-Identifier: Apache-2.0
 Copyright (c) OWASP Foundation. All Rights Reserved.
 */
 
+/* eslint-disable jsdoc/valid-types --
+   JSDoc is still missing support for tuples - https://github.com/jsdoc/jsdoc/issues/1703
+*/
+/**
+ * Prioritized list of possible implementations.
+ * @type {[string, function():(Function|*)][]}
+ */
 const possibleStringifiers = [
-  // prioritized list of possible implementations
-  'xmlbuilder2'
+  ['xmlbuilder2', () => require('./stringifiers/xmlbuilder2')]
 ]
+/* eslint-enable jsdoc/valid-types */
 
 module.exports.stringify = function () {
   throw new Error(
     'No stringifier available.' +
     ' Please install any of the optional dependencies: ' +
-    possibleStringifiers.join(', ')
+    possibleStringifiers.map(kv => kv[0]).join(', ')
   )
 }
 module.exports.stringify.fails = true
 
-for (const file of possibleStringifiers) {
+for (const [, getStringifier] of possibleStringifiers) {
   try {
-    const possibleStringifier = require(`./stringifiers/${file}`)
+    const possibleStringifier = getStringifier()
     if (typeof possibleStringifier === 'function') {
       module.exports.stringify = possibleStringifier
       break