Skip to content

Commit 3e95ac4

Browse files
author
Saquib Saifee
committed
refactor: create a private module-level constant for bom_link_prefix
Signed-off-by: Saquib Saifee <[email protected]>
1 parent ea6ab0a commit 3e95ac4

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

cyclonedx/model/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,6 +55,8 @@
5555
)
5656
from .bom_ref import BomRef
5757

58+
_BOM_LINK_PREFIX = 'urn:cdx:'
59+
5860

5961
@serializable.serializable_enum
6062
class DataFlow(str, Enum):
@@ -789,7 +791,7 @@ def make_bom_link(
789791
XsUri: Instance of XsUri with the generated BOM-Link URI.
790792
"""
791793
bom_ref_part = f'#{url_quote(str(bom_ref))}' if bom_ref else ''
792-
return cls(f'urn:cdx:{serial_number}/{version}{bom_ref_part}')
794+
return cls(f'{_BOM_LINK_PREFIX}{serial_number}/{version}{bom_ref_part}')
793795

794796
def is_bom_link(self) -> bool:
795797
"""
@@ -798,7 +800,7 @@ def is_bom_link(self) -> bool:
798800
Returns:
799801
`bool`
800802
"""
801-
return self._uri.startswith('urn:cdx:')
803+
return self._uri.startswith(_BOM_LINK_PREFIX)
802804

803805

804806
@serializable.serializable_class

cyclonedx/model/bom.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737
SchemaVersion1Dot6,
3838
)
3939
from ..serialization import LicenseRepositoryHelper, UrnUuidHelper
40-
from . import ExternalReference, Property
40+
from . import _BOM_LINK_PREFIX, ExternalReference, Property
4141
from .bom_ref import BomRef
4242
from .component import Component
4343
from .contact import OrganizationalContact, OrganizationalEntity
@@ -663,7 +663,7 @@ def register_dependency(self, target: Dependable, depends_on: Optional[Iterable[
663663
self.register_dependency(target=_d2, depends_on=None)
664664

665665
def urn(self) -> str:
666-
return f'urn:cdx:{self.serial_number}/{self.version}'
666+
return f'{_BOM_LINK_PREFIX}{self.serial_number}/{self.version}'
667667

668668
def validate(self) -> bool:
669669
"""

0 commit comments

Comments
 (0)