Skip to content

Commit 702893d

Browse files
committed
tetss: improved deseriualization assert/expect
Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 95fb0a2 commit 702893d

File tree

1 file changed

+22
-7
lines changed

1 file changed

+22
-7
lines changed

tests/test_model_tool_repository.py

Lines changed: 22 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,37 @@
3636

3737
class TestModelToolRepository(TestCase):
3838
def test_tool_with_component_and_service_load_json(self) -> None:
39+
expected = get_bom_with_tools_with_component_and_service_migrate()
3940
test_file = join(OWN_DATA_DIRECTORY, 'json', '1.5',
4041
'bom_with_tool_with_component_and_service.json')
4142
with open(test_file, encoding='UTF-8') as f:
4243
bom_json = json_loads(f.read())
4344
bom = Bom.from_json(bom_json) # type: ignore[attr-defined]
44-
good_bom = get_bom_with_tools_with_component_and_service_migrate()
45-
self.assertTrue(bom == good_bom)
45+
self.assertTupleEqual(
46+
tuple(bom.metadata.tools.components),
47+
tuple(expected.metadata.tools.components), 'components')
48+
self.assertTupleEqual(
49+
tuple(bom.metadata.tools.services),
50+
tuple(expected.metadata.tools.services), 'services')
51+
self.assertTupleEqual(
52+
tuple(bom.metadata.tools.tools),
53+
tuple(expected.metadata.tools.tools), 'tools')
4654

4755
def test_tool_with_component_and_service_load_xml(self) -> None:
56+
expected = get_bom_with_tools_with_component_and_service_migrate()
4857
test_file = join(OWN_DATA_DIRECTORY, 'xml', '1.5',
4958
'bom_with_tool_with_component_and_service.xml')
50-
with open(test_file, encoding='utf-8') as s:
51-
bom = Bom.from_xml(s) # type: ignore[attr-defined]
52-
self.assertEqual(bom.metadata.tools.components[0].type, 'application')
53-
self.assertEqual(bom.metadata.tools.components[0].name, 'test-component')
54-
self.assertEqual(bom.metadata.tools.services[0].name, 'test-service')
59+
with open(test_file, encoding='utf-8') as bom_xml:
60+
bom = Bom.from_xml(bom_xml) # type: ignore[attr-defined]
61+
self.assertTupleEqual(
62+
tuple(bom.metadata.tools.components),
63+
tuple(expected.metadata.tools.components), 'components')
64+
self.assertTupleEqual(
65+
tuple(bom.metadata.tools.services),
66+
tuple(expected.metadata.tools.services), 'services')
67+
self.assertTupleEqual(
68+
tuple(bom.metadata.tools.tools),
69+
tuple(expected.metadata.tools.tools), 'tools')
5570

5671
def test_assign_component(self) -> None:
5772
t = ToolsRepository()

0 commit comments

Comments
 (0)