fix: encode the reserved char, based on feedback

Signed-off-by: Saquib Saifee <[email protected]>

Author: Saquib Saifee

cyclonedx/model/__init__.py

@@ -787,7 +787,7 @@ def make_bom_link(
         Returns:
             XsUri: Instance of XsUri with the generated BOM-Link URI.
         """
-        bom_ref_part = f'#{bom_ref}' if bom_ref else ''
+        bom_ref_part = f'#{str(bom_ref).replace("%", "%25").replace("#", "%23")}' if bom_ref else ''
         uri = f'urn:cdx:{serial_number}/{version}{bom_ref_part}'
         return cls(uri)
 

tests/test_model.py

@@ -554,7 +554,7 @@ def test_make_bom_link_without_bom_ref(self) -> None:
     def test_make_bom_link_with_bom_ref(self) -> None:
         bom_link = XsUri.make_bom_link(UUID('e5a93409-fd7c-4ffa-bf7f-6dc1630b1b9d'),
                                        2, BomRef('componentA#sub-componentB%2'))
-        self.assertEqual(bom_link.uri, 'urn:cdx:e5a93409-fd7c-4ffa-bf7f-6dc1630b1b9d/2#componentA#sub-componentB%2')
+        self.assertEqual(bom_link.uri, 'urn:cdx:e5a93409-fd7c-4ffa-bf7f-6dc1630b1b9d/2#componentA%23sub-componentB%252')
 
 
 class TestModelProperty(TestCase):