Skip to content

Commit 970d192

Browse files
committed
fix: multiple hashes being created for an externalRefernce which is not as required
Signed-off-by: Paul Horton <[email protected]>
1 parent 7a49f9d commit 970d192

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

cyclonedx/model/__init__.py

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,11 +150,14 @@ class ExternalReference:
150150
_hashes: List[HashType] = []
151151

152152
def __init__(self, reference_type: ExternalReferenceType, url: str, comment: str = None,
153-
hashes: List[HashType] = []):
153+
hashes: List[HashType] = None):
154154
self._reference_type = reference_type
155155
self._url = url
156156
self._comment = comment
157-
self._hashes = hashes
157+
if not hashes:
158+
self._hashes.clear()
159+
else:
160+
self._hashes = hashes
158161

159162
def add_hash(self, our_hash: HashType):
160163
"""

tests/test_parser_pipenv.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,3 +34,4 @@ def test_simple(self):
3434
self.assertEqual('toml', components[0].get_name())
3535
self.assertEqual('0.10.2', components[0].get_version())
3636
self.assertEqual(len(components[0].get_external_references()), 2)
37+
self.assertEqual(len(components[0].get_external_references()[0].get_hashes()), 1)

0 commit comments

Comments
 (0)