Skip to content

Commit ac18c40

Browse files
committed
feat: bom-refs for known models
Signed-off-by: Jan Kowalleck <[email protected]>
1 parent bd5ee7a commit ac18c40

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

cyclonedx/model/contact.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ def __comparable_tuple(self) -> _ComparableTuple:
167167
self.country, self.region, self.locality, self.postal_code,
168168
self.post_office_box_number,
169169
self.street_address,
170-
None if self.bom_ref is None else self.bom_ref.value,
170+
self._bom_ref.value,
171171
))
172172

173173
def __eq__(self, other: object) -> bool:
@@ -277,7 +277,7 @@ def phone(self, phone: Optional[str]) -> None:
277277
def __comparable_tuple(self) -> _ComparableTuple:
278278
return _ComparableTuple((
279279
self.name, self.email, self.phone,
280-
self.bom_ref
280+
self._bom_ref.value,
281281
))
282282

283283
def __eq__(self, other: object) -> bool:
@@ -406,7 +406,8 @@ def contacts(self, contacts: Iterable[OrganizationalContact]) -> None:
406406

407407
def __comparable_tuple(self) -> _ComparableTuple:
408408
return _ComparableTuple((
409-
self.name, _ComparableTuple(self.urls), _ComparableTuple(self.contacts)
409+
self.name, _ComparableTuple(self.urls), _ComparableTuple(self.contacts),
410+
self._bom_ref.value,
410411
))
411412

412413
def __eq__(self, other: object) -> bool:

cyclonedx/model/license.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -238,7 +238,7 @@ def __comparable_tuple(self) -> _ComparableTuple:
238238
self._id, self._name,
239239
self._url,
240240
self._text,
241-
self._bom_ref,
241+
self._bom_ref.value,
242242
))
243243

244244
def __eq__(self, other: object) -> bool:
@@ -347,7 +347,7 @@ def __comparable_tuple(self) -> _ComparableTuple:
347347
return _ComparableTuple((
348348
self._acknowledgement,
349349
self._value,
350-
self.bom_ref,
350+
self._bom_ref.value,
351351
))
352352

353353
def __hash__(self) -> int:

0 commit comments

Comments
 (0)