resolve review comments

resolve review comments

Signed-off-by: Indivar Mishra <[email protected]>

Author: indiVar0508

cyclonedx/model/crypto.py

@@ -1309,13 +1309,13 @@ def __init__(
         version: Optional[str] = None,
         cipher_suites: Optional[Iterable[ProtocolPropertiesCipherSuite]] = None,
         ikev2_transform_types: Optional[Ikev2TransformTypes] = None,
-        crypto_ref_array: Optional[Iterable[BomRef]] = None,
+        crypto_refs: Optional[Iterable[BomRef]] = None,
     ) -> None:
         self.type = type
         self.version = version
         self.cipher_suites = cipher_suites or []  # type:ignore[assignment]
         self.ikev2_transform_types = ikev2_transform_types
-        self.crypto_ref_array = crypto_ref_array or []  # type:ignore[assignment]
+        self.crypto_refs = crypto_refs or []  # type:ignore[assignment]
 
     @property
     @serializable.xml_sequence(10)
@@ -1379,20 +1379,20 @@ def ikev2_transform_types(self, ikev2_transform_types: Optional[Ikev2TransformTy
         self._ikev2_transform_types = ikev2_transform_types
 
     @property
-    @serializable.xml_array(serializable.XmlArraySerializationType.FLAT, 'cryptoRefArray')
-    @serializable.xml_sequence(40)
-    def crypto_ref_array(self) -> 'SortedSet[BomRef]':
+    @serializable.xml_array(serializable.XmlArraySerializationType.FLAT, 'cryptoRef')
+    @serializable.json_name('cryptoRefArray')
+    def crypto_refs(self) -> 'SortedSet[BomRef]':
         """
         A list of protocol-related cryptographic assets.
 
         Returns:
             `Iterable[BomRef]`
         """
-        return self._crypto_ref_array
+        return self._crypto_refs
 
-    @crypto_ref_array.setter
-    def crypto_ref_array(self, crypto_ref_array: Iterable[BomRef]) -> None:
-        self._crypto_ref_array = SortedSet(crypto_ref_array)
+    @crypto_refs.setter
+    def crypto_refs(self, crypto_refs: Iterable[BomRef]) -> None:
+        self._crypto_refs = SortedSet(crypto_refs)
 
     def __eq__(self, other: object) -> bool:
         if isinstance(other, ProtocolProperties):
@@ -1406,7 +1406,7 @@ def __hash__(self) -> int:
                 self.version,
                 tuple(self.cipher_suites),
                 self.ikev2_transform_types,
-                tuple(self.crypto_ref_array)
+                tuple(self.crypto_refs)
             )
         )
 

cyclonedx/schema/_res/bom-1.6.SNAPSHOT.xsd

@@ -7429,7 +7429,7 @@ limitations under the License.
                                 </xs:sequence>
                             </xs:complexType>
                         </xs:element>
-                        <xs:element name="cryptoRefArray" type="bom:refType" minOccurs="0" maxOccurs="unbounded">
+                        <xs:element name="cryptoRef" type="bom:refType" minOccurs="0" maxOccurs="unbounded">
                             <xs:annotation>
                                 <xs:documentation>A protocol-related cryptographic assets</xs:documentation>
                             </xs:annotation>

tests/_data/models.py

@@ -725,7 +725,7 @@ def get_bom_for_issue_692_components() -> Bom:
             protocol_properties=ProtocolProperties(
                 type=ProtocolPropertiesType.TLS,
                 version='1.2',
-                crypto_ref_array=[BomRef(value='for-test')]
+                crypto_refs=[BomRef(value='for-test')]
             ),
             oid='1.3.18.0.2.32.104',
         ))