Skip to content

Commit f01665e

Browse files
committed
update to use Set operators (more Pythonic)
Signed-off-by: Paul Horton <[email protected]>
1 parent 2c7c4be commit f01665e

File tree

1 file changed

+4
-5
lines changed

1 file changed

+4
-5
lines changed

cyclonedx/model/bom.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -374,12 +374,11 @@ def validate(self) -> bool:
374374
"""
375375

376376
# 1. Make sure dependencies are all in this Bom.
377-
all_bom_refs = set([self.metadata.component.bom_ref] if self.metadata.component else []).union(
378-
set(map(lambda c: c.bom_ref, self.components)),
379-
set(map(lambda s: s.bom_ref, self.services))
380-
)
377+
all_bom_refs = set([self.metadata.component.bom_ref] if self.metadata.component else []) | set(
378+
map(lambda c: c.bom_ref, self.components)) | set(map(lambda s: s.bom_ref, self.services))
379+
381380
all_dependency_bom_refs = set().union(*(c.dependencies for c in self.components))
382-
dependency_diff = list(all_dependency_bom_refs.difference(all_bom_refs))
381+
dependency_diff = all_dependency_bom_refs - all_bom_refs
383382
if len(dependency_diff) > 0:
384383
raise UnknownComponentDependencyException(
385384
f'One or more Components have Dependency references to Components/Services that are not known in this '

0 commit comments

Comments
 (0)