Skip to content

Commit 74cff5a

Browse files
authored
chore: package-manager-cache: false (#1443)
caused by complete fuckup of the https://github.com/actions/setup-node authors. we dont want unexpected caching. we dont have a lockfile for a reason -- we want the latest versions, always. Signed-off-by: Jan Kowalleck <[email protected]>
1 parent d459cf1 commit 74cff5a

File tree

2 files changed

+14
-17
lines changed

2 files changed

+14
-17
lines changed

.github/workflows/nodejs.yml

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,10 @@ jobs:
3636
uses: actions/checkout@v5
3737
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
3838
# see https://github.com/actions/setup-node
39-
uses: actions/setup-node@v5
39+
uses: actions/setup-node@v6
4040
with:
4141
node-version: ${{ env.NODE_ACTIVE_LTS }}
42-
# cache: "npm"
43-
# cache-dependency-path: "**/package-lock.json"
42+
package-manager-cache: false
4443
- name: setup project
4544
run: npm i --ignore-scripts
4645
- name: build ${{ matrix.target }}
@@ -63,11 +62,10 @@ jobs:
6362
uses: actions/checkout@v5
6463
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
6564
# see https://github.com/actions/setup-node
66-
uses: actions/setup-node@v5
65+
uses: actions/setup-node@v6
6766
with:
6867
node-version: ${{ env.NODE_ACTIVE_LTS }}
69-
# cache: "npm"
70-
# cache-dependency-path: "**/package-lock.json"
68+
package-manager-cache: false
7169
- name: setup project
7270
run: |
7371
npm install --ignore-scripts --loglevel=silly
@@ -108,11 +106,10 @@ jobs:
108106
uses: actions/checkout@v5
109107
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
110108
# see https://github.com/actions/setup-node
111-
uses: actions/setup-node@v5
109+
uses: actions/setup-node@v6
112110
with:
113111
node-version: ${{ env.NODE_ACTIVE_LTS }}
114-
# cache: "npm"
115-
# cache-dependency-path: "**/package-lock.json"
112+
package-manager-cache: false
116113
- name: setup project
117114
run: npm install --ignore-scripts --loglevel=silly
118115
- name: setup tool
@@ -142,11 +139,10 @@ jobs:
142139
uses: actions/checkout@v5
143140
- name: Setup Node.js ${{ matrix.node-version }}
144141
# see https://github.com/actions/setup-node
145-
uses: actions/setup-node@v5
142+
uses: actions/setup-node@v6
146143
with:
147144
node-version: ${{ matrix.node-version }}
148-
# cache: "npm"
149-
# cache-dependency-path: "**/package-lock.json"
145+
package-manager-cache: false
150146
- # some integration tests require a certain npm version to be installable
151147
name: update npm
152148
run: |-
@@ -221,11 +217,10 @@ jobs:
221217
uses: actions/checkout@v5
222218
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
223219
# see https://github.com/actions/setup-node
224-
uses: actions/setup-node@v5
220+
uses: actions/setup-node@v6
225221
with:
226222
node-version: ${{ env.NODE_ACTIVE_LTS }}
227-
# cache: "npm"
228-
# cache-dependency-path: "**/package-lock.json"
223+
package-manager-cache: false
229224
- name: fetch build artifact
230225
# see https://github.com/actions/download-artifact
231226
uses: actions/download-artifact@v5

.github/workflows/release.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,10 @@ jobs:
5050
steps:
5151
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
5252
# see https://github.com/actions/setup-node
53-
uses: actions/setup-node@v5
53+
uses: actions/setup-node@v6
5454
with:
5555
node-version: ${{ env.NODE_ACTIVE_LTS }}
56+
package-manager-cache: false
5657
- name: Checkout code
5758
# see https://github.com/actions/checkout
5859
uses: actions/checkout@v5
@@ -104,9 +105,10 @@ jobs:
104105
ref: ${{ needs.bump.outputs.version }}
105106
- name: Setup Node.js ${{ env.NODE_ACTIVE_LTS }}
106107
# see https://github.com/actions/setup-node
107-
uses: actions/setup-node@v5
108+
uses: actions/setup-node@v6
108109
with:
109110
node-version: ${{ env.NODE_ACTIVE_LTS }}
111+
package-manager-cache: false
110112
- name: enable yarn # needed in some tests
111113
run: |-
112114
corepack enable

0 commit comments

Comments
 (0)