Skip to content

Commit b65ff1b

Browse files
authored
refactor: group output targets in plugin (#1377)
Signed-off-by: Jan Kowalleck <[email protected]>
1 parent fd144af commit b65ff1b

File tree

1 file changed

+14
-11
lines changed

1 file changed

+14
-11
lines changed

src/plugin.ts

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -216,31 +216,34 @@ export class CycloneDxWebpackPlugin {
216216
space: 2 // TODO add option to have this configurable
217217
}
218218

219+
const toBeSerialized = new Map<
220+
/* outputLocation */ string,
221+
[CDX.Serialize.Types.Serializer, undefined | CDX.Validation.Types.Validator]
222+
>()
223+
219224
let xmlSerializer: CDX.Serialize.XmlSerializer | undefined = undefined
220225
try {
221226
xmlSerializer = new CDX.Serialize.XmlSerializer(new CDX.Serialize.XML.Normalize.Factory(spec))
222227
} catch {
223228
/* pass */
224229
}
225-
const xmlValidator = this.validateResults && xmlSerializer !== undefined
226-
? new CDX.Validation.XmlValidator(spec.version)
227-
: undefined
230+
if (xmlSerializer !== undefined) {
231+
const xmlValidator = this.validateResults
232+
? new CDX.Validation.XmlValidator(spec.version)
233+
: undefined
234+
toBeSerialized.set(this.resultXml, [xmlSerializer, xmlValidator])
235+
}
228236

229237
let jsonSerializer: CDX.Serialize.JsonSerializer | undefined = undefined
230238
try {
231239
jsonSerializer = new CDX.Serialize.JsonSerializer(new CDX.Serialize.JSON.Normalize.Factory(spec))
232240
} catch {
233241
/* pass */
234242
}
235-
const jsonValidator = this.validateResults && jsonSerializer !== undefined
236-
? new CDX.Validation.JsonStrictValidator(spec.version)
237-
: undefined
238-
239-
const toBeSerialized = new Map<string, [CDX.Serialize.Types.Serializer, undefined | CDX.Validation.Types.Validator]>()
240-
if (xmlSerializer !== undefined) {
241-
toBeSerialized.set(this.resultXml, [xmlSerializer, xmlValidator])
242-
}
243243
if (jsonSerializer !== undefined) {
244+
const jsonValidator = this.validateResults
245+
? new CDX.Validation.JsonStrictValidator(spec.version)
246+
: undefined
244247
toBeSerialized.set(this.resultJson, [jsonSerializer, jsonValidator])
245248
if (this.resultWellknown !== undefined) {
246249
toBeSerialized.set(this.resultWellknown, [jsonSerializer, jsonValidator])

0 commit comments

Comments
 (0)