Skip to content

Commit 4df1429

Browse files
authored
tests: fix ProtoBuf breaking detection to be wire-only (#532)
our spec describes how data models look in data transfers. current protobuf breaking detection adheres this. the protobuf breaking detection also does unnecessary detections, which should not matter for our domain. they are removed, here. ---- changes are based on #530 (comment) --------- Signed-off-by: Jan Kowalleck <[email protected]>
1 parent 19a1530 commit 4df1429

File tree

3 files changed

+3
-5
lines changed

3 files changed

+3
-5
lines changed

tools/src/test/proto/buf_breaking-remote.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@
33
version: v1
44
breaking: # https://buf.build/docs/configuration/v1/buf-yaml#breaking
55
use: # see https://buf.build/docs/breaking/overview#rules-and-categories
6-
- FILE
7-
- WIRE_JSON
6+
- WIRE

tools/src/test/proto/buf_breaking-version.yaml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,7 @@
33
version: v1
44
breaking: # https://buf.build/docs/configuration/v1/buf-yaml#breaking
55
use: # see https://buf.build/docs/breaking/overview#rules-and-categories
6-
- FILE
7-
- WIRE_JSON
6+
- WIRE
87
except:
98
# scope is to detect changes from one version to the other -> so ignore "FILE_SAME_PACKAGE"
109
- FILE_SAME_PACKAGE

tools/src/test/proto/test.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,7 @@ function schema-breaking-version () {
6969
}
7070

7171
compare '1.6' '1.5'
72-
echo '>> skip compare' '1.5' '1.4' >&2 # <-- had breaking changes, which is acknowledged
72+
compare '1.5' '1.4'
7373
compare '1.4' '1.3'
7474

7575
echo '>> OK.' >&2

0 commit comments

Comments
 (0)