Merge remote-tracking branch 'origin/master-1.21-lts' into master-1.21

rubensworks · rubensworks · commit 9e3031f60fd6 · 2025-03-09T06:41:06.000+01:00
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -5,10 +5,27 @@ concurrency:
   group: ${{ github.workflow }}-${{ github.ref }}
   cancel-in-progress: true
 
+env:
+  DEFAULT_JAVA_VERSION: 21
+  DEFAULT_JAVA_DISTRIBUTION: 'microsoft'
+
 jobs:
   build:
-    name: Build
+    name: Build for Java ${{ matrix.java }} on ${{ matrix.distribution }}
     runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        java:
+          - 21
+          - 22
+          - 23
+        distribution:
+          - 'adopt-hotspot'
+          - 'oracle'
+        include:
+          - java: 21
+            distribution: 'microsoft'
     steps:
       - name: 'Checkout'
         uses: actions/checkout@v4
@@ -19,8 +36,8 @@ jobs:
       - name: 'Setup Java'
         uses: actions/setup-java@v4
         with:
-          distribution: 'microsoft'
-          java-version: 21
+          distribution: ${{ matrix.distribution }}
+          java-version: ${{ matrix.java }}
       - name: 'Setup Gradle'
         uses: gradle/actions/setup-gradle@v3
         with:
@@ -60,28 +77,30 @@ jobs:
         uses: coverallsapp/github-action@v2
       - name: 'Deploy as GitHub CI artifacts'
         uses: actions/upload-artifact@v4
+        if: startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.distribution, env.DEFAULT_JAVA_DISTRIBUTION)
         with:
           if-no-files-found: error
           path: build/libs/*
       - name: 'Deploy to CurseForge'
-        if: startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/master')
+        if: (startsWith(github.ref, 'refs/tags/') || (!startsWith(github.event.head_commit.message, 'Bump mod version') && startsWith(github.ref, 'refs/heads/master'))) && startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.distribution, env.DEFAULT_JAVA_DISTRIBUTION)
         env:
           CURSEFORGE_KEY_SECRET: ${{ secrets.CURSEFORGE_KEY_SECRET }}
         run: ./gradlew publishCurseForge
       - name: 'Deploy to Modrinth'
-        if: startsWith(github.ref, 'refs/tags/') || startsWith(github.ref, 'refs/heads/master')
+        continue-on-error: true
+        if: (startsWith(github.ref, 'refs/tags/') || (!startsWith(github.event.head_commit.message, 'Bump mod version') && startsWith(github.ref, 'refs/heads/master'))) && startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.distribution, env.DEFAULT_JAVA_DISTRIBUTION)
         env:
           MODRINTH_KEY_SECRET: ${{ secrets.MODRINTH_KEY_SECRET }}
         run: ./gradlew modrinth
       - name: 'Deploy to Maven'
-        if: startsWith(github.ref, 'refs/heads/master') || startsWith(github.ref, 'refs/heads/feature')
+        if: (startsWith(github.ref, 'refs/heads/master') || startsWith(github.ref, 'refs/heads/feature')) && startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.distribution, env.DEFAULT_JAVA_DISTRIBUTION)
         env:
           MAVEN_URL: ${{ secrets.MAVEN_URL }}
           MAVEN_USERNAME: ${{ secrets.MAVEN_USERNAME }}
           MAVEN_KEY: ${{ secrets.MAVEN_KEY }}
         run: ./gradlew publish
       - name: 'Deploy JavaDoc to GitHub Pages'
-        if: startsWith(github.ref, 'refs/heads/master')
+        if: startsWith(github.ref, 'refs/heads/master') && startsWith(matrix.java, env.DEFAULT_JAVA_VERSION) && startsWith(matrix.distribution, env.DEFAULT_JAVA_DISTRIBUTION)
         uses: JamesIves/github-pages-deploy-action@v4
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
diff --git a/.github/workflows/crowdin.yml b/.github/workflows/crowdin.yml
@@ -16,7 +16,7 @@ jobs:
         uses: crowdin/github-action@v2
         with:
           upload_sources: true
-          upload_translations: true
+          upload_translations: false
           download_translations: true
           localization_branch_name: l10n_crowdin_translations
           create_pull_request: true
diff --git a/README.md b/README.md
@@ -4,12 +4,12 @@
 [![Coverage Status](https://coveralls.io/repos/github/CyclopsMC/IntegratedScripting/badge.svg)](https://coveralls.io/github/CyclopsMC/IntegratedScripting)
 [![Download](https://img.shields.io/static/v1?label=Maven&message=GitHub%20Packages&color=blue)](https://github.com/CyclopsMC/packages/packages/1901862)
 [![Crowdin](https://badges.crowdin.net/integratedscripting/localized.svg)](https://crowdin.com/project/integratedscripting)
-[![CurseForge](http://cf.way2muchnoise.eu/full_889785_downloads.svg)](https://minecraft.curseforge.com/projects/integrated-scripting)
+[![CurseForge](http://cf.way2muchnoise.eu/full_889785_downloads.svg)](https://www.curseforge.com/minecraft/mc-mods/integrated-scripting)
 [![Discord](https://img.shields.io/discord/386052815128100865.svg?colorB=7289DA&logo=data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAHYAAABWAgMAAABnZYq0AAAACVBMVEUAAB38%2FPz%2F%2F%2F%2Bm8P%2F9AAAAAXRSTlMAQObYZgAAAAFiS0dEAIgFHUgAAAAJcEhZcwAACxMAAAsTAQCanBgAAAAHdElNRQfhBxwQJhxy2iqrAAABoElEQVRIx7WWzdGEIAyGgcMeKMESrMJ6rILZCiiBg4eYKr%2Fd1ZAfgXFm98sJfAyGNwno3G9sLucgYGpQ4OGVRxQTREMDZjF7ILSWjoiHo1n%2BE03Aw8p7CNY5IhkYd%2F%2F6MtO3f8BNhR1QWnarCH4tr6myl0cWgUVNcfMcXACP1hKrGMt8wcAyxide7Ymcgqale7hN6846uJCkQxw6GG7h2MH4Czz3cLqD1zHu0VOXMfZjHLoYvsdd0Q7ZvsOkafJ1P4QXxrWFd14wMc60h8JKCbyQvImzlFjyGoZTKzohwWR2UzSONHhYXBQOaKKsySsahwGGDnb%2FiYPJw22sCqzirSULYy1qtHhXGbtgrM0oagBV4XiTJok3GoLoDNH8ooTmBm7ZMsbpFzi2bgPGoXWXME6XT%2BRJ4GLddxJ4PpQy7tmfoU2HPN6cKg%2BledKHBKlF8oNSt5w5g5o8eXhu1IOlpl5kGerDxIVT%2BztzKepulD8utXqpChamkzzuo7xYGk%2FkpSYuviLXun5bzdRf0Krejzqyz7Z3p0I1v2d6HmA07dofmS48njAiuMgAAAAASUVORK5CYII%3D)](https://discord.gg/9yDxubB)
 
 Create scripts for handling operations in Integrated Dynamics.
 
-All stable releases (including deobfuscated builds) can be found on [CurseForge](https://minecraft.curseforge.com/projects/integrated-scripting/files).
+All stable releases (including deobfuscated builds) can be found on [CurseForge](https://www.curseforge.com/minecraft/mc-mods/integrated-scripting/files).
 
 [Development builds](https://github.com/CyclopsMC/packages/packages/) are hosted as GitHub packages.
 
diff --git a/build.gradle b/build.gradle
@@ -142,12 +142,14 @@ dependencies {
         transitive = false
     }
 
-    modLib "org.graalvm.sdk:graal-sdk:22.3.2"
-    shadow "org.graalvm.sdk:graal-sdk:22.3.2"
-    modLib ("org.graalvm.js:js:22.3.2") {
+    // https://mvnrepository.com/artifact/org.graalvm.sdk/graal-sdk
+    modLib "org.graalvm.sdk:graal-sdk:${project.graal_version}"
+    shadow "org.graalvm.sdk:graal-sdk:${project.graal_version}"
+    // https://mvnrepository.com/artifact/org.graalvm.js/js
+    modLib ("org.graalvm.js:js:${project.graal_version}") {
         exclude group: 'com.ibm.icu', module: 'icu4j'
     }
-    shadow "org.graalvm.js:js:22.3.2"
+    shadow "org.graalvm.js:js:${project.graal_version}"
 	
 	testImplementation "junit:junit:4.12"
     testImplementation "org.mockito:mockito-core:1.+"
@@ -255,8 +257,12 @@ shadowJar {
     archiveClassifier.set(''); // Replace the default JAR
     // To avoid clashes with other mods
     relocate 'org.graalvm', 'org.cyclops.integratedscripting.vendors.org.graalvm'
-    relocate 'com.oracle', 'org.cyclops.integratedscripting.vendors.com.oracle'
     relocate 'com.ibm', 'org.cyclops.integratedscripting.vendors.com.ibm'
+    // Relocate everything from com.oracle, except for com.oracle.truffle, as this is defined in a native lib, which can not be relocated
+//    relocate 'com.oracle', 'org.cyclops.integratedscripting.vendors.com.oracle'
+    relocate 'com.oracle.js', 'org.cyclops.integratedscripting.vendors.com.oracle.js'
+    relocate 'com.oracle.svm', 'org.cyclops.integratedscripting.vendors.com.oracle.svm'
+//    relocate 'com.oracle.truffle', 'org.cyclops.integratedscripting.vendors.com.oracle.truffle' // Relocation of this fails for com.oracle.truffle.runtime.ModulesSupport at runtime
 }
 assemble.dependsOn shadowJar
 jar {
@@ -426,3 +432,9 @@ tasks.configureEach { task ->
         task.enabled = false
     }
 }
+
+task benchmark(type: JavaExec) {
+    classpath sourceSets.test.runtimeClasspath
+    main = "org.cyclops.integratedscripting.evaluate.translation.BenchmarkValueTranslators"
+}
+test.dependsOn benchmark
diff --git a/gradle.properties b/gradle.properties
@@ -26,6 +26,7 @@ neoforge_loader_version_range=[4,)
 neoforge_update_json_url=https://raw.githubusercontent.com/CyclopsMC/Versions/master/neoforge_update/integrated-scripting.json
 
 # Dependencies
+graal_version=24.1.1
 cyclopscore_version=1.25.5-704
 integrateddynamics_version=1.24.1-1059
 commoncapabilities_version=2.9.7-194
diff --git a/resources/changelog/1.19.2-1.0.10.txt b/resources/changelog/1.19.2-1.0.10.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Changes:
+* Restrict access to parts of the Java API
+  They can still be enabled if desired by the server admin.
diff --git a/resources/changelog/1.19.2-1.0.8.txt b/resources/changelog/1.19.2-1.0.8.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Fix display panel crash when translation undefined values, Closes #27
diff --git a/resources/changelog/1.19.2-1.0.9.txt b/resources/changelog/1.19.2-1.0.9.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Fix infinite loop not being properly caught, Closes #28
+
diff --git a/resources/changelog/1.20.1-1.0.10.txt b/resources/changelog/1.20.1-1.0.10.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Update to graal 24.1.1, fixes issues for some JDK 23 users, Closes #30
diff --git a/resources/changelog/1.20.1-1.0.11.txt b/resources/changelog/1.20.1-1.0.11.txt
@@ -0,0 +1,7 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Re-enable shadow renames, except for com.oracle.truffle, Closes #32
+  This makes this mod work correctle on all JVMs, including GraalVM 21 and 23.
+
diff --git a/resources/changelog/1.20.1-1.0.12.txt b/resources/changelog/1.20.1-1.0.12.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Use jar-in-jar instead of shadowing, Closes #34
+
diff --git a/resources/changelog/1.20.1-1.0.13.txt b/resources/changelog/1.20.1-1.0.13.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Changes:
+* Restrict access to parts of the Java API
+  They can still be enabled if desired by the server admin.
diff --git a/resources/changelog/1.20.1-1.0.8.txt b/resources/changelog/1.20.1-1.0.8.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Fix display panel crash when translation undefined values, Closes #27
diff --git a/resources/changelog/1.20.1-1.0.9.txt b/resources/changelog/1.20.1-1.0.9.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.19.0 or higher.
+
+Fixes:
+* Fix infinite loop not being properly caught, Closes #28
diff --git a/resources/changelog/1.21.1-1.0.10.txt b/resources/changelog/1.21.1-1.0.10.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Fix display panel crash when translation undefined values, Closes #27
diff --git a/resources/changelog/1.21.1-1.0.11.txt b/resources/changelog/1.21.1-1.0.11.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Fix infinite loop not being properly caught, Closes #28
diff --git a/resources/changelog/1.21.1-1.0.12.txt b/resources/changelog/1.21.1-1.0.12.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Update to graal 24.1.1, fixes issues for some JDK 23 users, Closes #30
+
diff --git a/resources/changelog/1.21.1-1.0.13.txt b/resources/changelog/1.21.1-1.0.13.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Stop shadow renaming to fix breakage for graal 24+
diff --git a/resources/changelog/1.21.1-1.0.14.txt b/resources/changelog/1.21.1-1.0.14.txt
@@ -0,0 +1,7 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Re-enable shadow renames, except for com.oracle.truffle, Closes #32
+  This makes this mod work correctle on all JVMs, including GraalVM 21 and 23.
+
diff --git a/resources/changelog/1.21.1-1.0.15.txt b/resources/changelog/1.21.1-1.0.15.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Use jar-in-jar instead of shadowing, Closes #34
diff --git a/resources/changelog/1.21.1-1.0.16.txt b/resources/changelog/1.21.1-1.0.16.txt
@@ -0,0 +1,5 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Fixes:
+* Fix broken advancement icons
diff --git a/resources/changelog/1.21.1-1.0.17.txt b/resources/changelog/1.21.1-1.0.17.txt
@@ -0,0 +1,6 @@
+As always, don't forget to backup your world before updating!
+Requires CyclopsCore version 1.25.5 or higher.
+
+Changes:
+* Restrict access to parts of the Java API
+  They can still be enabled if desired by the server admin.
diff --git a/src/main/java/org/cyclops/integratedscripting/api/network/IScript.java b/src/main/java/org/cyclops/integratedscripting/api/network/IScript.java
@@ -1,5 +1,7 @@
 package org.cyclops.integratedscripting.api.network;
 
+import org.cyclops.integrateddynamics.api.evaluate.EvaluationException;
+
 import javax.annotation.Nullable;
 
 /**
@@ -14,7 +16,7 @@ public interface IScript {
      * @return The member, or null if it does not exist.
      */
     @Nullable
-    public IScriptMember getMember(String memberName);
+    public IScriptMember getMember(String memberName) throws EvaluationException;
 
     /**
      * Register a listener that will be invoked when this script gets invalidated.
diff --git a/src/main/java/org/cyclops/integratedscripting/core/evaluate/ScriptVariableFacadeHandler.java b/src/main/java/org/cyclops/integratedscripting/core/evaluate/ScriptVariableFacadeHandler.java
@@ -38,7 +38,7 @@ public ResourceLocation getUniqueName() {
 
     @Override
     public IScriptVariableFacade getVariableFacade(ValueDeseralizationContext valueDeseralizationContext, int id, CompoundTag tag) {
-        if(!tag.contains("disk", Tag.TAG_INT)) {
+        if(!tag.contains("disk", Tag.TAG_INT) && !tag.contains("disk", Tag.TAG_BYTE)) {
             return INVALID_FACADE;
         }
         if(!tag.contains("path", Tag.TAG_STRING)) {
diff --git a/src/main/java/org/cyclops/integratedscripting/core/network/GraalScript.java b/src/main/java/org/cyclops/integratedscripting/core/network/GraalScript.java
@@ -48,7 +48,7 @@ public GraalScript(Context graalContext, Value graalValue,
 
     @Nullable
     @Override
-    public IScriptMember getMember(String memberName) {
+    public IScriptMember getMember(String memberName) throws EvaluationException {
         Value member = this.graalValue.getMember(memberName);
         return member == null ? null : new GraalScript(this.graalContext, member, this.addInvalidationListener, this.removeInvalidationListener, disk, path, memberName, valueDeseralizationContext);
     }
diff --git a/src/main/java/org/cyclops/integratedscripting/evaluate/translation/ValueTranslatorRegistry.java b/src/main/java/org/cyclops/integratedscripting/evaluate/translation/ValueTranslatorRegistry.java
@@ -71,7 +71,7 @@ public IValueTranslator getScriptValueTranslator(Value scriptValue) {
     public <V extends IValue> V translateFromGraal(Context context, Value value, IEvaluationExceptionFactory exceptionFactory, ValueDeseralizationContext valueDeseralizationContext) throws EvaluationException {
         IValueTranslator translator = getScriptValueTranslator(value);
         if (translator == null) {
-            throw exceptionFactory.createError(Component.translatable("valuetype.integratedscripting.error.translation.unknown_from_graal", value));
+            throw exceptionFactory.createError(Component.translatable("valuetype.integratedscripting.error.translation.unknown_from_graal", value.toString()));
         }
         return (V) translator.translateFromGraal(context, value, exceptionFactory, valueDeseralizationContext);
     }
diff --git a/src/main/java/org/cyclops/integratedscripting/gametest/GameTestsScripts.java b/src/main/java/org/cyclops/integratedscripting/gametest/GameTestsScripts.java
@@ -1,13 +1,18 @@
 package org.cyclops.integratedscripting.gametest;
 
+import com.google.common.collect.Lists;
 import net.minecraft.core.BlockPos;
 import net.minecraft.gametest.framework.GameTest;
 import net.minecraft.gametest.framework.GameTestHelper;
+import net.minecraft.network.chat.Component;
 import net.minecraft.world.item.ItemStack;
+import net.minecraft.world.item.Items;
 import net.neoforged.neoforge.gametest.GameTestHolder;
 import net.neoforged.neoforge.gametest.PrefixGameTestTemplate;
 import org.apache.commons.lang3.tuple.Pair;
 import org.cyclops.integrateddynamics.core.evaluate.operator.Operators;
+import org.cyclops.integrateddynamics.core.evaluate.variable.ValueObjectTypeItemStack;
+import org.cyclops.integrateddynamics.core.evaluate.variable.ValueTypeBoolean;
 import org.cyclops.integrateddynamics.core.evaluate.variable.ValueTypeInteger;
 import org.cyclops.integrateddynamics.core.evaluate.variable.ValueTypes;
 import org.cyclops.integrateddynamics.part.PartTypePanelDisplay;
@@ -81,4 +86,66 @@ public void testScriptsDisplayScriptApplied(GameTestHelper helper) {
         });
     }
 
+    @GameTest(template = TEMPLATE_EMPTY, timeoutTicks = TIMEOUT)
+    public void testScriptsDisplayScriptOnItem(GameTestHelper helper) {
+        GameTestHelpersIntegratedScripting.NetworkPositions positions = createBasicNetwork(helper, POS);
+
+        // Write script
+        ScriptingNetworkHelpers.getScriptingData().setScript(positions.diskId(), Path.of("script0.js"), "function abc(item) { return item.isStackable() && item.size() >= 16; }", IScriptingData.ChangeLocation.MEMORY);
+
+        // Create variable from script
+        ItemStack variableScript = createVariableForScript(helper.getLevel(), positions.diskId(), Path.of("script0.js"), "abc");
+
+        // Create constants as input to the script's function
+        ItemStack variableConst1 = createVariableForValue(helper.getLevel(), ValueTypes.OBJECT_ITEMSTACK, ValueObjectTypeItemStack.ValueItemStack.of(new ItemStack(Items.APPLE, 32)));
+
+        // Insert all variables into the variable store
+        positions.variableStore().getInventory().setItem(0, variableScript);
+        positions.variableStore().getInventory().setItem(1, variableConst1);
+
+        // Create variable card for applying the function
+        ItemStack variableApplied = createVariableForOperator(helper.getLevel(), Operators.OPERATOR_APPLY, new int[]{
+                getVariableFacade(helper.getLevel(), variableScript).getId(),
+                getVariableFacade(helper.getLevel(), variableConst1).getId(),
+        });
+
+        // Place variable in display
+        Pair<PartTypePanelDisplay, PartTypePanelDisplay.State> partAndState = placeVariableInDisplayPanel(helper.getLevel(), positions.displayPanel(), variableApplied);
+
+        helper.succeedWhen(() -> {
+            assertValueEqual(partAndState.getRight().getDisplayValue(), ValueTypeBoolean.ValueBoolean.of(true));
+        });
+    }
+
+    @GameTest(template = TEMPLATE_EMPTY, timeoutTicks = TIMEOUT)
+    public void testScriptsDisplayScriptInfiniteLoop(GameTestHelper helper) {
+        GameTestHelpersIntegratedScripting.NetworkPositions positions = createBasicNetwork(helper, POS);
+
+        // Write script
+        ScriptingNetworkHelpers.getScriptingData().setScript(positions.diskId(), Path.of("script0.js"), "function oops() {\n" +
+                "    while (true) {}\n" +
+                "}", IScriptingData.ChangeLocation.MEMORY);
+
+        // Create variable from script
+        ItemStack variableScript = createVariableForScript(helper.getLevel(), positions.diskId(), Path.of("script0.js"), "abc");
+
+        // Insert all variables into the variable store
+        positions.variableStore().getInventory().setItem(0, variableScript);
+
+        // Create variable card for applying the function
+        ItemStack variableAdded = createVariableForOperator(helper.getLevel(), Operators.OPERATOR_APPLY_0, new int[]{
+                getVariableFacade(helper.getLevel(), variableScript).getId()
+        });
+
+        // Place variable in display
+        Pair<PartTypePanelDisplay, PartTypePanelDisplay.State> partAndState = placeVariableInDisplayPanel(helper.getLevel(), positions.displayPanel(), variableAdded);
+
+        helper.succeedWhen(() -> {
+            helper.assertValueEqual(partAndState.getRight().getGlobalErrors(), Lists.newArrayList(
+                    Component.translatable("script.integratedscripting.error.member_not_in_network", positions.diskId(), "abc", "script0.js"),
+                    Component.translatable("script.integratedscripting.error.member_not_in_network", positions.diskId(), "abc", "script0.js")
+            ), "Display panel errors do not match");
+        });
+    }
+
 }
diff --git a/src/main/resources/data/integratedscripting/advancement/terminal/bind.json b/src/main/resources/data/integratedscripting/advancement/terminal/bind.json
diff --git a/src/test/java/org/cyclops/integratedscripting/evaluate/translation/BenchmarkValueTranslators.java b/src/test/java/org/cyclops/integratedscripting/evaluate/translation/BenchmarkValueTranslators.java
