Please give us feedback and improvement points! #2021
Replies: 41 comments 77 replies
-
|
In Advanced Foundry Course, Section 3 - Develop Defi Protocol Lesson 16: DSCEngine advanced testing and Lesson 17: Write fuzz tests and contain the same video. |
Beta Was this translation helpful? Give feedback.
-
|
First of all, a supreme effort and a mega thanks to the Cyrfin team and @PatrickAlphaC sir for creating this course! I just had a few pieces of feedback:
Thankyou again!!! |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the course it's really good. I was wondering, is there a way to flag (or bookmark) a specific video so that we can easily come back to it later? I know we can leave it 'unchecked' but perhaps a quicker way would be to maybe filter and find all the bookmarked ones. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks a lot for the excellent educative course materials. The option to learn sectioned videos in Updraft instead of a combined long hours video is greatly appreciated. Would like to give generic improvement feedbacks as below:
|
Beta Was this translation helpful? Give feedback.
-
|
Thanks for this course Patrick, it was amazing. Really well explained.
uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(sender, address(collateral));The function it has this order of arguments: function getCollateralDepositedOfUser(address user, address token) external view returns(uint256)First is the address of the user and then the address of the token, in the video you put first the token and then the user: uint256 maxAmountCollateralToRedeem = engine.getCollateralDepositedOfUser(address(collateral), sender);I suppose it doens't fail because both are addresses, I looked at the logs and when we console
Regards, |
Beta Was this translation helpful? Give feedback.
-
|
In Blockchain Basics, Section 6 - The Purpose of Smart Contracts, the video cuts off a bit too early. The sentence was supposed to end with "and wash out the products that aren't actually contributing to Web3," It's not a big deal, but my perfectionist brain can't bear it. :) |
Beta Was this translation helpful? Give feedback.
-
|
In "Blockchain Basics 11. Quiz: Blockchain Basics Mid Section Recap" Question 4 "What is the role of the gas price in ETH?" refers to the next video of the course "12. Introduction to Gas". Shouldn't the videos be the other way around? Since the quiz asks about something we didn't see up to that point. |
Beta Was this translation helpful? Give feedback.
-
|
hey, I have a little question about quiz below: I think
|
Beta Was this translation helpful? Give feedback.
-
|
In Blockchain Basics course the written lesson on 16. Blockchain Overview has a small mistake in: Thanks for the amazing work you guys have been doing. I'm loving the course!! |
Beta Was this translation helpful? Give feedback.
-
|
In "New discussion" section, "Preview" isn't working properly |
Beta Was this translation helpful? Give feedback.
-
|
"IF YOU CAN" provide Patrick's codes used in Foundry Fundamentals, it would be very beneficial. Using the Solidity codes and the ones given in the repo, are giving countless errors. Even Phind ai can't help. And @EngrPips & others has to go through every line of the code provided to figure out what's wrong. This process eats up 2-3 days, thereby wasting the precious time of both, the questioner and solver. Thank you |
Beta Was this translation helpful? Give feedback.
-
|
lesson 6 part 3 to 7 is a bit difficult for windows users |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I noticed a blank part of the video in lesson 4, advanced foundry security section. |
Beta Was this translation helpful? Give feedback.
-
|
i had been in many other courses looking for problem to practice , not hard and does not require special website Thanks for consideration ,, |
Beta Was this translation helpful? Give feedback.
-
|
In the Advanced Foundry course, specifically in the '4. Introduction to IPFS' lesson, it seems that there are no subtitles available in Chinese. As I am not a native English speaker, I am having difficulty fully understanding the content of this video. Could you please consider adding Chinese subtitles? |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, I'll have a look at generating this on Monday. |
Beta Was this translation helpful? Give feedback.
-
|
Comment on Blockchain Basics |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
I am working on the Advanced Foundry , Develop an NFT Collection. but i cannot find _isApprovedOrOwner in the ERC721 Contract. I have set mine to Is this me or have things changed in the ERC721 openzepplin contract? Great course by the way |
Beta Was this translation helpful? Give feedback.
-
|
Hi, Can I use my phone to do all these cos my laptop is bad at the moment. |
Beta Was this translation helpful? Give feedback.
-
|
Hey @PatrickAlphaC, I appreciate you and your team (Cyfrin). The Aragon DAO tutorial is currently outdated, so I thought I would bring it to your notice. |
Beta Was this translation helpful? Give feedback.
-
|
Hi @PatrickAlphaC ! You have different written lessons and video lessons in Foundry Fundamentals, Raffle Lottery. In videos, you have a function namely |
Beta Was this translation helpful? Give feedback.
-
Beta Was this translation helpful? Give feedback.
-
|
It automatically answers the question without even touching any button
|
Beta Was this translation helpful? Give feedback.
-
|
Thank you so much @PatrickAlphaC for making such a wonderful course. Once again, thanks for this. Love from India. |
Beta Was this translation helpful? Give feedback.
-
|
Course Foundry Fundamentals Lesson 1.3 Development environment setup (Mac, Linux)
|
Beta Was this translation helpful? Give feedback.
-
|
In lesson 1.11 Memory Storage and Calldata of the course Solidity Smart Contract Development Clarification on “default to memory” wordingThe written lesson contains has the following warning:
While discussing this with ChatGPT, it was pointed out that this wording could potentially be misleading. The need to explicitly specify I’d be interested to hear if others agree with this interpretation or have additional insights. |
Beta Was this translation helpful? Give feedback.
This comment was marked as spam.
This comment was marked as spam.
-
|
In lesson 4.5 Creating Custom Errors of the course Foundry Fundamentals, I noticed two elements that initially confused me but that I later clarified experimenting and dicussing with ChatGPT. I think explicitly mentioning these could help other students too. 1. Gas efficiency when comparing functionsThe lesson compares gas usage between I experimented further and added multiple functions with identical logic but different names, reported gas costs can still differ. Additionally, adding another function, renaming a function, or changing their order can alter the gas numbers more than expected.
This led me to discover through ChatGPT that gas differences can come from function selectors and dispatcher routing, not just from the function body itself. In other words, identical logic does not always mean identical gas usage. 2. Contract layout vs. Solidity style guideThe lesson teaches being mindful of the contract layout when introducing custom errors, but I found it a bit confusing by comparing the official Solidity style guide with the commented code in the video. The Solidity documentation describes contract elements should be laid out in the following order:
While inside each contract, library or interface, the following is used:
The video seems to show a "customized summary" of the two orders above in the comment code. The lesson is excellent and very informative. These are just small clarity points that could help students who like to experiment and reason more deeply about gas usage and contract structure. In general I noticed that hands-on experimentation is a requirement to truly understand beyond watching the videos. |
Beta Was this translation helpful? Give feedback.















Uh oh!
There was an error while loading. Please reload this page.
-
In this thread, please leave feedback on your favorite parts, and least favorite parts of the course!
This way, we can keep updating so we can make Cyfrin Updraft easier and easier for you to learn.
CURRENT FEEDBACK POINTS:
Beta Was this translation helpful? Give feedback.
All reactions