TSwap Handler Test Error... #220

AllenGeorge08 · 2024-08-09T09:08:17Z

AllenGeorge08
Aug 9, 2024

Hey , there's still a error with how my values are bounded. Patrick's test is passing but mine is not

Here's the output



allen@LN08:~/Security-Course-Cyfrin/5-t-swap-audit$ forge test --mt invariant_constantProductFormulaStaysTheSameX -vvvv
[⠒] Compiling...
No files changed, compilation skipped

Ran 1 test for test/Invariants/Invariant.t.sol:Invariant
[FAIL. Reason: invariant_constantProductFormulaStaysTheSameX persisted failure revert]
        [Sequence]
                sender=0x000000000000000000000000b7397D7bAF72Fd8b addr=[test/Invariants/Handler.t.sol:Handler]0x5991A2dF15A8F6A256D3Ec51E99254Cd3fb576A9 calldata=swapPoolTokenForWethBasedOnOutputWeth(uint256) args=[320143 [3.201e5]]
 invariant_constantProductFormulaStaysTheSameX() (runs: 1, calls: 1, reverts: 1)
Logs:
  Bound result 49999999999000320144

Traces:
  [6682594] Invariant::setUp()
    ├─ [430367] → new ERC20Mock@0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f
    │   └─ ← [Return] 1924 bytes of code
    ├─ [430367] → new ERC20Mock@0x2e234DAe75C793f67A35089C9d99245E1C58470b
    │   └─ ← [Return] 1924 bytes of code
    ├─ [1940285] → new PoolFactory@0xF62849F9A0B5Bf2913b396098F7c7019b51A820a
    │   └─ ← [Return] 9690 bytes of code
    ├─ [1601851] PoolFactory::createPool(ERC20Mock: [0x2e234DAe75C793f67A35089C9d99245E1C58470b])
    │   ├─ [1178] ERC20Mock::name() [staticcall]
    │   │   └─ ← [Return] "Mock"
    │   ├─ [1178] ERC20Mock::name() [staticcall]
    │   │   └─ ← [Return] "Mock"
    │   ├─ [1516432] → new TSwapPool@0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2
    │   │   └─ ← [Return] 7330 bytes of code
    │   ├─ emit PoolCreated(tokenAddress: ERC20Mock: [0x2e234DAe75C793f67A35089C9d99245E1C58470b], poolAddress: TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2])
    │   └─ ← [Return] TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]
    ├─ [46789] ERC20Mock::mint(Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], 100000000000000000000 [1e20])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], value: 100000000000000000000 [1e20])
    │   └─ ← [Stop] 
    ├─ [46789] ERC20Mock::mint(Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], 50000000000000000000 [5e19])
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], value: 50000000000000000000 [5e19])
    │   └─ ← [Stop] 
    ├─ [24739] ERC20Mock::approve(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], 115792089237316195423570985008687907853269984665640564039457584007913129639935 [1.157e77])
    │   ├─ emit Approval(owner: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], spender: TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], value: 115792089237316195423570985008687907853269984665640564039457584007913129639935 [1.157e77])
    │   └─ ← [Return] true
    ├─ [24739] ERC20Mock::approve(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], 115792089237316195423570985008687907853269984665640564039457584007913129639935 [1.157e77])
    │   ├─ emit Approval(owner: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], spender: TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], value: 115792089237316195423570985008687907853269984665640564039457584007913129639935 [1.157e77])
    │   └─ ← [Return] true
    ├─ [103181] TSwapPool::deposit(50000000000000000000 [5e19], 50000000000000000000 [5e19], 100000000000000000000 [1e20], 1)
    │   ├─ emit Transfer(from: 0x0000000000000000000000000000000000000000, to: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], value: 50000000000000000000 [5e19])
    │   ├─ emit LiquidityAdded(liquidityProvider: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], wethDeposited: 100000000000000000000 [1e20], poolTokensDeposited: 50000000000000000000 [5e19])
    │   ├─ [25623] ERC20Mock::transferFrom(Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], 50000000000000000000 [5e19])
    │   │   ├─ emit Transfer(from: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], to: TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], value: 50000000000000000000 [5e19])
    │   │   └─ ← [Return] true
    │   ├─ [25623] ERC20Mock::transferFrom(Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], 100000000000000000000 [1e20])
    │   │   ├─ emit Transfer(from: Invariant: [0x7FA9385bE102ac3EAc297483Dd6233D62b3e1496], to: TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2], value: 100000000000000000000 [1e20])
    │   │   └─ ← [Return] true
    │   └─ ← [Return] 50000000000000000000 [5e19]
    ├─ [1687639] → new Handler@0x5991A2dF15A8F6A256D3Ec51E99254Cd3fb576A9
    │   ├─ [0] VM::addr(<pk>) [staticcall]
    │   │   └─ ← [Return] LP: [0x955F64CD937e5F7c2cda367b40B06388840F7a32]
    │   ├─ [0] VM::label(LP: [0x955F64CD937e5F7c2cda367b40B06388840F7a32], "LP")
    │   │   └─ ← [Return] 
    │   ├─ [0] VM::addr(<pk>) [staticcall]
    │   │   └─ ← [Return] swapper: [0x4A9D6b0b19CBFfCB0255550661eCB7014283c60E]
    │   ├─ [0] VM::label(swapper: [0x4A9D6b0b19CBFfCB0255550661eCB7014283c60E], "swapper")
    │   │   └─ ← [Return] 
    │   ├─ [270] TSwapPool::getWeth() [staticcall]
    │   │   └─ ← [Return] ERC20Mock: [0x5615dEB798BB3E4dFa0139dFa1b3D433Cc23b72f]
    │   ├─ [279] TSwapPool::getPoolToken() [staticcall]
    │   │   └─ ← [Return] ERC20Mock: [0x2e234DAe75C793f67A35089C9d99245E1C58470b]
    │   └─ ← [Return] 7728 bytes of code
    └─ ← [Stop] 

  [27027] Handler::swapPoolTokenForWethBasedOnOutputWeth(320143 [3.201e5])
    ├─ [281] TSwapPool::getMinimumWethDepositAmount() [staticcall]
    │   └─ ← [Return] 1000000000 [1e9]
    ├─ [2562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 50000000000000000000 [5e19]
    ├─ [0] console::log("Bound result", 49999999999000320144 [4.999e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 50000000000000000000 [5e19]
    ├─ [2562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 100000000000000000000 [1e20]
    ├─ [545] TSwapPool::getInputAmountBasedOnOutput(49999999999000320144 [4.999e19], 100000000000000000000 [1e20], 18446744073709551615 [1.844e19]) [staticcall]
    │   └─ ← [Revert] panic: arithmetic underflow or overflow (0x11)
    └─ ← [Revert] panic: arithmetic underflow or overflow (0x11)

  [13239] Invariant::invariant_constantProductFormulaStaysTheSameX()
    ├─ [2329] Handler::actualDeltaX() [staticcall]
    │   └─ ← [Return] 0
    ├─ [2308] Handler::expectedDeltaX() [staticcall]
    │   └─ ← [Return] 0
    ├─ [0] VM::assertEq(0, 0) [staticcall]
    │   └─ ← [Return] 
    └─ ← [Stop] 

Suite result: FAILED. 0 passed; 1 failed; 0 skipped; finished in 3.46ms (802.63µs CPU time)

Ran 1 test suite in 960.67ms (3.46ms CPU time): 0 tests passed, 1 failed, 0 skipped (1 total tests)

Failing tests:
Encountered 1 failing test in test/Invariants/Invariant.t.sol:Invariant
[FAIL. Reason: invariant_constantProductFormulaStaysTheSameX persisted failure revert]
        [Sequence]
                sender=0x000000000000000000000000b7397D7bAF72Fd8b addr=[test/Invariants/Handler.t.sol:Handler]0x5991A2dF15A8F6A256D3Ec51E99254Cd3fb576A9 calldata=swapPoolTokenForWethBasedOnOutputWeth(uint256) args=[320143 [3.201e5]]
 invariant_constantProductFormulaStaysTheSameX() (runs: 1, calls: 1, reverts: 1)

Encountered a total of 1 failing tests, 0 tests succeeded
allen@LN08:~/Security-Course-Cyfrin/5-t-swap-audit$

And here's my handler file


// SPDX-License-Identifier: SEE LICENSE IN LICENSE
pragma solidity 0.8.20;

import { Test, console2 } from "forge-std/Test.sol";
import { TSwapPool } from "../../src/TSwapPool.sol";
import { ERC20Mock } from "../mocks/ERC20Mock.sol";

contract Handler is Test {
    TSwapPool pool;
    ERC20Mock weth;
    ERC20Mock poolToken;

    //Ghost variables
    int256 startingY;
    int256 startingX;
    int256 public expectedDeltaY; //Change in token balances
    int256 public expectedDeltaX;
    int256 public actualDeltaX; //Change in token balances
    int256 public actualDeltaY;

    address liquidityProvider = makeAddr("LP");
    address swapper = makeAddr("swapper");

    constructor(TSwapPool _pool) {
        pool = _pool;
        weth = ERC20Mock(_pool.getWeth());
        poolToken = ERC20Mock(_pool.getPoolToken());
    }

    function swapPoolTokenForWethBasedOnOutputWeth(uint256 outputWeth) public {
        outputWeth = bound(outputWeth, pool.getMinimumWethDepositAmount(), weth.balanceOf(address(pool)));
        if (outputWeth >= weth.balanceOf(address(pool))) {
            return;
        }
        // DeltaX
        uint256 poolTokenAmount = pool.getInputAmountBasedOnOutput(
            outputWeth, poolToken.balanceOf(address(pool)), type(uint64).max
        );
        if (poolTokenAmount > type(uint64).max) {
            return;
        }

        startingY = int256(weth.balanceOf(address(pool)));
        startingX = int256(poolToken.balanceOf(address(pool)));

        expectedDeltaY = int256(-1) * int256(outputWeth); //pool is losing weth
        expectedDeltaX = int256(poolTokenAmount);

        if (poolToken.balanceOf(swapper) < poolTokenAmount) {
            poolToken.mint(swapper, poolTokenAmount - poolToken.balanceOf(swapper));
        }

        vm.startPrank(swapper);
        poolToken.approve(address(pool), type(uint256).max);
        pool.swapExactOutput(poolToken, weth, outputWeth, uint64(block.timestamp));
        vm.stopPrank();

        //Actual
        uint256 endingY = weth.balanceOf(address(pool));
        uint256 endingX = poolToken.balanceOf(address(pool));

        actualDeltaX = int256(endingX) - int256(startingX);
        actualDeltaY = int256(endingY) - int256(startingY);
    }

    // Deposit, swapExactOutput

    function deposit(uint256 wethAmount) public {
        //Let's make sure it's a reasonable amount
        //Avoid Weird overflow error

        uint256 minWeth  = pool.getMinimumWethDepositAmount();
        wethAmount = bound(wethAmount,minWeth,type(uint64).max);

        startingY = int256(weth.balanceOf(address(pool)));
        startingX = int256(poolToken.balanceOf(address(pool)));
        wethAmount = bound(wethAmount, 0, type(uint64).max); //Which equates to 18446744073709551615
        expectedDeltaY = int256(wethAmount);
        expectedDeltaX = int256(pool.getPoolTokensToDepositBasedOnWeth(wethAmount)); 

        //Deposit
        vm.startPrank(liquidityProvider);
        weth.mint(liquidityProvider, wethAmount);
        poolToken.mint(liquidityProvider, uint256(expectedDeltaX));
        weth.approve(address(pool), type(uint256).max);
        poolToken.approve(address(pool), type(uint256).max);

        pool.deposit(wethAmount, 0, uint256(expectedDeltaX), uint64(block.timestamp));
        vm.stopPrank();

        //Actual
        uint256 endingY = weth.balanceOf(address(pool));
        uint256 endingX = poolToken.balanceOf(address(pool));

        actualDeltaX = int256(endingX) - int256(startingX);
        actualDeltaY = int256(endingY) - int256(startingY);
    }
}

EngrPips · 2024-08-09T09:21:42Z

EngrPips
Aug 9, 2024

Hey @AllenOps08, Can you look into why your test is reverting with panic: arithmetic underflow or overflow (0x11) error as shown below?

[27027] Handler::swapPoolTokenForWethBasedOnOutputWeth(320143 [3.201e5])
    ├─ [281] TSwapPool::getMinimumWethDepositAmount() [staticcall]
    │   └─ ← [Return] 1000000000 [1e9]
    ├─ [2562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 50000000000000000000 [5e19]
    ├─ [0] console::log("Bound result", 49999999999000320144 [4.999e19]) [staticcall]
    │   └─ ← [Stop] 
    ├─ [562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 50000000000000000000 [5e19]
    ├─ [2562] ERC20Mock::balanceOf(TSwapPool: [0x4f81992FCe2E1846dD528eC0102e6eE1f61ed3e2]) [staticcall]
    │   └─ ← [Return] 100000000000000000000 [1e20]
    ├─ [545] TSwapPool::getInputAmountBasedOnOutput(49999999999000320144 [4.999e19], 100000000000000000000 [1e20], 18446744073709551615 [1.844e19]) [staticcall]
    │   └─ ← [Revert] panic: arithmetic underflow or overflow (0x11)
    └─ ← [Revert] panic: arithmetic underflow or overflow (0x11)

7 replies

EngrPips Aug 9, 2024

It's time to debug and find out why the values are not what they should be. It seems like you are depositing 0 collateral for some reason as shown by the stack trace below.

├─ [543] TSwapPool::deposit(0, 0, 0, 1)
    │   └─ ← [Revert] TSwapPool__MustBeMoreThanZero()
    └─ ← [Revert] TSwapPool__MustBeMoreThanZero()

Can you check why you are depositing 0 collateral?

AllenGeorge08 Aug 9, 2024
Author

I know I know😂..it's some kind of overflow/underflow due to the bound function. But I'm not able to figure it out..

EngrPips Aug 9, 2024

Start with using console.log to visualize values and seeing what values are not correct and at what point does value start going wild

AllenGeorge08 Aug 9, 2024
Author

Yep I did that😅..I declared wethAmount twice..Thanks bro. It's fixed.

EngrPips Aug 9, 2024

Glad for figuring out, keep crushing it!

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

TSwap Handler Test Error... #220

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{editor}}'s edit

{{editor}}'s edit

Uh oh!

Replies: 1 comment 7 replies

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Uh oh!

{{title}}

Uh oh!

Select a reply

Uh oh!

TSwap Handler Test Error... #220

Uh oh!

Uh oh!

AllenGeorge08 Aug 9, 2024

Replies: 1 comment · 7 replies

Uh oh!

EngrPips Aug 9, 2024

Uh oh!

EngrPips Aug 9, 2024

Uh oh!

AllenGeorge08 Aug 9, 2024 Author

Uh oh!

EngrPips Aug 9, 2024

Uh oh!

AllenGeorge08 Aug 9, 2024 Author

Uh oh!

EngrPips Aug 9, 2024

AllenGeorge08
Aug 9, 2024

Replies: 1 comment 7 replies

EngrPips
Aug 9, 2024

AllenGeorge08 Aug 9, 2024
Author

AllenGeorge08 Aug 9, 2024
Author