Skip to content

Commit f864b24

Browse files
committed
improvements
1 parent d3612eb commit f864b24

File tree

4 files changed

+77
-48
lines changed

4 files changed

+77
-48
lines changed

examples/example.c3p

2.79 KB
Binary file not shown.

examples/example.c3p.bak

167 KB
Binary file not shown.

src/instance.js

Lines changed: 70 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -507,11 +507,11 @@ function getInstanceJs(parentClass, addonTriggers, C3) {
507507
}, this.unsupportedEngine)
508508

509509
_AppendFile = this.wrap(super._AppendFile, async () => {
510-
throw new Error('Not implemented')
510+
throw new Error('"_AppendFile" Not implemented')
511511
}, this.unsupportedEngine)
512512

513513
_CopyFile = this.wrap(super._CopyFile, async () => {
514-
throw new Error('Not implemented')
514+
throw new Error('"_CopyFile" Not implemented')
515515
}, this.unsupportedEngine)
516516

517517
_CreateFolder = this.wrap(super._CreateFolder, async (path) => {
@@ -530,27 +530,38 @@ function getInstanceJs(parentClass, addonTriggers, C3) {
530530
}, this.unsupportedEngine)
531531

532532
_DeleteFile = this.wrap(super._DeleteFile, async () => {
533-
throw new Error('Not implemented')
533+
throw new Error('"_DeleteFile" Not implemented')
534534
}, this.unsupportedEngine)
535535

536536
_ListFiles = this.wrap(super._ListFiles, async () => {
537-
throw new Error('Not implemented')
537+
throw new Error('"_ListFiles" Not implemented')
538538
}, this.unsupportedEngine)
539539

540540
_MoveFile = this.wrap(super._MoveFile, async () => {
541-
throw new Error('Not implemented')
541+
throw new Error('"_MoveFile" Not implemented')
542542
}, this.unsupportedEngine)
543543

544544
_OpenBrowser = this.wrap(super._OpenBrowser, async () => {
545-
throw new Error('Not implemented')
545+
throw new Error('"_OpenBrowser" Not implemented')
546546
}, this.unsupportedEngine)
547547

548-
_ReadBinaryFile = this.wrap(super._ReadBinaryFile, async () => {
549-
throw new Error('Not implemented')
548+
_ReadBinaryFile = this.wrap(super._ReadBinaryFile, async (tag, path, destination) => {
549+
console.log('Read text', path);
550+
551+
/** @type {import('@pipelab/core').MakeInputOutput<import('@pipelab/core').MessageReadFileBinary, 'input'>} */
552+
const order = {
553+
url: '/fs/file/read/binary',
554+
body: {
555+
path,
556+
}
557+
}
558+
559+
const answer = await this.ws?.sendAndWaitForResponse(order)
560+
console.log('answer', answer)
550561
}, this.unsupportedEngine)
551562

552563
_RenameFile = this.wrap(super._RenameFile, async () => {
553-
throw new Error('Not implemented')
564+
throw new Error('"_RenameFile" Not implemented')
554565
}, this.unsupportedEngine)
555566

556567
_RunFile = this.wrap(super._RunFile, async (command) => {
@@ -650,138 +661,156 @@ function getInstanceJs(parentClass, addonTriggers, C3) {
650661
// Cnds
651662

652663
_OnFolderDialogCancel = this.wrap(super._OnFolderDialogCancel, () => {
653-
throw new Error('Not implemented')
664+
throw new Error('"_OnFolderDialogCancel" Not implemented')
654665
}, () => false)
655666

656667
_OnFolderDialogOk = this.wrap(super._OnFolderDialogOk, () => {
657-
throw new Error('Not implemented')
668+
throw new Error('"_OnFolderDialogOk" Not implemented')
658669
}, () => false)
659670

660671
_OnOpenDialogCancel = this.wrap(super._OnOpenDialogCancel, () => {
661-
throw new Error('Not implemented')
672+
throw new Error('"_OnOpenDialogCancel" Not implemented')
662673
}, () => false)
663674

664675
_OnOpenDialogOk = this.wrap(super._OnOpenDialogOk, () => {
665-
throw new Error('Not implemented')
676+
throw new Error('"_OnOpenDialogOk" Not implemented')
666677
}, () => false)
667678

668679
_OnSaveDialogCancel = this.wrap(super._OnSaveDialogCancel, () => {
669-
throw new Error('Not implemented')
680+
throw new Error('"_OnSaveDialogCancel" Not implemented')
670681
}, () => false)
671682

672683
_OnSaveDialogOk = this.wrap(super._OnSaveDialogOk, () => {
673-
throw new Error('Not implemented')
684+
throw new Error('"_OnSaveDialogOk" Not implemented')
674685
}, () => false)
675686

676687
_OnAnyBinaryFileRead = this.wrap(super._OnAnyBinaryFileRead, () => {
677-
throw new Error('Not implemented')
688+
throw new Error('"_OnAnyBinaryFileRead" Not implemented')
678689
}, () => false)
679690

680691
_OnAnyBinaryFileWrite = this.wrap(super._OnAnyBinaryFileWrite, () => {
681-
throw new Error('Not implemented')
692+
throw new Error('"_OnAnyBinaryFileWrite" Not implemented')
682693
}, () => false)
683694

684695
_OnBinaryFileRead = this.wrap(super._OnBinaryFileRead, () => {
685-
throw new Error('Not implemented')
696+
throw new Error('"_OnBinaryFileRead" Not implemented')
686697
}, () => false)
687698

688699
_OnBinaryFileWrite = this.wrap(super._OnBinaryFileWrite, () => {
689-
throw new Error('Not implemented')
700+
throw new Error('"_OnBinaryFileWrite" Not implemented')
690701
}, () => false)
691702

692703
_OnFileDropped = this.wrap(super._OnFileDropped, () => {
693-
throw new Error('Not implemented')
704+
throw new Error('"_OnFileDropped" Not implemented')
694705
}, () => false)
695706

696707
_OnFileSystemError = this.wrap(super._OnFileSystemError, () => {
697-
throw new Error('Not implemented')
708+
throw new Error('"_OnFileSystemError" Not implemented')
698709
}, () => false)
699710

700711
_OnPathVerification = this.wrap(super._OnPathVerification, () => {
701-
throw new Error('Not implemented')
712+
throw new Error('"_OnPathVerification" Not implemented')
702713
}, () => false)
703714

704715
// Exps
705716
_UserFolder = this.wrap(super._UserFolder, () => {
706717
console.log('this', this)
707-
return this._userFolder
718+
return this._userFolder ?? ''
708719
})
709720

710721
_ArgumentAt = this.wrap(super._ArgumentAt, () => {
711-
throw new Error('Not implemented')
722+
console.error('"_ArgumentAt" Not implemented')
723+
return ''
712724
})
713725

714726
_ArgumentCount = this.wrap(super._ArgumentCount, () => {
715-
throw new Error('Not implemented')
727+
console.error('"_ArgumentCount" Not implemented')
728+
return -1
716729
})
717730

718731
_ChosenPath = this.wrap(super._ChosenPath, () => {
719-
throw new Error('Not implemented')
732+
console.error('"_ChosenPath" Not implemented')
733+
return ''
720734
})
721735

722736
_AppFolder = this.wrap(super._AppFolder, () => {
723-
throw new Error('Not implemented')
737+
console.error('"_AppFolder" Not implemented')
738+
return ''
724739
})
725740

726741
_AppFolderURL = this.wrap(super._AppFolderURL, () => {
727-
throw new Error('Not implemented')
742+
console.error('"_AppFolderURL" Not implemented')
743+
return ''
728744
})
729745

730746
_DroppedFile = this.wrap(super._DroppedFile, () => {
731-
throw new Error('Not implemented')
747+
console.error('"_DroppedFile" Not implemented')
748+
return ''
732749
})
733750

734751
_FileError = this.wrap(super._FileError, () => {
735-
throw new Error('Not implemented')
752+
console.error('"_FileError" Not implemented')
753+
return ''
736754
})
737755

738756
_FileSize = this.wrap(super._FileSize, () => {
739-
throw new Error('Not implemented')
757+
console.error('"_FileSize" Not implemented')
758+
return -1
740759
})
741760

742761
_FileTag = this.wrap(super._FileTag, () => {
743-
throw new Error('Not implemented')
762+
console.error('"_FileTag" Not implemented')
763+
return ''
744764
})
745765

746766
_ListAt = this.wrap(super._ListAt, () => {
747-
throw new Error('Not implemented')
767+
console.error('"_ListAt" Not implemented')
768+
return ''
748769
})
749770

750771
_ListCount = this.wrap(super._ListCount, () => {
751-
throw new Error('Not implemented')
772+
console.error('"_ListCount" Not implemented')
773+
return -1
752774
})
753775

754776
_ProjectFilesFolder = this.wrap(super._ProjectFilesFolder, () => {
755-
throw new Error('Not implemented')
777+
console.error('"_ProjectFilesFolder" Not implemented')
778+
return ''
756779
})
757780

758781
_ProjectFilesFolderURL = this.wrap(super._ProjectFilesFolderURL, () => {
759-
throw new Error('Not implemented')
782+
console.error('"_ProjectFilesFolderURL" Not implemented')
783+
return ''
760784
})
761785

762786
_ReadFile = this.wrap(super._ReadFile, () => {
763787
return this._readFile ?? ''
764788
})
765789

766790
_WindowHeight = this.wrap(super._WindowHeight, () => {
767-
throw new Error('Not implemented')
791+
console.error('"_WindowHeight" Not implemented')
792+
return -1
768793
})
769794

770795
_WindowWidth = this.wrap(super._WindowWidth, () => {
771-
throw new Error('Not implemented')
796+
console.error('"_WindowWidth" Not implemented')
797+
return -1
772798
})
773799

774800
_WindowTitle = this.wrap(super._WindowTitle, () => {
775-
throw new Error('Not implemented')
801+
console.error('"_WindowTitle" Not implemented')
802+
return ''
776803
})
777804

778805
_WindowX = this.wrap(super._WindowX, () => {
779-
throw new Error('Not implemented')
806+
console.error('"_WindowX" Not implemented')
807+
return -1
780808
})
781809

782810
_WindowY = this.wrap(super._WindowY, () => {
783811
this._WindowX
784-
throw new Error('Not implemented')
812+
console.error('"this" Not implemented')
813+
return -1
785814
})
786815

787816
_IsEngine = this.wrap(super._IsEngine, (engine) => {

src/pluginConfig.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -617,7 +617,7 @@ const Config = /** @type {const} */({
617617
isAsync: true,
618618

619619
listName: "Request attention",
620-
displayText: "{0}",
620+
displayText: "Request window attention with mode {0}",
621621
description: "Start or stop requesting attention from the user, e.g. by flashing the title bar (depends on OS).",
622622
params: [
623623
{
@@ -652,7 +652,7 @@ const Config = /** @type {const} */({
652652
}
653653
],
654654
listName: "Set always on top",
655-
displayText: "{0}",
655+
displayText: "Set always on top to {0}",
656656
description: "Enable or disable the window always being on top of other windows.",
657657
},
658658

@@ -672,7 +672,7 @@ const Config = /** @type {const} */({
672672
}
673673
],
674674
listName: "Set height",
675-
displayText: "{0}",
675+
displayText: "Set windown height to {0}",
676676
description: "Set the height of the window.",
677677
},
678678

@@ -789,7 +789,7 @@ const Config = /** @type {const} */({
789789
}
790790
],
791791
listName: "Set width",
792-
displayText: "{0}",
792+
displayText: "Set windown width to {0}",
793793
description: "Set the width of the window.",
794794
},
795795

@@ -809,7 +809,7 @@ const Config = /** @type {const} */({
809809
}
810810
],
811811
listName: "Set x",
812-
displayText: "{0}",
812+
displayText: "Set window X position to {0}",
813813
description: "Set the x position of the window.",
814814
},
815815

@@ -829,7 +829,7 @@ const Config = /** @type {const} */({
829829
}
830830
],
831831
listName: "Set y",
832-
displayText: "{0}",
832+
displayText: "Set window Y position to {0}",
833833
description: "Set the y position of the window.",
834834
},
835835

@@ -852,7 +852,7 @@ const Config = /** @type {const} */({
852852
}
853853
],
854854
listName: "Show dev tools",
855-
displayText: "{0}",
855+
displayText: "Set devtool to {0}",
856856
description: "Show or hide the dev tools.",
857857
},
858858

0 commit comments

Comments
 (0)