[Proposal] Theme Customisation Settings Discussion

[NoelDavies]

Theme Definition files to allow for deep customisation

• Proposed
• Prototype: Complete
• Implementation: Todo

Summary

Need to pad this out, but more available here:

• https://github.com/Cysha/pokelink-web/blob/feature/customisation_settings_proposal/docs/customisation.md
• https://github.com/Cysha/pokelink-web/blob/feature/customisation_settings_proposal/themes/sports-game-scores/theme.json

One paragraph explanation of the feature.

Motivation

Why are we doing this? What use cases does it support? What is the expected outcome?

Detailed design

This is the bulk of the proposal. Explain the design in enough detail for somebody familiar with the language to understand, and for somebody familiar with the compiler to implement, and include examples of how the feature is used. This section can start out light before the prototyping phase but should get into specifics and corner-cases as the feature is iteratively designed and implemented.

Drawbacks (optional)

Why should we not do this?

[mmellado]

Checking this quickly I have one comment/question:

supportedGens - What games/gens your theme supports
I think this one is tricky because ultimately, I feel like the support is more defined by the sprites than anything else. I think what would make more sense is to add game/gen support for the different features of the theme

I'm also wondering, would this be something that the users would be able to dynamically customise using a UI? meaning, the app would present the different configuration settings as selectors for the user to pick the different aspects of customization for the theme?

I also think that support for vertical vs horizontal should be a default and instead we should add guidelines on the dimensions the browser view should bee created in OBS for the different aspect. I did that for my las commission and it felt pretty straightforward. (I can share an example once I'm on my PC)

[NoelDavies]

I think this one is tricky because ultimately, I feel like the support is more defined by the sprites than anything else. I think what would make more sense is to add game/gen support for the different features of the theme
I was more thinking this would be supportedGames in terms of data being used, The default sprite set would be irrelevant for this.

I'm also wondering, would this be something that the users would be able to dynamically customise using a UI? meaning, the app would present the different configuration settings as selectors for the user to pick the different aspects of customization for the theme?
Indeed > This is the Proof of concept I had so far

I also think that support for vertical vs horizontal should be a default
Maybe so, but should be defined by the theme to maximize efficiency / customisability

instead we should add guidelines on the dimensions the browser view should be created in OBS for the different aspect.
I think defo a "recommended web source dimensions" example should be given, or even multiple for diff configs?