Configure/Override Service Naming

[jeff-at-trimble]

Problem

MagicOnion seems to just use simple type name for services, rather than the full type name (including namespace). For example:

namespace MySystem.Manager.Admin.Employee 
{
    public interface IProfileAccess {}
}

namespace MySystem.Manager.Admin.Employee 
{
    public interface IProfileAccess {}
}

Options

Option A - Naming Convention (PREFERRED)

Something like this:

builder.Services.AddMagicOnion(options =>
{
    options.ServiceDefinitionConfig.NameStrategy = (Type type) => type.FullName;
});

Option B - Attribute

Provide an attribute that can be applied to the service interface with a string that becomes the service name.

[jeff-at-trimble]

After further investigation I found this PR that was meant to address exactly this issue:

#654

I'll investigate further and report back.

[jeff-at-trimble]

Ok, after further research it appears that the referenced issue above helps client-side dynamic client generation, but not server-side routing.

The referenced fix changes the generated client type name to include the interface namespace (so two interfaces with the same short name can both be created). The added test (SameInterfaceNameTest) only verifies you can call:

MagicOnionClient.Create<AreaA.IFoo>(...)

and
MagicOnionClient.Create<AreaB.IFoo>(...)

without a type-name collision.

But it seems that how endpoints are routed on the server is still an issue because MagicOnion still routes by the service interface name (not including namespace). If you map both AreaA and AreaB IFoo in one host, you still get a route conflict.