Skip to content

Commit 623f884

Browse files
committed
cleaned up unused functions in the unit tests that would fail with the changes in this branch
some cleanup, comments, helpful labels
1 parent a8f447a commit 623f884

File tree

10 files changed

+10
-90
lines changed

10 files changed

+10
-90
lines changed

tests/BlockUniTensor_test.h

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,17 +15,17 @@ class BlockUniTensorTest : public ::testing::Test {
1515
Bond B2 = Bond(BD_IN, {Qs(0), Qs(1)}, {3, 4});
1616
Bond B3 = Bond(BD_OUT, {Qs(0) >> 2, Qs(1) >> 3});
1717
Bond B4 = Bond(BD_OUT, {Qs(0), Qs(1)}, {1, 2});
18-
UniTensor BUT1 = UniTensor({B1, B2, B3, B4});
18+
UniTensor BUT1 = UniTensor({B1, B2, B3, B4}).set_name("BUT1");
1919

2020
Bond bd_sym_a = Bond(BD_KET, {{0, 2}, {3, 5}, {1, 6}, {4, 1}}, {4, 7, 2, 3});
2121
Bond bd_sym_b = Bond(BD_BRA, {{0, 2}, {3, 5}, {1, 6}, {4, 1}}, {4, 7, 2, 3});
22-
UniTensor BUT2 = UniTensor({bd_sym_a, bd_sym_b});
22+
UniTensor BUT2 = UniTensor({bd_sym_a, bd_sym_b}).set_name("BUT2");
2323

2424
Bond bd_sym_c =
2525
Bond(BD_KET, {{0, 2}, {1, 5}, {1, 6}, {0, 1}}, {4, 7, 2, 3}, {Symmetry::Zn(2), Symmetry::U1()});
2626
Bond bd_sym_d =
2727
Bond(BD_BRA, {{0, 2}, {1, 5}, {1, 6}, {0, 1}}, {4, 7, 2, 3}, {Symmetry::Zn(2), Symmetry::U1()});
28-
UniTensor BUT3 = UniTensor({bd_sym_c, bd_sym_d});
28+
UniTensor BUT3 = UniTensor({bd_sym_c, bd_sym_d}).set_name("BUT3");
2929

3030
Bond B1p = Bond(BD_IN, {Qs(-1), Qs(0), Qs(1)}, {2, 1, 2});
3131
Bond B2p = Bond(BD_OUT, {Qs(-1), Qs(0), Qs(1)}, {4, 3, 4});
@@ -114,7 +114,7 @@ class BlockUniTensorTest : public ::testing::Test {
114114

115115
protected:
116116
void SetUp() override {
117-
BUT4 = UniTensor::Load(data_dir + "OriginalBUT.cytnx");
117+
BUT4 = UniTensor::Load(data_dir + "OriginalBUT.cytnx").set_name("BUT4");
118118
BUT4_2 = UniTensor::Load(data_dir + "OriginalBUT2.cytnx");
119119
BUconjT4 = UniTensor::Load(data_dir + "BUconjT.cytnx");
120120
BUtrT4 = UniTensor::Load(data_dir + "BUtrT.cytnx");

tests/DenseUniTensor_test.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4004,7 +4004,7 @@ TEST_F(DenseUniTensorTest, Conj_utuninit) {
40044004
}
40054005

40064006
/*=====test info=====
4007-
describe:test Trnaspose
4007+
describe:test Transpose
40084008
====================*/
40094009
TEST_F(DenseUniTensorTest, Transpose) {
40104010
auto row_rank = 2u;
@@ -4018,7 +4018,7 @@ TEST_F(DenseUniTensorTest, Transpose) {
40184018
for (size_t i = 0; i < ut_t.rank(); i++) {
40194019
EXPECT_EQ(ut_t.bonds()[i].type(), BD_REG);
40204020
}
4021-
// a, b; c -> c;a, b
4021+
// a, b; c -> c; a, b
40224022
EXPECT_EQ(ut.labels(), std::vector<std::string>({"a", "b", "c"}));
40234023
EXPECT_EQ(ut_t.labels(), std::vector<std::string>({"c", "a", "b"}));
40244024
EXPECT_EQ(ut.rowrank(), row_rank);
@@ -4035,7 +4035,7 @@ TEST_F(DenseUniTensorTest, Transpose) {
40354035
}
40364036

40374037
/*=====test info=====
4038-
describe:test Trnaspose with diagonal UniTensor
4038+
describe:test Transpose with diagonal UniTensor
40394039
====================*/
40404040
TEST_F(DenseUniTensorTest, Transpose_diag) {
40414041
auto row_rank = 1u;
@@ -4052,7 +4052,7 @@ TEST_F(DenseUniTensorTest, Transpose_diag) {
40524052
for (size_t i = 0; i < ut_t.rank(); i++) {
40534053
EXPECT_EQ(ut_t.bonds()[i].type(), BD_REG);
40544054
}
4055-
// a, b; c -> c;a, b
4055+
// a; b -> b; a
40564056
EXPECT_EQ(ut_diag.labels(), std::vector<std::string>({"a", "b"}));
40574057
EXPECT_EQ(ut_t.labels(), std::vector<std::string>({"b", "a"}));
40584058
EXPECT_EQ(ut_diag.rowrank(), row_rank);
@@ -4065,7 +4065,7 @@ TEST_F(DenseUniTensorTest, Transpose_diag) {
40654065
}
40664066

40674067
/*=====test info=====
4068-
describe:test Trnaspose_
4068+
describe:test Transpose_
40694069
====================*/
40704070
TEST_F(DenseUniTensorTest, Transpose_) {
40714071
auto row_rank = 2u;
@@ -4081,7 +4081,7 @@ TEST_F(DenseUniTensorTest, Transpose_) {
40814081
}
40824082

40834083
/*=====test info=====
4084-
describe:test Trnaspose with uninitialized UniTensor
4084+
describe:test Transpose with uninitialized UniTensor
40854085
====================*/
40864086
TEST_F(DenseUniTensorTest, Transpose_uninit) {
40874087
EXPECT_ANY_THROW(ut_uninit.Transpose());

tests/gpu/linalg_test/GeSvd_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -381,16 +381,6 @@ namespace GesvdTest {
381381
return (relative_err < tol);
382382
}
383383

384-
// no use
385-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
386-
const UniTensor& U = Tout[1];
387-
const UniTensor& V = Tout[2];
388-
auto UD = U.Dagger();
389-
UD.set_labels({"0", "1", "9"});
390-
UD.permute_({2, 0, 1}, 1);
391-
auto UUD = Contract(U, UD);
392-
}
393-
394384
bool CheckResult(const std::string& case_name) {
395385
// test data source file
396386
std::string src_file_name = src_data_root + case_name + ".cytnx";

tests/gpu/linalg_test/Svd_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -382,16 +382,6 @@ namespace SvdTest {
382382
return (relative_err < tol);
383383
}
384384

385-
// no use
386-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
387-
const UniTensor& U = Tout[1];
388-
const UniTensor& V = Tout[2];
389-
auto UD = U.Dagger();
390-
UD.set_labels({"0", "1", "9"});
391-
UD.permute_({2, 0, 1}, 1);
392-
auto UUD = Contract(U, UD);
393-
}
394-
395385
bool CheckResult(const std::string& case_name) {
396386
// test data source file
397387
std::string src_file_name = src_data_root + case_name + ".cytnx";

tests/linalg_test/GeSvd_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -366,16 +366,6 @@ namespace GesvdTest {
366366
return (relative_err < tol);
367367
}
368368

369-
// no use
370-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
371-
const UniTensor& U = Tout[1];
372-
const UniTensor& V = Tout[2];
373-
auto UD = U.Dagger();
374-
UD.set_labels({"0", "1", "9"});
375-
UD.permute_({2, 0, 1}, 1);
376-
auto UUD = Contract(U, UD);
377-
}
378-
379369
bool CheckResult(const std::string& case_name) {
380370
// test data source file
381371
std::string src_file_name = src_data_root + case_name + ".cytnx";

tests/linalg_test/Gesvd_truncate_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -200,16 +200,6 @@ namespace GesvdTruncateTest {
200200
return (relative_err < tol);
201201
}
202202

203-
// no use
204-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
205-
const UniTensor& U = Tout[1];
206-
const UniTensor& V = Tout[2];
207-
auto UD = U.Dagger();
208-
UD.set_labels({"0", "1", "9"});
209-
UD.permute_({2, 0, 1}, 1);
210-
auto UUD = Contract(U, UD);
211-
}
212-
213203
bool CheckResult(const std::string& case_name, const cytnx_uint64& keepdim) {
214204
// test data source file
215205
std::string src_file_name = src_data_root + case_name + ".cytnx";

tests/linalg_test/Rsvd_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,6 @@ namespace RsvdTest {
181181
return (relative_err < tol);
182182
}
183183

184-
// no use
185-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
186-
const UniTensor& U = Tout[1];
187-
const UniTensor& V = Tout[2];
188-
auto UD = U.Dagger();
189-
UD.set_labels({"0", "1", "9"});
190-
UD.permute_({2, 0, 1}, 1);
191-
auto UUD = Contract(U, UD);
192-
}
193-
194184
bool CheckResult(const std::string& case_name, const cytnx_uint64& keepdim,
195185
const cytnx_uint64& power_iteration) {
196186
// test data source file

tests/linalg_test/Rsvd_truncate_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -181,16 +181,6 @@ namespace RsvdTruncateTest {
181181
return (relative_err < tol);
182182
}
183183

184-
// no use
185-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
186-
const UniTensor& U = Tout[1];
187-
const UniTensor& V = Tout[2];
188-
auto UD = U.Dagger();
189-
UD.set_labels({"0", "1", "9"});
190-
UD.permute_({2, 0, 1}, 1);
191-
auto UUD = Contract(U, UD);
192-
}
193-
194184
bool CheckResult(const std::string& case_name, const cytnx_uint64& keepdim,
195185
const cytnx_uint64& power_iteration) {
196186
// test data source file

tests/linalg_test/Svd_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -367,16 +367,6 @@ namespace SvdTest {
367367
return (relative_err < tol);
368368
}
369369

370-
// no use
371-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
372-
const UniTensor& U = Tout[1];
373-
const UniTensor& V = Tout[2];
374-
auto UD = U.Dagger();
375-
UD.set_labels({"0", "1", "9"});
376-
UD.permute_({2, 0, 1}, 1);
377-
auto UUD = Contract(U, UD);
378-
}
379-
380370
bool CheckResult(const std::string& case_name) {
381371
// test data source file
382372
std::string src_file_name = src_data_root + case_name + ".cytnx";

tests/linalg_test/Svd_truncate_test.cpp

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -184,16 +184,6 @@ namespace SvdTruncateTest {
184184
return (relative_err < tol);
185185
}
186186

187-
// no use
188-
void Check_UU_VV_Identity(const UniTensor& Tin, const std::vector<UniTensor>& Tout) {
189-
const UniTensor& U = Tout[1];
190-
const UniTensor& V = Tout[2];
191-
auto UD = U.Dagger();
192-
UD.set_labels({"0", "1", "9"});
193-
UD.permute_({2, 0, 1}, 1);
194-
auto UUD = Contract(U, UD);
195-
}
196-
197187
bool CheckResult(const std::string& case_name, const cytnx_uint64& keepdim) {
198188
// test data source file
199189
std::string src_file_name = src_data_root + case_name + ".cytnx";

0 commit comments

Comments
 (0)