Skip to content

Commit e01bbb6

Browse files
committed
Upgrade TypeScript and Node/Webpack types to fix CI gh-pages
gh-pages upgrade from previous commit required upgrading CI NodeJS version above v16, however doing so breaks some TypeScript types. Upgrade TS and Node/Webpack types to fix this
1 parent 863b70d commit e01bbb6

File tree

4 files changed

+49
-30
lines changed

4 files changed

+49
-30
lines changed

package-lock.json

Lines changed: 42 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525
"start:allowCorsAccess": "cross-env ALLOW_CORS_ACCESS=true npm start --",
2626
"mock": "cross-env MOCK=true npm start --",
2727
"mock:allowCorsAccess": "cross-env ALLOW_CORS_ACCESS=true npm run mock --",
28-
"test": "jest",
28+
"test": "jest --passWithNoTests",
2929
"lint": "eslint --ext $npm_package_config_eslintExtensions",
3030
"lint:all": "npm run lint -- .",
3131
"lint:fix": "npm run lint -- --fix",
@@ -85,12 +85,12 @@
8585
"@types/babel__core": "^7.1.19",
8686
"@types/jest": "^27.0.2",
8787
"@types/mkcert": "^1.2.0",
88-
"@types/node": "^16.11.4",
88+
"@types/node": "^22.13.8",
8989
"@types/react": "^18.0.8",
9090
"@types/react-dom": "^18.0.0",
9191
"@types/react-reconciler": "^0.26.6",
9292
"@types/svgo": "^2.6.3",
93-
"@types/webpack": "^5.28.0",
93+
"@types/webpack": "^5.28.5",
9494
"@types/webpack-dev-server": "^4.7.2",
9595
"@typescript-eslint/eslint-plugin": "^5.38.1",
9696
"@typescript-eslint/parser": "^5.38.1",
@@ -130,7 +130,7 @@
130130
"ts-loader": "^9.4.1",
131131
"ts-node": "^10.9.1",
132132
"tsconfig-paths": "^4.1.0",
133-
"typescript": "^4.8.4",
133+
"typescript": "^5.8.2",
134134
"webpack": "^5.67.0",
135135
"webpack-cli": "^4.9.2",
136136
"webpack-dev-server": "^4.7.3",

src/components/ui/ResourceViewer/ResourceViewer.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
import {
22
memo,
3+
type ReactNode,
34
type Ref,
45
} from 'react';
56

@@ -98,7 +99,7 @@ function ResourceViewer({
9899
type={mimeType}
99100
/>
100101
)}
101-
{children}
102+
{children as unknown as ReactNode}
102103
</object>
103104
);
104105
}

src/utils/Text.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ export async function blobToBase64(blob) {
140140
* byteArrayToHexString(myData, { hexPrefix: '0x', hexDelimiter: ' ' });
141141
* // Output: '0xAA 0xBB 0xCC'
142142
*
143-
* @param {ArrayBufferLike} uint8Array - Buffer to convert to a hex string.
143+
* @param {Array | ArrayLike | ArrayBuffer | ArrayBufferLike} uint8Array - Buffer to convert to a hex string.
144144
* @param {Object} [options]
145145
* @param {string} [options.hexPrefix] - Prefix to add to each hex entry (e.g. `0x`, `%00`, etc.).
146146
* @param {string} [options.hexDelimiter] - Delimiter to use when joining all hex entries as a string (is not prepended to the first hex entry).

0 commit comments

Comments
 (0)