review of simpleColor.d

Author: 1100110

examples/Makefile

@@ -1,6 +1,9 @@
-DMD=rdmd -g -w --build-only -ofbin/$@ -L-lncursesw $^
+DMD=rdmd -g -w --build-only -ofbin/$@ -I../ -L-lncursesw $^
 
-all: 	helloUnicode helloWorld
+all: 	init helloUnicode helloWorld simpleColor simpleKey keyCode
+	
+init: 
+	@echo "building all examples..."
 
 helloWorld: 	helloWorld.d
 	$(DMD)
@@ -14,5 +17,10 @@ simpleColor: 	simpleColor.d
 keyCode: 	keyCode.d
 	$(DMD)
 
+# TODO fix
+simpleKey: 	simpleKey.d
+	$(DMD)
+
 clean: 
 	@rm bin/*
+	@echo "done."

examples/README.md

@@ -5,13 +5,26 @@ Here are a few examples to get you started.
 The main site where these examples were originally found is here [tldp.org](http://tldp.org/HOWTO/NCURSES-Programming-HOWTO/)
 These examples need some work, but they should demonstrate that most everything is in working order.
 
+All of the files *should* be executable and set to link with ncursesw by default.
+If you have rdmd installed in /usr/bin/rdmd, then ./helloWorld.d should get you going!
+
+if not, then make [filename], and the programs will be in ./bin/
+
 ### Requirements:
     - [rdmd](http://github.com/D-Programming-Language/tools)
     - ncursesw
 
 ### Files
+    - helloWorld.d   - a simple hello world example.
+    - helloUnicode.d - a simple unicode example.
+    - keyCode.d      - returns the number code of the key you pressed.
+    - simpleColor.d  - a simple example that demonstrates color output.
 
-
+### TODO
+[ ] review, and fix anything that's broken.
+[ ] cosmetic alterations.
+[ ] add to travis.
+[ ] fix so that examples are compilable on Windows.
 
 Again, please file any bugs that you come across.
 Even if you don't know if it is actually a bug, we appreciate the time.  

examples/simpleColor.d

@@ -1,15 +1,18 @@
 #!/usr/bin/rdmd -L-lncursesw
 //Modified by: 1100110
-import std.stdio:   writeln;
-import std.string:  toStringz;
+import std.conv:        to;
+import std.stdio:       writeln;
+import std.string:      toStringz;
 import deimos.ncurses.ncurses;
 
 
 int main() {
-    initscr();                              //Start curses mode
+    initscr();
+    scope(failure)  endwin();
+    scope(exit)     endwin(); 
 
-    if(has_colors() == false)
-    {
+
+    if(has_colors() == false) {
         endwin();
         writeln("Your terminal does not support color... Goodbye");
         return 1;
@@ -19,17 +22,16 @@ int main() {
     init_pair(1, COLOR_RED, COLOR_BLACK);
 
     attron(COLOR_PAIR(1));
-    print_in_middle(stdscr, LINES/2, 0, 0, "Voila !!! In color...  =)");
+    print_in_middle(stdscr,  "Voila !!! In color...  =)", LINES/2, 0, 0,);
     attroff(COLOR_PAIR(1));
 
     getch();
-    endwin();
 
     return 0;
 }
 
 
-void print_in_middle(WINDOW *win, int starty, int startx, int width, string str)
+void print_in_middle(WINDOW *win, string str, int starty = LINES/2, int startx=0, int width=0)
 {
     int length, x, y;
 
@@ -48,7 +50,7 @@ void print_in_middle(WINDOW *win, int starty, int startx, int width, string str)
 
     //int already takes the floor, we can change temp to int.
     float temp = (width - str.length)/ 2;
-    x = startx + cast(int)temp;
+    x = startx + temp.to!int;
 
     mvwprintw(win, y, x, "%s", toStringz(str));